Page MenuHomePhabricator

jasonmolenda (Jason Molenda)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2014, 12:05 PM (379 w, 1 d)

Recent Activity

Thu, Dec 2

jasonmolenda committed rGfddafa110d86: Simplify logic to identify dyld_sim in Simulator debugging on macos (authored by jasonmolenda).
Simplify logic to identify dyld_sim in Simulator debugging on macos
Thu, Dec 2, 6:14 PM
jasonmolenda closed D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos.
Thu, Dec 2, 6:14 PM · Restricted Project
jasonmolenda requested review of D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos.
Thu, Dec 2, 2:45 PM · Restricted Project

Wed, Nov 10

jasonmolenda accepted D113598: [debugserver] Remove unused variable.

LGTM

Wed, Nov 10, 11:27 AM · Restricted Project

Nov 8 2021

jasonmolenda accepted D112931: Fix mixed disassembly showing source lines for "line 0".

Hi Ted, sorry for not getting back to you earlier on this, yes this looks unintentional to me and I think this change is good. Nice test case. Thanks for the ping.

Nov 8 2021, 2:13 PM · Restricted Project

Nov 3 2021

jasonmolenda accepted D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC).

Nice cleanup of this table that's been growing over the years.

Nov 3 2021, 11:04 PM · Restricted Project
jasonmolenda accepted D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex.

Yep, looks good, we can't hardcode the OS in this triple, we might be getting iOS or macOS binaries and should accept any OS these days.

Nov 3 2021, 11:01 PM · Restricted Project

Oct 25 2021

jasonmolenda accepted D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack.

Sorry for the delay in looking at this one. Yes, we usually put a new debugserver on devices every year, and we don't need to support devices this old any more, this is fine to remove. Thanks!

Oct 25 2021, 10:26 AM · Restricted Project

Oct 22 2021

jasonmolenda committed rGe4235bdf26a2: Fix locals naming in DNBArchMachARM64::GetGPRState for 32-bit builds (authored by jasonmolenda).
Fix locals naming in DNBArchMachARM64::GetGPRState for 32-bit builds
Oct 22 2021, 1:24 PM

Oct 14 2021

jasonmolenda committed rG35d710148b98: Use Module's FileSpec for limiting binaries to set dyld breakpoint in (authored by jasonmolenda).
Use Module's FileSpec for limiting binaries to set dyld breakpoint in
Oct 14 2021, 11:59 PM

Oct 11 2021

jasonmolenda accepted D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages.
Oct 11 2021, 10:46 AM · Restricted Project
jasonmolenda added a comment to D110510: [lldb] Remove "0x" prefix from hex values in dirty-pages.

I'm fine with the change, it's true it's inconsistent but I also hate how we don't prefix base16 numbers in gdb RSP - so many bugs and mistakes are introduced because of it. So I'm always trying to sneak in some 0x prefixes when no one is looking. A fun one I saw the other day - in qHostInfo the cputype field is base16, in qProcessInfo the cputype field is base10. Sweet.

Oct 11 2021, 10:46 AM · Restricted Project

Oct 6 2021

jasonmolenda committed rG62d9163830d0: Don't register mem segments that aren't present in a corefile (authored by jasonmolenda).
Don't register mem segments that aren't present in a corefile
Oct 6 2021, 8:12 PM
jasonmolenda committed rG809652c93ba6: Update TODO noting that DriverKit should be added too (authored by jasonmolenda).
Update TODO noting that DriverKit should be added too
Oct 6 2021, 8:12 PM
jasonmolenda added a comment to D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack.

Another possible approach would be to allow an ExecutionContext with a nullptr Target to push on to the stack, but then in CommandInterpeter::GetExecutionContext skip over those until we find one with a Target, or fall back to the Debugger::GetSelectedExecutionContext like we do with an empty stack.

Oct 6 2021, 1:09 AM · Restricted Project
jasonmolenda requested review of D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack.
Oct 6 2021, 12:57 AM · Restricted Project

Sep 24 2021

jasonmolenda committed rGa2e1d68fa97d: Add pragma to make it easier to find "image list" impl (authored by jasonmolenda).
Add pragma to make it easier to find "image list" impl
Sep 24 2021, 5:13 PM

Sep 21 2021

jasonmolenda added a comment to D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present.

Without having dug into this deeper, do you think not specifying the arch could cause any problems with universal binaries? I guess not, because we still have the UUID, and the UUID is per arch?

Sep 21 2021, 4:14 PM · Restricted Project

Sep 17 2021

jasonmolenda accepted D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present.

Yeah, on macOS we'll always have a UUID so this is a good change. The only time an arch is really important is if we don't have a UUID and we have a universal binary (aka fat file) & need to select the correct architecture.

Sep 17 2021, 11:21 PM · Restricted Project

Sep 16 2021

jasonmolenda committed rGceded4153245: Don't set executable file in ObjectFileMachO::LoadCoreFileImages (authored by jasonmolenda).
Don't set executable file in ObjectFileMachO::LoadCoreFileImages
Sep 16 2021, 1:39 AM

Sep 15 2021

jasonmolenda accepted D109795: [MachCore] Report arm64 thread exception state.
Sep 15 2021, 4:44 PM · Restricted Project
jasonmolenda added a comment to D109795: [MachCore] Report arm64 thread exception state.

very nice.

Sep 15 2021, 4:43 PM · Restricted Project
jasonmolenda added inline comments to D109795: [MachCore] Report arm64 thread exception state.
Sep 15 2021, 3:06 PM · Restricted Project

Sep 14 2021

jasonmolenda added inline comments to D109795: [MachCore] Report arm64 thread exception state.
Sep 14 2021, 8:03 PM · Restricted Project
jasonmolenda added a comment to D109795: [MachCore] Report arm64 thread exception state.

This is much more comprehensive than what I was thinking of, nicely done. The mapping of the Exception Class in the esr reg to a name is AArch64 specific, not Apple specific, isn't it? I haven't looked in the ARM ARM, but I suspect it's just the specific names you're using here which might be what we use at apple, but the exception codes are the same for any AArch64 target.

Sep 14 2021, 8:01 PM · Restricted Project

Sep 10 2021

jasonmolenda committed rG89ed21a8f864: Recognize namespaced all_image_infos symbol name from dyld (authored by jasonmolenda).
Recognize namespaced all_image_infos symbol name from dyld
Sep 10 2021, 4:59 PM

Sep 9 2021

jasonmolenda committed rGf3472ad5c5f8: Add specific error messages around gdb RSP handshake failures (authored by jasonmolenda).
Add specific error messages around gdb RSP handshake failures
Sep 9 2021, 5:04 PM
jasonmolenda committed rG766afbc8042b: Don't re-define constants that are now in compact_unwind_encoding.h. (authored by jasonmolenda).
Don't re-define constants that are now in compact_unwind_encoding.h.
Sep 9 2021, 5:04 PM
jasonmolenda closed D108888: Improve error messaging on process connect errors.
Sep 9 2021, 5:04 PM · Restricted Project

Aug 31 2021

jasonmolenda committed rGc1184ca6eb97: Use dSYM's file addr for Sections when it doesn't match binary (authored by jasonmolenda).
Use dSYM's file addr for Sections when it doesn't match binary
Aug 31 2021, 1:35 AM
jasonmolenda closed D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO.
Aug 31 2021, 1:35 AM · Restricted Project
jasonmolenda updated the diff for D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO.

Update patch to incorporate Greg's suggestion.

Aug 31 2021, 1:32 AM · Restricted Project

Aug 30 2021

jasonmolenda added a comment to D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO.

So do the shared library files on disk that are exploded from a shared cache of an iOS device have the file addresses set to where they are in the shared cache? I am guessing this must the issue that you were running into where the module was not in memory by still it needed to have its file addresses adjusted.

Aug 30 2021, 3:51 PM · Restricted Project

Aug 29 2021

jasonmolenda added a comment to D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO.

I should note two more things. First, I make this code which was previously checking if the ObjectFile was a memory image unconditional if the dSYM's segment file address differs from the ObjectFile's segment file address. I can't see how this is possible in any case but a shared cache -- so I could check that the ObjectFile is in the shared cache -- but however we got to this point, the only correct thing to do is to use the dSYM (SymbolFile)'s file addresses, it's immaterial.

Aug 29 2021, 2:04 AM · Restricted Project
jasonmolenda requested review of D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO.
Aug 29 2021, 1:55 AM · Restricted Project
jasonmolenda requested review of D108888: Improve error messaging on process connect errors.
Aug 29 2021, 1:41 AM · Restricted Project

Aug 16 2021

jasonmolenda committed rGaa575ed91863: Ah, fix formatting, I didn't notice lldb-instr's code (authored by jasonmolenda).
Ah, fix formatting, I didn't notice lldb-instr's code
Aug 16 2021, 1:47 PM
jasonmolenda committed rG65bc8ba1a2d4: Correctly update reproducer hooks for SB API I added (authored by jasonmolenda).
Correctly update reproducer hooks for SB API I added
Aug 16 2021, 1:41 PM
jasonmolenda accepted D108145: [lldb] Make TestAArch64AdrpAdd depend on the AArch64 target.

Thanks!! I missed that.

Aug 16 2021, 10:57 AM · Restricted Project

Aug 12 2021

jasonmolenda committed rG7150b562081f: Symbolicate aarch64 adrp+add pc-relative addr in disass (authored by jasonmolenda).
Symbolicate aarch64 adrp+add pc-relative addr in disass
Aug 12 2021, 2:44 PM
jasonmolenda closed D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.
Aug 12 2021, 2:44 PM · Restricted Project
jasonmolenda updated the diff for D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.

Address David's second review comments -- explained the unusual formatting of the main.c in the test case, change the m_adrp_insn to be an Optional instead of using 0 as a "not-set" value. I'll prob land this tomorrow unless someone has additional feedback, I think it's in reasonable shape.

Aug 12 2021, 12:44 AM · Restricted Project

Aug 11 2021

jasonmolenda committed rG7ce739a87834: Update gdbremote_testcase.py to allow new k-v pair in qMemoryRegionInfo (authored by jasonmolenda).
Update gdbremote_testcase.py to allow new k-v pair in qMemoryRegionInfo
Aug 11 2021, 5:35 PM
jasonmolenda committed rG2b30fc2ff3ca: Fix two bugs with stack corefiles patch, restrict test built debugserver (authored by jasonmolenda).
Fix two bugs with stack corefiles patch, restrict test built debugserver
Aug 11 2021, 5:20 PM
jasonmolenda committed rG8c31efeed600: Add the ability to process save-core stack-memory-only corefiles (authored by jasonmolenda).
Add the ability to process save-core stack-memory-only corefiles
Aug 11 2021, 1:39 PM
jasonmolenda closed D107625: Add a stack-memory-only style for Darwin process save-core.
Aug 11 2021, 1:39 PM · Restricted Project

Aug 9 2021

jasonmolenda updated the diff for D107625: Add a stack-memory-only style for Darwin process save-core.

Have debugserver report malloc memory regions too, aka heap. I don't know how to use this in lldb yet, but it was easy to add so I thought I'd add it. Maybe we'll come up with an idea for it later. On Darwin, there are multiple types of heap - malloc small, malloc large, malloc tiny, etc - so for these, debugserver will return "type:heap,malloc-small;" etc, so the generic "heap" word is there, but also the more darwin-specific type of heap is given.

Aug 9 2021, 4:52 PM · Restricted Project

Aug 6 2021

jasonmolenda added a comment to D107182: [LLDB][GUI] Refactor form drawing using subsurfaces.

@jasonmolenda Okay, I will just reimplement the patch without is_pad somehow.

Aug 6 2021, 2:16 AM · Restricted Project
jasonmolenda updated the diff for D107625: Add a stack-memory-only style for Darwin process save-core.

Handle a bit of state tracking in ObjectFileMachO a little bit more readably.

Aug 6 2021, 2:13 AM · Restricted Project
jasonmolenda added a comment to D107182: [LLDB][GUI] Refactor form drawing using subsurfaces.

is_pad was added in 2009 in ncurses 5.7 - patch 20090906. So it is sufficiently old to be used, is it not?

Aug 6 2021, 2:08 AM · Restricted Project
jasonmolenda requested review of D107625: Add a stack-memory-only style for Darwin process save-core.
Aug 6 2021, 1:38 AM · Restricted Project

Aug 5 2021

jasonmolenda added a comment to D107182: [LLDB][GUI] Refactor form drawing using subsurfaces.

I reverted this commit in 4d3d182c1dcb99ddcce7d077060d87111cb8dbfa to fix the build for now; I'm not sure where is_pad() is intended to come from.

Aug 5 2021, 7:29 PM · Restricted Project
jasonmolenda added a reverting change for rG2b89f40a411c: [LLDB][GUI] Refactor form drawing using subsurfaces: rG4d3d182c1dcb: Revert "[LLDB][GUI] Refactor form drawing using subsurfaces".
Aug 5 2021, 7:29 PM
jasonmolenda committed rG4d3d182c1dcb: Revert "[LLDB][GUI] Refactor form drawing using subsurfaces" (authored by jasonmolenda).
Revert "[LLDB][GUI] Refactor form drawing using subsurfaces"
Aug 5 2021, 7:29 PM
jasonmolenda added a reverting change for D107182: [LLDB][GUI] Refactor form drawing using subsurfaces: rG4d3d182c1dcb: Revert "[LLDB][GUI] Refactor form drawing using subsurfaces".
Aug 5 2021, 7:29 PM · Restricted Project
jasonmolenda added a comment to D107182: [LLDB][GUI] Refactor form drawing using subsurfaces.

Am I the only one seeing a compiler error with this patch?

if (is_pad(m_window))
Aug 5 2021, 7:26 PM · Restricted Project

Aug 4 2021

jasonmolenda added inline comments to D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.
Aug 4 2021, 11:48 PM · Restricted Project
jasonmolenda updated the diff for D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.

Ah, add one more comment that David suggested.

Aug 4 2021, 11:42 PM · Restricted Project
jasonmolenda updated the diff for D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.

Update patch to address David's suggestion that the bit masking & testing needed some comments to make it possible to follow. In the process of doing that, I noticed that MachODump.cpp's SymbolizerSymbolLookUp, where I cribbed the bit stuff from, doesn't handle an ADRP referring to a 4k block before $pc; it doesn't sign extend the page imm value correctly from the ADRP. I updated the test case to have a symbol 4k earlier than $pc so lldb has to compute this correctly to symbolicate the address, and added both an arm64 and arm64_32 yaml encoded copy of the binary.

Aug 4 2021, 11:36 PM · Restricted Project
jasonmolenda accepted D106984: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat.

Ah sorry I missed this patch, LGTM.

Aug 4 2021, 12:08 PM · Restricted Project
jasonmolenda accepted D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance.

LGTM, thanks for updating the docs too. I have a separate platform implementation ("lldb-platform") that I wrote but it's not in wide use outside the apple lldb team, I'm not going to worry about versioning the protocol or falling back to the old buggy behavior. I'll update my impl for https://reviews.llvm.org/D106985 and https://reviews.llvm.org/D106984 once these are landed.

Aug 4 2021, 12:07 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.

Thanks so much for taking the time to read the patch over and make suggestions David. I cribbed the bit masking / manip from MachODump.cpp's SymbolizerSymbolLookUp but you're right about it being better with at least a little bit of comments about what is going on there.

Aug 4 2021, 12:42 AM · Restricted Project

Aug 3 2021

jasonmolenda committed rG0d8cd4e2d5d4: [AArch64InstPrinter] Change printAddSubImm to comment imm value when shifted (authored by jasonmolenda).
[AArch64InstPrinter] Change printAddSubImm to comment imm value when shifted
Aug 3 2021, 2:29 AM
jasonmolenda closed D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted.
Aug 3 2021, 2:29 AM · Restricted Project
jasonmolenda added a comment to D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted.

Consider committing the test update separately from the code patch, so that the functional change has very few lines of update.

Wouldn't that mean a revision with lots of tests failing? I think a single large commit would be better. People can grep out changes in llvm/test if they're not interested in that.

I figured I would do commits locally and push them at the same time. I'm doing a final testsuite run right now and was hoping to land it if you think this might be a poor idea.

I wouldn't land them as two separate commits - even though the build bots might be fine, it'll mean that for at least one commit, LLVM as a whole is in a broken state, which can cause various issues e.g. when bisecting, or if a system does a commit-by-commit build and test cycle.

Aug 3 2021, 1:41 AM · Restricted Project
jasonmolenda added a comment to D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted.

Consider committing the test update separately from the code patch, so that the functional change has very few lines of update.

Wouldn't that mean a revision with lots of tests failing? I think a single large commit would be better. People can grep out changes in llvm/test if they're not interested in that.

Aug 3 2021, 1:24 AM · Restricted Project

Jul 31 2021

jasonmolenda added a comment to D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted.

An interesting side question as long as we're talking about this printer,

add x9, x0, #291, lsl #12 ; =1191936

once we have a shifted imm value, adding the value in base10 to the comment stream is maybe not the best choice. This could be printed as,

add x9, x0, #291, lsl #12 ; =0x123000
Jul 31 2021, 12:58 PM · Restricted Project
jasonmolenda added a comment to D107079: [lldb] Add an option for emitting LLDB logs as JSON.

Sorry for not commenting on this on earlier, I wanted to think about it a bit.

Jul 31 2021, 1:11 AM · Restricted Project
jasonmolenda requested review of D107213: Disassemble AArch64 pc-relative address calculations & symbolicate.
Jul 31 2021, 12:53 AM · Restricted Project

Jul 30 2021

jasonmolenda requested review of D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted.
Jul 30 2021, 2:48 PM · Restricted Project
jasonmolenda accepted D107179: [lldb] Fix remote macOS debugging on Apple Silicon.

Nice fix.

Jul 30 2021, 1:12 PM · Restricted Project

Jul 28 2021

jasonmolenda accepted D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Looks great! Thanks for doing this.

Jul 28 2021, 1:53 PM · Restricted Project
jasonmolenda accepted D106985: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB.

Thanks for fixing this, it's long overdue. For a long time I thought we'd need to operate in a compatibility mode to accept either set of constants, but I finally realized I was wrong and we should just align ourselves with the correct gdb behavior, but hadn't made the change myself yet.

Jul 28 2021, 1:51 PM · Restricted Project

Jul 27 2021

jasonmolenda added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Looks good! Maybe we should add a setting like target.file-cache-memory-reads-verify (a boolean) to enable/disable this check instead of keying off NDEBUG. We can turn it on in the testsuite, and we can optionally have people with release installs of lldb enable it if we ever suspect that it might be an issue. The settings are added with an entry in source/Target/TargetProperties.td and a getter/setter in TargetProperties.

Jul 27 2021, 10:42 AM · Restricted Project

Jul 24 2021

jasonmolenda added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.
Jul 24 2021, 1:30 AM · Restricted Project
jasonmolenda added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Sorry for the delay in replying, I needed to think & look at this a bit.

Jul 24 2021, 1:23 AM · Restricted Project

Jul 22 2021

jasonmolenda added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

I do like the debug-lldb check that the file cache read matches the live memory part. :)

Jul 22 2021, 3:54 PM · Restricted Project
jasonmolenda added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

I should add — I also don’t think this will fix the bug you’re working on.

Jul 22 2021, 3:35 PM · Restricted Project
jasonmolenda added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Hm there's no phab action which says "reject approach" :) the perf impact of forcing all reads to be out of memory would be dramatically bad for a remote system debug session, this can't be done. If there is a specific caller that must use live memory even for a section marked "read-only", it needs to use force_live_memory=true in its call to ReadMemory. This change would make app launch time for iOS apps etc probably take 30-60 seconds longer than they do right now.

Jul 22 2021, 3:31 PM · Restricted Project
jasonmolenda committed rGcdc6f8d72820: Read and write a LC_NOTE "addrable bits" for addressing mask (authored by jasonmolenda).
Read and write a LC_NOTE "addrable bits" for addressing mask
Jul 22 2021, 1:07 AM
jasonmolenda closed D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again.
Jul 22 2021, 1:07 AM · Restricted Project
jasonmolenda updated the diff for D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again.

One more bit I meant to do -- added output to "process status --verbose" to show the addressing masks in effect. There's no other way to check what lldb is currently using for ptrauth masks currently, to debug/confirm what lldb is using.

Jul 22 2021, 1:01 AM · Restricted Project
jasonmolenda updated the diff for D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again.

Update patch to address Jonas' suggestion of not duplicating the code to write the LC_NOTE load command & payloads (I was annoyed by this too but didn't deal with it in my first pass). Also add a test, although it only is really tested on an arm64e testsuite run where the compiler is doing PAC auth on return addresses.

Jul 22 2021, 12:38 AM · Restricted Project

Jul 20 2021

jasonmolenda requested review of D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again.
Jul 20 2021, 12:58 AM · Restricted Project
jasonmolenda committed rGb2e25572d2a7: Remove the DarwinLog functionality from debguserver (authored by jasonmolenda).
Remove the DarwinLog functionality from debguserver
Jul 20 2021, 12:37 AM
jasonmolenda closed D106324: Remove debugserver support for the DarwinLog StructuredData streaming service, lldb tests for it.
Jul 20 2021, 12:37 AM · Restricted Project

Jul 19 2021

jasonmolenda requested review of D106324: Remove debugserver support for the DarwinLog StructuredData streaming service, lldb tests for it.
Jul 19 2021, 5:09 PM · Restricted Project

Jun 20 2021

jasonmolenda committed rGaf913881e33c: Try to unbreak the windows CI (authored by jasonmolenda).
Try to unbreak the windows CI
Jun 20 2021, 1:14 PM
jasonmolenda committed rG9ea6dd5cfac0: Add a corefile style option to process save-core; skinny corefiles (authored by jasonmolenda).
Add a corefile style option to process save-core; skinny corefiles
Jun 20 2021, 12:27 PM
jasonmolenda closed D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.
Jun 20 2021, 12:27 PM · Restricted Project
jasonmolenda updated the diff for D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Update patch to:

Jun 20 2021, 2:17 AM · Restricted Project

May 20 2021

jasonmolenda accepted D102833: [debugserver]Add platform cache support to improve performance.Under BigSur 11.3 this function causes a performance loss of 0.68s per execution..

LGTM, thanks for doing this.

May 20 2021, 10:22 AM · Restricted Project

May 13 2021

jasonmolenda committed rGafee09751d2d: [NFC] Add GetInferiorAddrSize method, unify code to compute (authored by jasonmolenda).
[NFC] Add GetInferiorAddrSize method, unify code to compute
May 13 2021, 12:48 AM

May 12 2021

jasonmolenda committed rG0c443e92d3b9: Add some warnings when debugserver is running in translation (authored by jasonmolenda).
Add some warnings when debugserver is running in translation
May 12 2021, 10:18 PM

May 11 2021

jasonmolenda accepted D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

LGTM!

May 11 2021, 1:28 AM · Restricted Project

May 3 2021

jasonmolenda accepted D101655: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version.

Yep looks good.

May 3 2021, 3:02 PM · Restricted Project

Apr 29 2021

jasonmolenda accepted D101596: [debugserver] Use add_lldb_library.

LGTM.

Apr 29 2021, 10:05 PM · Restricted Project

Apr 26 2021

jasonmolenda added a comment to D101153: [lldb][NFC] Specify guidelines for API tests.

Nice addition, these are great guidelines. I'd do a s/just// pass over the text, there's some extraneous "just"s that could go. This is a very bad habit of my own lately, I re-read emails I write, and try to remove "justs" that snuck into the text I typed before I send. I think my keyboard driver might be responsible for inserting them into sentences.

Apr 26 2021, 11:32 PM · Restricted Project

Apr 24 2021

jasonmolenda committed rG6fca18953251: Simplify the breakpoint setting in DynamicLoaderMacOS::SetNotificationBreakpoint (authored by jasonmolenda).
Simplify the breakpoint setting in DynamicLoaderMacOS::SetNotificationBreakpoint
Apr 24 2021, 2:05 PM
jasonmolenda closed D100931: Set binaries-loaded/unloaded breakpoint on a name, not an address on macOS.
Apr 24 2021, 2:05 PM · Restricted Project