Page MenuHomePhabricator

jasonmolenda (Jason Molenda)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2014, 12:05 PM (332 w, 6 d)

Recent Activity

Fri, Jan 15

jasonmolenda committed rG10ac9b29a4ca: Skip 'g' packet tests when running on darwin; debugserver doesn't impl (authored by jasonmolenda).
Skip 'g' packet tests when running on darwin; debugserver doesn't impl
Fri, Jan 15, 1:58 PM
jasonmolenda closed D94754: skip g packet tests on darwin systems.
Fri, Jan 15, 1:58 PM · Restricted Project
jasonmolenda updated the diff for D94754: skip g packet tests on darwin systems.

Ah, Pavel's change was correct to run the first test.

Fri, Jan 15, 2:14 AM · Restricted Project
jasonmolenda added a comment to D94754: skip g packet tests on darwin systems.

Ah, part of my confusion is mine - the alignas() requires c++11 and I wasn't building with that mode when I did it by hand.

Fri, Jan 15, 1:25 AM · Restricted Project
jasonmolenda requested review of D94754: skip g packet tests on darwin systems.
Fri, Jan 15, 1:22 AM · Restricted Project

Wed, Jan 13

jasonmolenda committed rG885eae9d85de: Add func call so we don't instruction-step into the builtin_trap (authored by jasonmolenda).
Add func call so we don't instruction-step into the builtin_trap
Wed, Jan 13, 11:42 PM

Mon, Jan 11

jasonmolenda committed rGedde2eb1d209: Add unconditional logging to debugserver for launch/attach processes (authored by jasonmolenda).
Add unconditional logging to debugserver for launch/attach processes
Mon, Jan 11, 10:26 PM
jasonmolenda closed D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching.
Mon, Jan 11, 10:26 PM · Restricted Project
jasonmolenda added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 9:35 PM · Restricted Project
jasonmolenda added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Mon, Jan 11, 9:31 PM · Restricted Project

Sat, Jan 9

jasonmolenda requested review of D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching.
Sat, Jan 9, 2:11 AM · Restricted Project

Fri, Jan 8

jasonmolenda accepted D94320: [debugserver] Various plist changes.

Thanks Jonas, LGTM.

Fri, Jan 8, 1:07 PM · Restricted Project

Dec 9 2020

jasonmolenda committed rG2cedc44a9233: Ignore DBGArchitecture from dsymForUUID's plist (authored by jasonmolenda).
Ignore DBGArchitecture from dsymForUUID's plist
Dec 9 2020, 2:20 PM
jasonmolenda closed D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs .
Dec 9 2020, 2:20 PM · Restricted Project

Dec 4 2020

jasonmolenda accepted D92712: [debugserver] Honor the cpu sub type if specified.

Ah very cool, I didn't realize we had a new posix_spawn attr setter that could set the cpu subtype.

Dec 4 2020, 7:50 PM · Restricted Project
jasonmolenda added a comment to D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs .

Ah, I forgot to add. I added a test by having an existing corefile test (which loads an x86_64 binary) have a plist that claims it is i386. It's close to the same thing, and results in the same kind of erroring if lldb trusts the arch from the plist.

Dec 4 2020, 2:19 PM · Restricted Project
jasonmolenda requested review of D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs .
Dec 4 2020, 2:17 PM · Restricted Project

Dec 3 2020

jasonmolenda accepted D92609: [lldb] Use the cpu sub type defines for llvm::MachO.

Nice cleanup.

Dec 3 2020, 2:38 PM
jasonmolenda accepted D92603: [lldb] Recognize MachO cpu sub-type 2 as arm64.

Bien.

Dec 3 2020, 1:25 PM · Restricted Project
jasonmolenda added inline comments to D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform.
Dec 3 2020, 1:25 AM · Restricted Project

Dec 1 2020

jasonmolenda added a comment to D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform.

Looks good overall, nice test.

Dec 1 2020, 8:22 PM · Restricted Project

Nov 12 2020

jasonmolenda committed rG92b036dea24b: debugserver should advance pc past builtin_debugtrap insn (authored by jasonmolenda).
debugserver should advance pc past builtin_debugtrap insn
Nov 12 2020, 11:31 PM
jasonmolenda closed D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily.
Nov 12 2020, 11:31 PM · Restricted Project
jasonmolenda updated the diff for D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily.

Minor update to the patch to move the test case under API/macosx for now, because it depends on debugserver behavior. Add comments to note that we're all in agreement this should really be handled up in lldb - but that's more a TODO for a future day, for now.

Nov 12 2020, 11:21 PM · Restricted Project

Nov 11 2020

jasonmolenda added a comment to D91130: [crashlog] Implement parser for JSON encoded crashlogs.

I guess the register context part of the crashlog.json would be the most architecture-dependent, but I bet crashlog.json doesn't use any of that when printing the backtrace -- it only uses the stack trace's pc values. So you could have a "x86_64" crashlog.json, build an arm64e userland program, substitute in the slide-adjusted values of a few functions and the UUID and it would load & symbolicate in lldb.

Nov 11 2020, 2:39 PM · Restricted Project
jasonmolenda added a comment to D91130: [crashlog] Implement parser for JSON encoded crashlogs.
Nov 11 2020, 2:34 PM · Restricted Project
jasonmolenda added a comment to D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily.

Yeah, I don't know where it's best to centralize the logic of (1) recognize a builtin_debugtrap instruction, and (2) set the pc so we step past it, know how to step past it when the user asks to resume control. debugserver (and lldb-server I'm sure) are already lying a *little* with a normal x86 user breakpoint - when you execute 0xcc at addr 0x100, the stop pc is 0x101 and someone is rolling that back to 0x100 to report the breakpoint hit (debugserver does this, I'm sure lldb-server does the same). So we're just adding more lies into the remote stub.

Nov 11 2020, 2:31 PM · Restricted Project
jasonmolenda added a comment to D91130: [crashlog] Implement parser for JSON encoded crashlogs.

You could also make a fakey dsymForUUID script like we do in some other corefile tests. Compile a C file with foo(), bar(), baz(), substitute the addresses of those symbols from the binary into the crashlog.json, substitute the UUID of the compiled program in the crashlog.json, then the fakey-dsymForUUID finds the binary, lldb loads it at the binary at the correct offset. It's a lot of futzing around, but it would be possible.

Nov 11 2020, 2:12 PM · Restricted Project
jasonmolenda added a comment to D91221: [MachO] Allow the LC_IDENT load command.

I discussed this with KevinE in the past and he was adamant that he didn't want LC_IDENT being used for this. I don't have strong feelings. I think it was an old load command used for something else altogether decades ago and it started getting used in kernel corefiles and he wasn't thrilled with that. There is a Mach-O LC_NOTE load command that allows for the kernel version string to be stored in the kernel file ("kern ver str") but it hasn't been adopted by darwin kernel dumpers yet.

Nov 11 2020, 2:03 PM · Restricted Project
jasonmolenda requested review of D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily.
Nov 11 2020, 12:05 AM · Restricted Project

Oct 29 2020

jasonmolenda updated the diff for D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Update to address previous review comments. (1) Update SBMemoryRegionInfo API to provide access to the dirty page information. (2) Update the 'memory region' command output to print the dirty page list. (3) Update the 'process save-core' command to take a --style option with accepts an enum for the type of corefile. (4) Update 'process save-core' text to explain the limitations of a modified-memory-only corefile. (5) Add a API/functionalities/gdb_remote_client test with a stub that returns the region infos with these new fields, and tests the SBMemoryRegionInfo object filled in on the debugger side. I think that's everything.

Oct 29 2020, 12:38 AM · Restricted Project

Oct 21 2020

jasonmolenda added a comment to D89925: [lldb] Fix a regression introduced by D75730.

(*cough* "requesting 256 instructions", wrote too quickly, or rather I am speaking in gdb RSP and don't always prefix my base16 numbers).

Oct 21 2020, 9:24 PM · Restricted Project
jasonmolenda added a comment to D89925: [lldb] Fix a regression introduced by D75730.

So in this patch you're setting the limit to be the size of the range (for someone who did 'disass -s 0x100 -e 0x200' they would be requesting 100 instructions) but the disassembly returned would be limited by the byte range requested, so this works OK. The asm(nop) is to guarantee that sum() has at least one instruction? There's no documentation for the Disassembler ctors where we might mention that the use case is either (1) an AddressRange, or (2) a start address and instruction count, but maybe there should be?

Oct 21 2020, 9:18 PM · Restricted Project

Oct 20 2020

jasonmolenda committed rGc932266c8d04: Add a nul byte to packet str before logging, increase default size. (authored by jasonmolenda).
Add a nul byte to packet str before logging, increase default size.
Oct 20 2020, 1:44 AM

Oct 16 2020

jasonmolenda committed rG32021eeff0cd: Un-indent the section on 'Writing Target Stop-Hooks in Python' (authored by jasonmolenda).
Un-indent the section on 'Writing Target Stop-Hooks in Python'
Oct 16 2020, 11:24 PM

Oct 15 2020

jasonmolenda committed rGaf5504edd681: Increase timeout to find a dSYM in macos DownloadObjectAndSymbolFile (authored by jasonmolenda).
Increase timeout to find a dSYM in macos DownloadObjectAndSymbolFile
Oct 15 2020, 1:00 AM

Oct 14 2020

jasonmolenda committed rGb19856881c16: Fix typeo in attach failed error message. (authored by jasonmolenda).
Fix typeo in attach failed error message.
Oct 14 2020, 11:31 PM

Oct 13 2020

jasonmolenda committed rG7d67c06391bb: Remove unused build configurations from debugserver xcode project (authored by jasonmolenda).
Remove unused build configurations from debugserver xcode project
Oct 13 2020, 4:41 PM
jasonmolenda committed rGe763709d14e5: Add a new launch flag option for watchos, WatchComplicationLaunch. (authored by jasonmolenda).
Add a new launch flag option for watchos, WatchComplicationLaunch.
Oct 13 2020, 4:28 PM
jasonmolenda added a comment to D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb.

Just to confirm one quick detail (I couldn't remember for sure and had to check) - if we strtoul will stop parsing when it finds a character outside the range of the specified base. e.g. calling strtoul("0x100", nullptr, 10) will yield 0; strtoul("10f", nullptr, 10) will yield 10.

Oct 13 2020, 2:59 PM · Restricted Project
jasonmolenda added a comment to D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb.

And I'm saying lldb-server and not that and debug-server because if I'm honest, I don't really know what the latter is. I assume this applies to both though.

debugserver is an apple-only implementation of the remote stub. However, I think that may be a red herring, because in lldb land the vFile packets are handled by lldb-server platform, which is used even on apple platforms (IIUC).

Oct 13 2020, 11:54 AM · Restricted Project
jasonmolenda added a comment to D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb.

Thanks for adding the clarifying text, I wrote the doc based on the existing lldb-server implementation of these packets while I was writing a separate implementation of the platform packets, so I hadn't seen the gdb docs.

Oct 13 2020, 12:03 AM · Restricted Project

Oct 8 2020

jasonmolenda added a comment to D82863: [LLDB] Add support to resize SVE registers at run-time.

(about g packets...) they cause so many problems if there is a mis-coordination between the remote stub and lldb, I never want to stop the remote stub from providing those offsets.

I am not sure how to interpret this in the context of SVE registers. The stub cannot send the offsets of those, as their size/offset might change depending on their configuration.

Oct 8 2020, 3:24 PM
jasonmolenda added a comment to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Thanks for the feedback Pavel. Good point on piping the dirty pages list through the memory region command and adding tests for that. And good thoughts on different memory types that could be included in the corefile. I think we may revisit how the 'process save-core' command arguments work as we add more formats. We could do some pretty cool stuff here.

Oct 8 2020, 12:52 PM · Restricted Project

Oct 7 2020

jasonmolenda added a comment to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Yeah, I'm not opposed to mutually exclusive options to process save-core to request a specific style of coredump to be created, whether it's a --core-style enum or a series of flags isn't important to me. Right now I only intend to add the two that are possible - a full coredump or a modified-memory (dirty memory) coredump, on macOS. Whether it's passed as an enum or bitflag I don't have a preference, although a bitflag makes it sound like there could be multiple of them selected, when that's not what I'd be envisioning here. (if we were doing a series of flags for the lldb API, it would make more sense if we had different types of memory that could be coredumped and you could set the flags for what you want included. stack, heap, shared memory, binary images, etc.)

Oct 7 2020, 8:29 PM · Restricted Project
jasonmolenda added a comment to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

I was thinking about the UI of this some more today.

Oct 7 2020, 4:08 PM · Restricted Project

Oct 6 2020

jasonmolenda updated subscribers of D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Thinking about process save-core and how it will default to a skinny corefile on macOS but a full corefile elsewhere, I'd like to surface some notification to the user about the type of corefile that was created to the user. Maybe add an PluginManager::SavedCoreType {eSavedCoreFull, eSavedCoreDirtyOnly, eSavedCoreDirtyPlusExecutingIMages}, have PluginManager::SaveCore return that enum value so that the "process save-core" user command can print text about the type of corefile that was saved. For a dirty corefile on macos, it could say "Modified-memory-only corefile has been written. This corefile will not be portable between systems, or usable as software updates are applied; --full-corefile can create a corefile appropriate for sharing/archiving." or something.

Oct 6 2020, 2:16 PM · Restricted Project
jasonmolenda added a comment to D82863: [LLDB] Add support to resize SVE registers at run-time.

Hey all, got distracted while reading the patch and jotted a few notes, but I know that's not as much what Pavel wanted to discuss. We already have some target specific goop in these ProcessGDBRemote type classes for registers and such, this doesn't cause my great pain to see added.

Oct 6 2020, 1:33 AM

Oct 2 2020

jasonmolenda added inline comments to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.
Oct 2 2020, 11:21 PM · Restricted Project
jasonmolenda added inline comments to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.
Oct 2 2020, 11:08 PM · Restricted Project
jasonmolenda updated the diff for D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

This patch update incorporates most of Greg's suggestions. Most importantly, I isolated all of the loading of the binaries specified in the corefile down into ObjectFileMachO so I didn't have to add so much special case API to the ObjectFile base API.

Oct 2 2020, 11:05 PM · Restricted Project

Oct 1 2020

jasonmolenda committed rGa1e97923a025: Have kernel binary scanner load dSYMs as binary+dSYM if best thing found (authored by jasonmolenda).
Have kernel binary scanner load dSYMs as binary+dSYM if best thing found
Oct 1 2020, 6:56 PM
jasonmolenda closed D88632: A handful of fixes to lldb's "scan the local filesystem for kexts & kernels" feature.
Oct 1 2020, 6:55 PM · Restricted Project
jasonmolenda updated the diff for D88632: A handful of fixes to lldb's "scan the local filesystem for kexts & kernels" feature.

Incorporate Jonas' suggestions, including changing the NULLs to nullptr's in the section of code I was changing right now. Also found an unintentional shadowing of module_sp in GetSharedModuleKernel (that was present before my patchset) and fixed that; it works either way, but it's not correct.

Oct 1 2020, 6:43 PM · Restricted Project

Sep 30 2020

jasonmolenda requested review of D88632: A handful of fixes to lldb's "scan the local filesystem for kexts & kernels" feature.
Sep 30 2020, 8:46 PM · Restricted Project

Sep 28 2020

jasonmolenda added a comment to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

The other thing to think about is using minidump files instead of mach-o core files. We have them in very good shape and they already have a built in notion of "all image infos". Many more things in there too. Let me know if you want to know more, but I'm not holding my breath! hhaha

Sep 28 2020, 4:32 PM · Restricted Project
jasonmolenda added a comment to D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Thanks for the suggestions Greg, solid ideas. Let me rework this a bit.

Sep 28 2020, 3:20 PM · Restricted Project
jasonmolenda committed rG6e54918db7f4: Once we've found a firmware binary and loaded it, don't search more (authored by jasonmolenda).
Once we've found a firmware binary and loaded it, don't search more
Sep 28 2020, 12:51 PM

Sep 27 2020

jasonmolenda requested review of D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.
Sep 27 2020, 6:35 PM · Restricted Project

Sep 25 2020

jasonmolenda committed rG1bec6eb3f5cb: Add support for firmware/standalone LC_NOTE "main bin spec" corefiles (authored by jasonmolenda).
Add support for firmware/standalone LC_NOTE "main bin spec" corefiles
Sep 25 2020, 3:19 PM
jasonmolenda closed D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles.
Sep 25 2020, 3:19 PM · Restricted Project
jasonmolenda added a comment to D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles.

Thanks for the feedback!

Sep 25 2020, 2:07 PM · Restricted Project
jasonmolenda requested review of D88282: Add support for a "main bin spec" LC_NOTE for standalone/firmware corefile binaries in MachO corefiles.
Sep 25 2020, 1:21 AM · Restricted Project

Sep 2 2020

jasonmolenda accepted D86336: [debugserver] Fix that debugserver's stop reply packets always return signal code 0.

Ah sorry lost track of this one; that looks correct, thanks for the fix.

Sep 2 2020, 1:45 AM · Restricted Project

Aug 29 2020

jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

Hahaha I remember looking at this constructor and expecting to find an uninitialized ivar, but it was initialized correctly and I went to look for another place where the bug might be. I think I see why there's some confusion -- this change landed Thrusday:

Aug 29 2020, 1:03 PM · Restricted Project
jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

Ah, so we've still got a bug in x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite somehow for abort(). This method takes an UnwindPlan from eh_frame instructions (which says it is not a trap handler - correct), and adds some epilogue unwind rows at the end if needed and sets a couple of flags. I'm not sure how the trap handler lazybool is getting set to True in the process of this conversion. :/ I'll read through this method more closely Monday and try to spot how that is happening.

Aug 29 2020, 11:03 AM · Restricted Project

Aug 28 2020

jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

Hi, could you try

Aug 28 2020, 8:57 PM · Restricted Project
jasonmolenda added a comment to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
In D86667#2243781, @mib wrote:

Do people really call command-line shells interpreters? I would have thought --shell would be a better name. lldb already has its own command interpreter which is orthogonal to the shells, so it seems confusing to use the same term for both.

I think platform shell --shell sounds/looks repetitive so I opted for -i|--interpreter instead, as in Command-line Interpreter.

Yes, it is repetitive. OTOH:

  • the unix commands that take a shell as an argument (e.g., su, sudo), do so via a --shell/-s argument
  • we have a memory load --load command

Overall, I can understand where you're coming from, but I think I'd go with --shell nonetheless...

Aug 28 2020, 12:36 AM · Restricted Project
jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

Hi, thanks so much for showing all the unwind plans, sorry for dropping off the thread for a day.

Aug 28 2020, 12:27 AM · Restricted Project

Aug 25 2020

jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

Minor followup on the 'image show-unwind' output -- I just landed a patch to print when a function or unwindplan are marked as being a trap handler.

Aug 25 2020, 9:18 PM · Restricted Project
jasonmolenda committed rGb1e856d3a901: Ah, one test too many updated. This one should be unmodified. (authored by jasonmolenda).
Ah, one test too many updated. This one should be unmodified.
Aug 25 2020, 9:04 PM
jasonmolenda committed rG99d187a003c9: Update UnwindPlan dump to list if it is a trap handler func; also Command (authored by jasonmolenda).
Update UnwindPlan dump to list if it is a trap handler func; also Command
Aug 25 2020, 8:54 PM
jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

separate from the fact that UnwindPlan::Dump does not print m_plan_is_for_signal_trap for an UnwindPlan, what we need to see from a real trap handler -- in lldb's terminology -- is that we have restore rules for all of the registers.

Aug 25 2020, 5:52 PM · Restricted Project
jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

If I understand correctly, in

Aug 25 2020, 5:48 PM · Restricted Project
jasonmolenda added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

Hi, I'll review this problem / suggested patch in a bit but I think it might be helpful to outline what the intention of all this is. Let's say we have a stack of

Aug 25 2020, 3:45 PM · Restricted Project

Aug 24 2020

jasonmolenda accepted D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID.

Looks good!

Aug 24 2020, 1:43 PM · Restricted Project
jasonmolenda accepted D86211: [lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues.

LGTM, that call to dispatch_get_global_queue QOS_CLASS_UNSPECIFIED does not look valid.

Aug 24 2020, 12:10 PM · Restricted Project

Aug 19 2020

jasonmolenda accepted D86237: [lldb] Code sign binaries with entitlements.

LGTM

Aug 19 2020, 11:51 AM · Restricted Project
jasonmolenda accepted D85539: [lldb] Extend builder to pass the TRIPLE spec to Make.

This looks good to me, getting any logic out of the Makefile templates that we can, that's a good improvement for maintainability.

Aug 19 2020, 12:51 AM · Restricted Project

Aug 15 2020

jasonmolenda added a comment to D85284: [lldb] Remote disk file/directory completion for platform commands.
  1. Removed the unnecessary print line in GDBRemoteCommunicationServerPlatform.cpp;
  2. Updated the packet doc;
  3. Refactored the for-loop at line 359-364 in GDBRemoteCommunicationServerPlatform.cpp;
  4. Refactored the server-side test with str.encode().hex().

If we need to response for qPathComplete with empty match result. I think we could provide a char like R or what as the response. The match result is encoded into hex-bytes, so it might be easy to resolve the error symbol from the result IMHO.

What if the response is "matches:<ASCIIHEX>[,<ASCIIHEX>]" and if there are no matches, just "matches:"? We don't want to send an empty string because that means "packet not known" in the remote serial protocol.

"matches:" takes up 8 chars, maybe we can just use a 'M' as vFile:size uses 'F', so it may look like: "M<ASCIIHEX>[,<ASCIIHEX>]". What do you think?

Aug 15 2020, 2:43 PM · Restricted Project

Aug 14 2020

jasonmolenda added a comment to D85284: [lldb] Remote disk file/directory completion for platform commands.
  1. Removed the unnecessary print line in GDBRemoteCommunicationServerPlatform.cpp;
  2. Updated the packet doc;
  3. Refactored the for-loop at line 359-364 in GDBRemoteCommunicationServerPlatform.cpp;
  4. Refactored the server-side test with str.encode().hex().

If we need to response for qPathComplete with empty match result. I think we could provide a char like R or what as the response. The match result is encoded into hex-bytes, so it might be easy to resolve the error symbol from the result IMHO.

Aug 14 2020, 10:38 PM · Restricted Project

Aug 10 2020

jasonmolenda added a comment to D85284: [lldb] Remote disk file/directory completion for platform commands.

Nice set of changes, and you're right it should be a lower-case "q" packet, not an upper-case "Q" packet like I suggested, it's just querying information from the remote side.

Aug 10 2020, 11:53 PM · Restricted Project
jasonmolenda added a comment to D85284: [lldb] Remote disk file/directory completion for platform commands.

This is mostly fine. You need to escape the completed filenames you send back. You should have a test case where multiple matches are returned, like "a" matches "abc1" and "abc2".

Aug 10 2020, 2:56 PM · Restricted Project

Aug 6 2020

jasonmolenda accepted D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary.

LGTM, it's hard to keep all the supported behaviors in my head but I think this is right.

Aug 6 2020, 1:15 PM · Restricted Project
jasonmolenda added inline comments to D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary.
Aug 6 2020, 1:13 PM · Restricted Project

Aug 5 2020

jasonmolenda updated the diff for D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

Update to std::unique_ptr -- thanks for the reminder!

Aug 5 2020, 10:52 PM · Restricted Project
jasonmolenda updated the diff for D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.

Made the change in Xcode and the indentation was off.

Aug 5 2020, 9:49 PM · Restricted Project
jasonmolenda requested review of D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp.
Aug 5 2020, 9:44 PM · Restricted Project

Jul 30 2020

jasonmolenda committed rGabf546dd4f83: debguserver's type sniffer to only treat .app things that end in .app (authored by jasonmolenda).
debguserver's type sniffer to only treat .app things that end in .app
Jul 30 2020, 9:16 PM

Jul 21 2020

jasonmolenda added a comment to D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes.

With this patch, debugging a translated app will only work when we invoke debugserver with --fd for its communication back to lldb. e.g. running 'debugserver localhost:2000 --attach=translated-app' will pass -fd=-1 as a command line argument to /Library/Apple/usr/libexec/oah/debugserver. Doing this properly would involve passing the same hostspec:portnum that debugserver received in this case -- but could we at least error out in DNBProcessAttach if communcation_fd==-1 so it's clear that this is not yet a supported workflow?

Jul 21 2020, 2:26 PM

Jul 15 2020

jasonmolenda accepted D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache.

The rewrite of the ObjectFileMachO parts is very nice. LGTM.

Jul 15 2020, 6:01 PM · Restricted Project, Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG6dcf3e1184f7: Upstream two performance monitor collectors to MachTask (#1343) (authored by jasonmolenda).
Upstream two performance monitor collectors to MachTask (#1343)
Jul 14 2020, 4:54 PM
jasonmolenda committed rGb6311ca0fbbd: Quote error string from qLaunchSuccess (authored by jasonmolenda).
Quote error string from qLaunchSuccess
Jul 14 2020, 4:50 PM
jasonmolenda committed rG88b544f2ce6e: Add a new lockdownd plist for launching posix processes (authored by jasonmolenda).
Add a new lockdownd plist for launching posix processes
Jul 14 2020, 4:49 PM
jasonmolenda committed rGee76034d2238: Log the NSError str and object description on app launch fail (authored by jasonmolenda).
Log the NSError str and object description on app launch fail
Jul 14 2020, 4:49 PM
GitHub <noreply@github.com> committed rGf1a1c4b8c0ca: Remove attach-failed-due-to-SIP checks which were not working (#1092) (authored by jasonmolenda).
Remove attach-failed-due-to-SIP checks which were not working (#1092)
Jul 14 2020, 4:43 PM
GitHub <noreply@github.com> committed rG1be5d83869c5: Bug where insn-based unwind plans on arm64 could be wrong (#1082) (authored by jasonmolenda).
Bug where insn-based unwind plans on arm64 could be wrong (#1082)
Jul 14 2020, 4:43 PM
GitHub <noreply@github.com> committed rG79bb1dce92f9: Remove the old SecTaskAccess entry from debugserver's plist (#1041) (authored by jasonmolenda).
Remove the old SecTaskAccess entry from debugserver's plist (#1041)
Jul 14 2020, 4:40 PM
GitHub <noreply@github.com> committed rG13508282d930: Don't fail step out if remote server doesn't implement qMemoryRegionInfo (#1040) (authored by jasonmolenda).
Don't fail step out if remote server doesn't implement qMemoryRegionInfo (#1040)
Jul 14 2020, 4:40 PM
GitHub <noreply@github.com> committed rG645573a1ea5c: Re-land Unwind past an interrupt handler correctly on arm or at pc==0 (#833) (authored by jasonmolenda).
Re-land Unwind past an interrupt handler correctly on arm or at pc==0 (#833)
Jul 14 2020, 4:29 PM