This is an archive of the discontinued LLVM Phabricator instance.

[Debug-Info] make createAndAddDIE have dwarf::Tag type parameter - NFC
ClosedPublic

Authored by shchenz on May 10 2021, 6:42 PM.

Details

Summary

This is a suggestion from @dblaikie in the code review of D100630.

Change the Tag parameter type to dwarf::Tag for function createAndAddDIE

Diff Detail

Event Timeline

shchenz created this revision.May 10 2021, 6:42 PM
shchenz requested review of this revision.May 10 2021, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2021, 6:42 PM
dblaikie accepted this revision.May 10 2021, 7:41 PM

Looks good, thanks!

llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
279–280

You can remove this now.

2047

You can remove this now

This revision is now accepted and ready to land.May 10 2021, 7:41 PM
shchenz marked 2 inline comments as done.May 13 2021, 6:06 PM