Page MenuHomePhabricator

echristo (Eric Christopher)
User

Projects

User Details

User Since
Oct 15 2012, 2:12 PM (407 w, 3 d)

Recent Activity

Yesterday

echristo updated subscribers of D84250: [InstSimplify] ExpandBinOp should fold an expression only when it's safe.

I think that we should revert the original patch for now since we have a
known miscompile and a chain of fixes are required to fix it.

Thu, Aug 6, 4:35 PM · Restricted Project
echristo updated subscribers of D84825: [ELF] Change tombstone values to (.debug_ranges/.debug_loc) 1 and (other .debug_*) 0.

*thumbs up on ok for release*

Thu, Aug 6, 3:33 PM · Restricted Project
echristo accepted D84825: [ELF] Change tombstone values to (.debug_ranges/.debug_loc) 1 and (other .debug_*) 0.

This looks good to me. Thanks for seeing this through Ray!

Thu, Aug 6, 3:21 PM · Restricted Project

Wed, Aug 5

echristo added a comment to D84825: [ELF] Change tombstone values to (.debug_ranges/.debug_loc) 1 and (other .debug_*) 0.

At which point we are at an impasse and the default behavior applies. Please revert completely back to the original behavior immediately.

Thanks.

With respect I think the "request for changes" blocked the change and I am not inclined to agree we would otherwise be at an impasse without the "request for changes".
I would likely get an "Accept Revision" or a just textual "LGTM", even if there is a conditional request that ".debug_* should use 0 as well, like GNU ld". I have mentioned that my position has been weakened. (I made the reply after 5 days, not my usual style as you can tell, because the related threads have caused so much stress/pain to me. I would otherwise not be able to focus on real work. In some sense, I feel that I am fighting a really meaningless battle, even the original proposers have not said something on this patch - Why do I still care about the resolution so much? The all things make me feel I can't really make a fair decision on this patch. I regret that I was involved in the original implementation. I would definitely better if I were just a reviewer)

I sent the patch instead of reverting 3 or 4 intertwined dependent patches because I think reverting will just make the situation more confusing. I have experienced the review processes of all relevant patches and have read all the context,
so I very responsibly state again that "a simple revert of 3 or 4 dependent patches will just make the situation more confusing".

I will very appreciate feedback from other people, not my colleague, especially LLD contributors such as @psmith @grimar @jhenderson, whether we really need a flag in this patch or can we simply defer it to another thread.

Wed, Aug 5, 11:38 AM · Restricted Project

Tue, Aug 4

echristo added a comment to D84825: [ELF] Change tombstone values to (.debug_ranges/.debug_loc) 1 and (other .debug_*) 0.

Please implement a clear flag for

  • BFD semantics
  • New (-1/-2) semantics

And default to the BFD semantics for now.

The change in semantics is not ready to ship by default - there are lots of DWARF consumers out there and lots of people don't update them in lock-step with their compiler.

I don't know what the request is. The patch implemented:

  • .debug_ranges & .debug_loc: -2
  • .debug_*: 0 (GNU ld semantics)

If you meant full BFD semantics:

  • .debug_ranges: 1
  • .debug_*: 0

Yes, that's what I meant. (though probably applying the debug_ranges workaround to debug_loc as well would be suitable but not necessary, I think)

Did you mean

- * .debug_ranges & .debug_loc: -2
+ * .debug_ranges & .debug_loc: 1

?
I think this has gone too far a step. We really need more evidence that 1 can make DWARF consumers happier.

That's fairly easy - 0, 0 terminates a location list the same way it terminates a range list - llvm-dwarfdump, for instance, then tries to parse the following expression as the start of a new location list and errors. binutils objdump only dumps location lists that are referenced from debug_info, printint out "holes" when the location list terminates early.

eg:

$ g++-tot loc.cpp -g -ffunction-sections -Wl,-gc-sections -O3 -fuse-ld=bfd
$ llvm-dwarfdump-tot a.out
.debug_loc contents:
0x00000000: 
            (0x0040102000040402, 0x0040102000000000): 
            (0x10209f3300020000, 0x1023000000000040): <decoding error> 00 00 00 00 02 00 37 9f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02 04 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02 00 33 9f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
            (0x000000009f370002, 0x0000000000000000): error: unexpected end of data at offset 0x78 while reading [0x76, 0x7e)
$ objdump -g a.out | grep -A50 debug_loc
objdump: Warning: Hole and overlap detection requires adjacent view lists and loclists.
objdump: Warning: Contents of the .debug_loc section (loaded from a.out):
There are 40 unused bytes at the end of section .debug_loc

    Offset   Begin            End              Expression

    00000000 v000000000000002 v000000000000004 location view pair
    00000002 v000000000000004 v000000000000000 location view pair

    00000004 v000000000000002 v000000000000004 views at 00000000 for:
             0000000000401020 0000000000401020 (DW_OP_lit3; DW_OP_stack_value)
    00000018 v000000000000004 v000000000000000 views at 00000002 for:
             0000000000401020 0000000000401023 (DW_OP_lit7; DW_OP_stack_value)
    0000002c <End of list>

    0000003c v000000000000002 v000000000000004 location view pair
    0000003e v000000000000004 v000000000000000 location view pair

    00000040 <End of list>

(have to use GCC to produce the input here, since Clang's current use of base address specifiers in debug_loc doesn't trip over the issue - that doesn't diminish the problem, though)

Can you share loc.cpp?

Oh, right, sorry:

__attribute__((noinline)) void f1() { }
void f2() {
  int i = 3;
  f1();
  i = 7;
  f1();
}
int main() {
  int i = 3;
  f1();
  i = 7;
  f1();
}

That's fairly easy - 0, 0 terminates a location list the same way it terminates a range list - llvm-dwarfdump, for instance, then tries to parse the following expression as the start of a new location list and errors. binutils objdump only dumps location lists that are referenced from debug_info, printint out "holes" when the location list terminates early.

So how is BFD's choice for .debug_loc (1) better than -2? Additional warning objdump: Warning: Hole and overlap detection requires adjacent view lists and loclists. objdump: Warning: There are 40 unused bytes at the end of section .debug_loc and unneeded fffffffffffffffe ranges cannot be filtered out?

Tue, Aug 4, 11:12 PM · Restricted Project
echristo added a comment to D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp.

It's a pretty nasty revert in our downstream tree where we have prototyped future ISAs. So I'd like a little time to take a look.

@nickdesaulniers what cpu and fetaures are on your command lines. getImpliedDisabledFeatures should only be called if some feature is explicitly being disabled.

Likely, as the kernel is very explicit to disable the use of all FP extensions, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/Makefile#n57. Maybe we could just set fewer flags, but there's still probably room for improvement here, too.

Tue, Aug 4, 4:26 PM · Restricted Project, Restricted Project
echristo updated subscribers of D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp.

Ow. Can revert and reapply after we fix the caching problem perhaps?

Tue, Aug 4, 3:49 PM · Restricted Project, Restricted Project
echristo updated subscribers of D85231: Protect against filenames with no extension at all..

Could maybe add an assert along with the patch as well as an assert only
test?

Tue, Aug 4, 2:00 PM · Restricted Project

Tue, Jul 28

echristo added a comment to D84793: [X86] Add assembler support for {disp8} and {disp32} to control the size of displacement used for memory operands..

I think I'd find the conditionals easier to "read" if they were positive rather than negative? It'd help if the comments spelled out the conditions a little more as well.

Tue, Jul 28, 8:47 PM · Restricted Project

Mon, Jul 27

D18036: Enabling multiple letters and digits in constraints now requires changes to proceed.

This could probably use some tests. If no current upstream port uses the feature though it makes it hard to accept. :(

Mon, Jul 27, 10:07 PM
D26344: Small Data SectionKind and PPC-EABI SDA Relocation now requires changes to proceed.
Mon, Jul 27, 10:05 PM
echristo accepted D84709: [X86] Add support for {disp32} to control size of jmp and jcc instructions in the assembler.
Mon, Jul 27, 6:14 PM · Restricted Project

Sun, Jul 26

echristo requested changes to D84519: [llvm-objdump][AMDGPU] Detect CPU string.

I'd really like all of the cpu specific bits here to not reside in the objdump binary. Ideally it should be in include/ and lib/ somewhere.

Sun, Jul 26, 10:42 PM · Restricted Project

Sat, Jul 25

echristo committed rG4b14ef33e81c: Temporarily Revert "Unify the return value of GetByteSize to an llvm… (authored by echristo).
Temporarily Revert "Unify the return value of GetByteSize to an llvm…
Sat, Jul 25, 6:43 PM
echristo added a reverting change for rG1d9b860fb6a8: Unify the return value of GetByteSize to an llvm::Optional<uint64_t> (NFC-ish): rG4b14ef33e81c: Temporarily Revert "Unify the return value of GetByteSize to an llvm….
Sat, Jul 25, 6:43 PM
echristo committed rG18975762c197: Fold StatepointBB into checks as it's only used from an NDEBUG or ASSERT… (authored by echristo).
Fold StatepointBB into checks as it's only used from an NDEBUG or ASSERT…
Sat, Jul 25, 6:37 PM

Thu, Jul 23

echristo committed rG3ac828b8f7a8: Use llvm::size rather than an empty loop to get the number of top level loops. (authored by echristo).
Use llvm::size rather than an empty loop to get the number of top level loops.
Thu, Jul 23, 3:00 PM
echristo committed rG3a75466f41be: Temporarily Revert "Reland [lldb] Unify type name matching in… (authored by echristo).
Temporarily Revert "Reland [lldb] Unify type name matching in…
Thu, Jul 23, 12:47 AM
echristo added a reverting change for rG074b121642b2: Reland [lldb] Unify type name matching in FormattersContainer: rG3a75466f41be: Temporarily Revert "Reland [lldb] Unify type name matching in….
Thu, Jul 23, 12:47 AM

Fri, Jul 17

echristo committed rG020545d386cf: Temporarily Revert "[OpenMP] Add Additional Function Attribute Information to… (authored by echristo).
Temporarily Revert "[OpenMP] Add Additional Function Attribute Information to…
Fri, Jul 17, 3:07 PM
echristo added a reverting change for rG09fe0c5ab9ca: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def: rG020545d386cf: Temporarily Revert "[OpenMP] Add Additional Function Attribute Information to….
Fri, Jul 17, 3:07 PM
echristo committed rGae08dbc67326: Temporarily Revert "[InlineAdvisor] New inliner advisor to replay inlining from… (authored by echristo).
Temporarily Revert "[InlineAdvisor] New inliner advisor to replay inlining from…
Fri, Jul 17, 2:59 PM
echristo added a reverting change for rG029946b11268: [InlineAdvisor] New inliner advisor to replay inlining from optimization remarks: rGae08dbc67326: Temporarily Revert "[InlineAdvisor] New inliner advisor to replay inlining from….
Fri, Jul 17, 2:59 PM
echristo accepted D84058: Pass -rtlib=libgcc in tests conditioned on the default..
Fri, Jul 17, 11:25 AM · Restricted Project
echristo added a reviewer for D84058: Pass -rtlib=libgcc in tests conditioned on the default.: saugustine.

(Adding Sterling as well)
I think this will be an OK workaround for now, go ahead and reply on the main thread as I think they'll want to set the default runtime library as part of the toolchain. I'm surprised at this behavior as well.

Fri, Jul 17, 11:25 AM · Restricted Project

Thu, Jul 16

echristo accepted D83996: [X86] Change the scheduler model for 'pentium4' to SandyBridgeModel..

Appears so, but ok.

Thu, Jul 16, 7:34 PM · Restricted Project
echristo committed rG7bfaa4008635: Temporarily Revert "[AssumeBundles] Use operand bundles to encode alignment… (authored by echristo).
Temporarily Revert "[AssumeBundles] Use operand bundles to encode alignment…
Thu, Jul 16, 11:54 AM
echristo added a reverting change for rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions: rG7bfaa4008635: Temporarily Revert "[AssumeBundles] Use operand bundles to encode alignment….
Thu, Jul 16, 11:54 AM

Wed, Jul 15

echristo added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile.

I'll share a prototype of the InstSimplify patch on Phabricator, in a day or two; it would be great if the miscompilation is fixed with the patch.

Wed, Jul 15, 6:30 PM · Restricted Project, Restricted Project
echristo added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile.

Wed, Jul 15, 4:36 PM · Restricted Project, Restricted Project
echristo added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

We're starting to see miscompiles as we do more testing as well, just nothing smaller at the moment.

Wed, Jul 15, 3:47 PM · Restricted Project, Restricted Project
echristo added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

This seems like something that we should then revert until we know that instsimplify can be updated with a fix?

Wed, Jul 15, 3:41 PM · Restricted Project, Restricted Project
echristo accepted D83913: [X86] Change the tuning settings for pentium4 to be more modern since its the default 32-bit cpu in clang.

LGTM.

Wed, Jul 15, 3:15 PM · Restricted Project
echristo added a comment to D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4.

Did you want to just change the pentium4 tuning? Otherwise naming things is hard and this feels awkward, but I don't have any better ideas :)

Wed, Jul 15, 12:40 PM · Restricted Project

Tue, Jul 14

echristo committed rG368eb7712f9f: Fix a -Wunused-variable warning. (authored by echristo).
Fix a -Wunused-variable warning.
Tue, Jul 14, 12:41 PM

Mon, Jul 13

echristo committed rGe958379581e5: Fold the opt size check into the assert to silence an unused variable warning. (authored by echristo).
Fold the opt size check into the assert to silence an unused variable warning.
Mon, Jul 13, 4:05 PM

Fri, Jul 10

echristo committed rG256e4d46a675: Fix signed vs unsigned comparison warnings a different way. (authored by echristo).
Fix signed vs unsigned comparison warnings a different way.
Fri, Jul 10, 10:53 PM
echristo committed rGcc28058c13e8: Temporarily revert "[NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG… (authored by echristo).
Temporarily revert "[NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG…
Fri, Jul 10, 3:21 PM
echristo added a reverting change for rG30582457b470: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD): rGcc28058c13e8: Temporarily revert "[NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG….
Fri, Jul 10, 3:21 PM

Thu, Jul 9

echristo added a comment to D83525: Remove optnone from FullUnroll.ll.

I may need to comment it better, but in this case part of it is that it's designed to only have the forced loop unroller run on it.

Thu, Jul 9, 5:37 PM · Restricted Project
echristo committed rG98eec7700c3f: Temporarily Revert "Fix [-Werror,-Wsign-compare] warnings arising from… (authored by echristo).
Temporarily Revert "Fix [-Werror,-Wsign-compare] warnings arising from…
Thu, Jul 9, 2:00 PM
echristo added a reverting change for rGc2827083166c: Fix [-Werror,-Wsign-compare] warnings arising from subsection symbols patch.: rG98eec7700c3f: Temporarily Revert "Fix [-Werror,-Wsign-compare] warnings arising from….
Thu, Jul 9, 2:00 PM
echristo committed rGce1e4853b5a1: Temporarily Revert "[PowerPC] Split s34imm into two types" as it was failing in… (authored by echristo).
Temporarily Revert "[PowerPC] Split s34imm into two types" as it was failing in…
Thu, Jul 9, 1:37 PM
echristo added a reverting change for rGbd2068031121: [PowerPC] Split s34imm into two types: rGce1e4853b5a1: Temporarily Revert "[PowerPC] Split s34imm into two types" as it was failing in….
Thu, Jul 9, 1:37 PM
echristo added a comment to D83013: [LPM] Port CGProfilePass from NPM to LPM.

Some inline nits. I see you've already committed and that's fine - I still don't think we should do it, but we can delete it again soon :)

Thu, Jul 9, 1:08 PM · Restricted Project, Restricted Project
echristo committed rGc2827083166c: Fix [-Werror,-Wsign-compare] warnings arising from subsection symbols patch. (authored by echristo).
Fix [-Werror,-Wsign-compare] warnings arising from subsection symbols patch.
Thu, Jul 9, 11:19 AM
echristo added a comment to D83462: [DWARF] Avoid entry_values production for SCE.

So the tuning here for SCE is also a "does not support" or something else?

Thu, Jul 9, 9:52 AM · Restricted Project, debug-info

Wed, Jul 8

echristo committed rG371c94fca039: Fix a typo in an error message. (authored by echristo).
Fix a typo in an error message.
Wed, Jul 8, 8:46 PM

Jul 8 2020

echristo added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

You also still haven't replied with "what bot/compiler/etc is going to break by making this change". Would you please do that?

Locally, we build flang with our changes with g++ and clang++ on a variety of Linux and MacOS.

Jul 8 2020, 9:02 AM · Restricted Project, Restricted Project
echristo added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

I've reverted these models from the upstreamed code for now. It will avoid the warnings.

Jul 8 2020, 9:01 AM · Restricted Project, Restricted Project
echristo added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

Hi Eric,

There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev

That's not part of the llvm project.

That code base is being upstreamed piecemeal. Not all of the code is upstreamed at this point. It is simply a false impression that code in the middle of being upstreamed is "unused" or "unnecessary". Since it not all of it is upstreamed, changing interfaces and support code in llvm-project directly is going to cause problems that can become hard to track and resolve while the upstreaming is ongoing.

It very much is unused and unnecessary as there are no pieces of that code in the repository.

We are stuck between a rock and a hard place. Flang needs a middle end, as it currently can't generate code. Work on that middle end is being done. We are following the rules and trying to upstream that code in small "reviewable" chunks as quickly as possible. It's just simply going to be the case because of the interdependencies involved and the small chunks process that some code will merely appear to be temporally unused.

If you have a better solution to how to change the upstream process, then our group would be happy to hear it.

Jul 8 2020, 8:12 AM · Restricted Project, Restricted Project
echristo added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

Hi Eric,

There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev

Jul 8 2020, 7:49 AM · Restricted Project, Restricted Project
echristo added a comment to D83397: [flang] Replace uses of _Complex with std::complex.

In whose builds and why? What changes would you like? What compiler are you using? Can you provide any more information?

Jul 8 2020, 7:34 AM · Restricted Project, Restricted Project
Herald added a project to D83397: [flang] Replace uses of _Complex with std::complex: Restricted Project.
Jul 8 2020, 7:20 AM · Restricted Project, Restricted Project

Jul 7 2020

echristo accepted D83368: [NewPM][opt] Share -disable-loop-unrolling between pass managers.

If this works then awesome. :)

Jul 7 2020, 9:52 PM · Restricted Project

Jul 6 2020

echristo accepted D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp.

Works for me :)

Jul 6 2020, 6:48 PM · Restricted Project, Restricted Project
echristo committed rG4029f8ede42f: Temporarily Revert "[llvm-install-name-tool] Merge install-name options" as it… (authored by echristo).
Temporarily Revert "[llvm-install-name-tool] Merge install-name options" as it…
Jul 6 2020, 3:40 PM
echristo added a reverting change for rGc143900a0851: [llvm-install-name-tool] Merge install-name options: rG4029f8ede42f: Temporarily Revert "[llvm-install-name-tool] Merge install-name options" as it….
Jul 6 2020, 3:40 PM
echristo committed rG7c63804383f6: Fix [-Werror,-Wsign-compare] in dominator unit test. (authored by echristo).
Fix [-Werror,-Wsign-compare] in dominator unit test.
Jul 6 2020, 2:50 PM

Jul 5 2020

echristo added reviewers for D83013: [LPM] Port CGProfilePass from NPM to LPM: chandlerc, asbirlea.

Adding Chandler and Alina here as well.

Jul 5 2020, 5:35 PM · Restricted Project, Restricted Project

Jun 30 2020

echristo added a comment to D82387: [flang] add RTBuilder.

This causes warnings about -Wc99-extensions due to the use of _Complex.

Jun 30 2020, 5:23 PM · Restricted Project, Restricted Project
echristo edited reviewers for D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters., added: HAPPY; removed: klimek.
Jun 30 2020, 5:23 PM · Restricted Project
echristo committed rG8164f69e4cb4: Update the phabricator docs to reflect the monorepo change. (authored by echristo).
Update the phabricator docs to reflect the monorepo change.
Jun 30 2020, 11:25 AM
echristo closed D82389: update the phabricator docs to reflect the monorepo.
Jun 30 2020, 11:24 AM · Restricted Project
echristo added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

@echristo was seeing a failure when running the test "Semantics/omp-clause-validity01.f90" as per his revert commit message.

Tests pass for me. I built and tested on an ubuntu Aarch64 machine. Flang was built as a release with debug build using gcc-9.2 with ninja.

Jun 30 2020, 10:20 AM · Restricted Project, Restricted Project
echristo accepted D82389: update the phabricator docs to reflect the monorepo.

LGTM! Thanks!

Jun 30 2020, 10:19 AM · Restricted Project

Jun 25 2020

echristo closed D71687: Fix full loop unrolling initialization in new pass manager.

Committed a while back.

Jun 25 2020, 3:51 PM · Restricted Project, Restricted Project
echristo added inline comments to D82514: Remove references to the 4.0 release as a major breaking (NFC).
Jun 25 2020, 3:51 PM · Restricted Project
echristo accepted D82514: Remove references to the 4.0 release as a major breaking (NFC).

I'm happy with this as well - my only comment was the one Duncan pointed out :)

Jun 25 2020, 3:18 PM · Restricted Project
echristo added a comment to D82514: Remove references to the 4.0 release as a major breaking (NFC).

Do we want to actually do the breaking release?

I don't think so?

Jun 25 2020, 11:20 AM · Restricted Project

Jun 24 2020

echristo accepted D82517: [X86] Emit a reg-reg copy for fast isel of vector bitcasts..

I think this is the right solution, we need to emit the instruction either way and then hopefully we won't fall out, but if we do we're not leaving mistaken state.

Jun 24 2020, 7:01 PM · Restricted Project
echristo added a comment to D82514: Remove references to the 4.0 release as a major breaking (NFC).

Do we want to actually do the breaking release?

Jun 24 2020, 6:29 PM · Restricted Project
echristo added inline comments to D82491: [Apple Silicon] Initial support for Rosetta.
Jun 24 2020, 2:07 PM
echristo added inline comments to D82491: [Apple Silicon] Initial support for Rosetta.
Jun 24 2020, 1:34 PM
echristo added inline comments to D82491: [Apple Silicon] Initial support for Rosetta.
Jun 24 2020, 1:34 PM
echristo accepted D79570: [MC] Fix PR45805: infinite recursion in assembler.

One inline code comment otherwise lgtm.

Jun 24 2020, 11:21 AM · Restricted Project

Jun 23 2020

echristo added inline comments to D78564: [i386] Modify the alignment of __m128/__m256/__m512 vector type according i386 abi..
Jun 23 2020, 1:58 PM

Jun 20 2020

echristo committed rG0861889be103: [clang/llvm] As part of using inclusive language within the llvm project… (authored by echristo).
[clang/llvm] As part of using inclusive language within the llvm project…
Jun 20 2020, 4:26 PM
echristo committed rGda6332f5f9f1: [clang-tidy] As part of using inclusive language within the llvm project… (authored by echristo).
[clang-tidy] As part of using inclusive language within the llvm project…
Jun 20 2020, 3:22 PM
echristo committed rGef455a55bcf2: Update comment to be more clear. (authored by echristo).
Update comment to be more clear.
Jun 20 2020, 2:50 PM
echristo committed rG10b43541360e: Temporarily Revert "[lldb][NFC] Add more test for builtin formats" as it's… (authored by echristo).
Temporarily Revert "[lldb][NFC] Add more test for builtin formats" as it's…
Jun 20 2020, 2:50 PM
echristo committed rGdc204193515b: Rename function to more accurately reflect what it does. (authored by echristo).
Rename function to more accurately reflect what it does.
Jun 20 2020, 2:50 PM
echristo added a reverting change for rG90c1af106a20: [lldb][NFC] Add more test for builtin formats: rG10b43541360e: Temporarily Revert "[lldb][NFC] Add more test for builtin formats" as it's….
Jun 20 2020, 2:50 PM
echristo added inline comments to rGb6536e549d95: As part of using inclusive language within the llvm project, migrate away from….
Jun 20 2020, 2:50 PM
echristo added inline comments to rGf8a463c17096: As part of using inclusive language within the llvm project, migrate away from….
Jun 20 2020, 2:50 PM
echristo added a comment to rGb6536e549d95: As part of using inclusive language within the llvm project, migrate away from….

Thanks!

Jun 20 2020, 2:49 PM
echristo committed rG8116d0190509: Typos around a -> an. (authored by echristo).
Typos around a -> an.
Jun 20 2020, 2:18 PM
echristo added a reverting change for rGb32401464f4c: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0: rG64b04e4754bf: Temporarily Revert "[flang][OpenMP] Enhance parser support for flush construct….
Jun 20 2020, 1:33 AM
echristo committed rG64b04e4754bf: Temporarily Revert "[flang][OpenMP] Enhance parser support for flush construct… (authored by echristo).
Temporarily Revert "[flang][OpenMP] Enhance parser support for flush construct…
Jun 20 2020, 1:33 AM
echristo committed rG1f593f46f35b: [AST/Lex/Parse/Sema] As part of using inclusive language within the llvm… (authored by echristo).
[AST/Lex/Parse/Sema] As part of using inclusive language within the llvm…
Jun 20 2020, 1:33 AM
echristo added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Hi All,

Jun 20 2020, 1:33 AM · Restricted Project, Restricted Project
echristo committed rGf305176bc606: [cpplint] As part of using inclusive language within the llvm project, migrate… (authored by echristo).
[cpplint] As part of using inclusive language within the llvm project, migrate…
Jun 20 2020, 1:01 AM
echristo committed rG10563e16aa2c: [Analysis/Transforms/Sanitizers] As part of using inclusive language within the… (authored by echristo).
[Analysis/Transforms/Sanitizers] As part of using inclusive language within the…
Jun 20 2020, 1:01 AM
echristo committed rGae2fa770e1c3: [docs/examples] As part of using inclusive language within the llvm project… (authored by echristo).
[docs/examples] As part of using inclusive language within the llvm project…
Jun 20 2020, 1:01 AM
echristo committed rG858d38557857: As part of using inclusive language within the llvm project, migrate away from… (authored by echristo).
As part of using inclusive language within the llvm project, migrate away from…
Jun 20 2020, 12:29 AM
echristo committed rGcf2385258714: [Target] As part of using inclusive language within the llvm project, migrate… (authored by echristo).
[Target] As part of using inclusive language within the llvm project, migrate…
Jun 20 2020, 12:29 AM
echristo committed rGe5e593e9e339: [Support/Utils] As part of using inclusive language within the llvm project… (authored by echristo).
[Support/Utils] As part of using inclusive language within the llvm project…
Jun 20 2020, 12:29 AM

Jun 19 2020

echristo committed rGa1469914fd75: Update error to read a little better when an error occurs. (authored by echristo).
Update error to read a little better when an error occurs.
Jun 19 2020, 11:57 PM
echristo committed rGd313cb6e956d: Update redirected output file. (authored by echristo).
Update redirected output file.
Jun 19 2020, 11:57 PM
echristo committed rG25ed42f05d07: [clang-change-namespace] As part of using inclusive language within the llvm… (authored by echristo).
[clang-change-namespace] As part of using inclusive language within the llvm…
Jun 19 2020, 11:16 PM