Page MenuHomePhabricator

probinson (Paul Robinson)
User

Projects

User Details

User Since
May 9 2013, 11:10 AM (453 w, 5 d)

Recent Activity

Today

probinson committed rG14a793ab0589: [lit] Fix compatibility with upstream gtest (authored by lzaoral).
[lit] Fix compatibility with upstream gtest
Wed, Jan 19, 8:03 AM
probinson closed D100043: [lit] Fix compatibility with upstream gtest.
Wed, Jan 19, 8:02 AM · Restricted Project

Yesterday

probinson added a comment to D100043: [lit] Fix compatibility with upstream gtest.

Thanks a lot @delcypher! Can you (or anyone else with commit rights) commit it to trunk for me?

Tue, Jan 18, 9:28 AM · Restricted Project

Thu, Jan 13

probinson accepted D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.

LGTM

Thu, Jan 13, 8:44 AM · debug-info, Restricted Project

Wed, Jan 12

probinson added inline comments to D117124: [DWARF][DebugInfo] Fix off-by-one error in size of DW_TAG_base_type types.
Wed, Jan 12, 10:06 AM · debug-info, Restricted Project

Fri, Jan 7

probinson accepted D115657: [Nomination] Adding Intel representatives to security group.

LGTM

Fri, Jan 7, 7:30 AM · Restricted Project

Thu, Jan 6

probinson added a comment to D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units.

Looking at the DWARFv5 spec while trying to get my head round pubnames, I see that there's a v5 specific section that combines pubnames and pubtypes called debug_names. Sorry if this is a silly question - this part of DWARF is new to me - does clang support emitting debug_names?

Thu, Jan 6, 1:48 PM · debug-info, Restricted Project

Wed, Jan 5

probinson accepted D113633: [llvm] Add support for DW_TAG_immutable_type.

LGTM

Wed, Jan 5, 10:44 AM · debug-info, Restricted Project

Tue, Jan 4

probinson committed rGfa17c0e27ac5: [PS4] Verify the default DWARF version is 4. (authored by probinson).
[PS4] Verify the default DWARF version is 4.
Tue, Jan 4, 11:57 AM
probinson added a comment to D113633: [llvm] Add support for DW_TAG_immutable_type.

Code looks quite reasonable; the test needs a little cleanup.

Tue, Jan 4, 9:30 AM · debug-info, Restricted Project

Dec 13 2021

probinson added a comment to D114412: github: Add action for automated issue notification.

Presumably we can generate the team memberships from the Bugzilla component auto-subscribers easily enough, even if it's manual.
I take it we'd need one of these sub-teams per label (mostly); is there a max number of teams?

Dec 13 2021, 10:04 AM · Restricted Project

Dec 10 2021

probinson committed rG3b5e104b2293: Verify inferattrs doesn't infer unexpected attributes (authored by probinson).
Verify inferattrs doesn't infer unexpected attributes
Dec 10 2021, 7:55 AM
probinson closed D110720: Verify inferattrs doesn't infer unexpected attributes.
Dec 10 2021, 7:54 AM · Restricted Project

Dec 2 2021

probinson committed rG7bef49296e05: [TLI checker] Follow good practice with -COUNT directives (authored by probinson).
[TLI checker] Follow good practice with -COUNT directives
Dec 2 2021, 2:28 PM
probinson added a comment to D110720: Verify inferattrs doesn't infer unexpected attributes.

Ping

Dec 2 2021, 10:52 AM · Restricted Project
probinson added a reverting change for rG8cd61aac0030: Revert "[TLI checker] Add more tests": rGd3fe1c1583a5: Reapply "[TLI checker] Add more tests".
Dec 2 2021, 8:57 AM
probinson committed rGd3fe1c1583a5: Reapply "[TLI checker] Add more tests" (authored by probinson).
Reapply "[TLI checker] Add more tests"
Dec 2 2021, 8:57 AM
probinson added a reverting change for rG2778554971da: [TLI checker] Add more tests: rG8cd61aac0030: Revert "[TLI checker] Add more tests".
Dec 2 2021, 8:32 AM
probinson committed rG8cd61aac0030: Revert "[TLI checker] Add more tests" (authored by probinson).
Revert "[TLI checker] Add more tests"
Dec 2 2021, 8:32 AM
probinson added a reverting change for D114913: [TLI checker] Add more tests: rG8cd61aac0030: Revert "[TLI checker] Add more tests".
Dec 2 2021, 8:32 AM · Restricted Project
probinson committed rG2778554971da: [TLI checker] Add more tests (authored by probinson).
[TLI checker] Add more tests
Dec 2 2021, 8:19 AM
probinson closed D114913: [TLI checker] Add more tests.
Dec 2 2021, 8:19 AM · Restricted Project
probinson updated the diff for D114913: [TLI checker] Add more tests.

Address review comments.

Dec 2 2021, 7:41 AM · Restricted Project
probinson added inline comments to D114913: [TLI checker] Add more tests.
Dec 2 2021, 7:22 AM · Restricted Project

Dec 1 2021

probinson requested review of D114913: [TLI checker] Add more tests.
Dec 1 2021, 2:59 PM · Restricted Project
probinson committed rG66071f440c31: [TLI checker] Update for post-commit review comments (authored by probinson).
[TLI checker] Update for post-commit review comments
Dec 1 2021, 12:35 PM
probinson closed D114478: [TLI checker] Update for post-commit review comments.
Dec 1 2021, 12:35 PM · Restricted Project

Nov 30 2021

probinson committed rGb8e03be88dc8: [PS4][DWARF] Explicitly set default DWARF version to 4 (authored by probinson).
[PS4][DWARF] Explicitly set default DWARF version to 4
Nov 30 2021, 8:59 AM
probinson added inline comments to D114478: [TLI checker] Update for post-commit review comments.
Nov 30 2021, 8:20 AM · Restricted Project
probinson updated the diff for D114478: [TLI checker] Update for post-commit review comments.

Fix warning capitalization

Nov 30 2021, 8:18 AM · Restricted Project

Nov 29 2021

probinson added inline comments to D114478: [TLI checker] Update for post-commit review comments.
Nov 29 2021, 2:00 PM · Restricted Project
probinson updated the diff for D114478: [TLI checker] Update for post-commit review comments.

Tidy up error handling for more consistency.
Ignore unsupported symbols.

Nov 29 2021, 1:57 PM · Restricted Project
probinson added inline comments to D114478: [TLI checker] Update for post-commit review comments.
Nov 29 2021, 10:44 AM · Restricted Project

Nov 24 2021

probinson updated the diff for D114478: [TLI checker] Update for post-commit review comments.

Remove more unnecessary sections/fields from yaml file.
Report filename in a warning message.
Unconditionally demangle function name for future-proofing.

Nov 24 2021, 8:22 AM · Restricted Project
probinson added inline comments to D114478: [TLI checker] Update for post-commit review comments.
Nov 24 2021, 7:46 AM · Restricted Project
probinson committed rGf3bfe1b41876: Have yaml2obj describe all options in --help (authored by probinson).
Have yaml2obj describe all options in --help
Nov 24 2021, 7:45 AM
probinson closed D114538: Have yaml2obj describe all options in --help.
Nov 24 2021, 7:45 AM · Restricted Project
probinson added a comment to D114538: Have yaml2obj describe all options in --help.

Before:

OVERVIEW: Create an object file from a YAML description
USAGE: yaml2obj [options] <input file>
Nov 24 2021, 7:43 AM · Restricted Project
probinson requested review of D114538: Have yaml2obj describe all options in --help.
Nov 24 2021, 7:20 AM · Restricted Project

Nov 23 2021

probinson added a comment to D111358: TargetLibraryInfo checker tool.

What this tool does fit a bit into the realm of llvm-ifs (it had a previous name "llvm-elfabi" D100139. I like "elfabi" better as "ifs" seems confusing). Would it be suitable to move the code there?

Nov 23 2021, 2:56 PM · Restricted Project
probinson requested review of D114478: [TLI checker] Update for post-commit review comments.
Nov 23 2021, 2:55 PM · Restricted Project
probinson committed rGc075566c8df0: [PS4][TLI] Remove redundant line (authored by probinson).
[PS4][TLI] Remove redundant line
Nov 23 2021, 8:43 AM

Nov 16 2021

probinson accepted D113862: [DebugInfo] Use DbgEntityKind in DbgEntity interface (NFC).

LGTM

Nov 16 2021, 7:40 AM · Restricted Project

Nov 12 2021

probinson added a comment to D113633: [llvm] Add support for DW_TAG_immutable_type.

Also, take the example of https://reviews.llvm.org/D113634 , which may be split into two patches for further discussion. Anyway, I tend to agree with you, I can join everything together in D113634.

Nov 12 2021, 10:10 AM · debug-info, Restricted Project
probinson added a project to D113633: [llvm] Add support for DW_TAG_immutable_type: debug-info.
Nov 12 2021, 9:19 AM · debug-info, Restricted Project
probinson added a reviewer for D113633: [llvm] Add support for DW_TAG_immutable_type: probinson.
Nov 12 2021, 9:16 AM · debug-info, Restricted Project
probinson added a comment to D113633: [llvm] Add support for DW_TAG_immutable_type.

Typically I've done "support" for a tag or other DWARF feature in several phases, each usually (not necessarily) with its own patch. Each phase builds on the previous one, which is the project's preferred incremental-development model.

Nov 12 2021, 9:15 AM · debug-info, Restricted Project
probinson added a comment to D113632: [docs] Add DW_TAG_immutable_type tag.

This should be in the same patch as the code changes, D113633.

Nov 12 2021, 8:47 AM · Restricted Project

Nov 11 2021

probinson committed rG665b4138d9ec: [DebugInfo] run clang-format on some unformatted files (authored by ljmf00).
[DebugInfo] run clang-format on some unformatted files
Nov 11 2021, 7:10 PM
probinson closed D113572: [DebugInfo] run clang-format on some unformatted files.
Nov 11 2021, 7:10 PM · Restricted Project
probinson added a comment to D113572: [DebugInfo] run clang-format on some unformatted files.

@probinson Can you check now? If it looks good, can you land it, please?

Nov 11 2021, 1:55 PM · Restricted Project

Nov 10 2021

probinson accepted D113572: [DebugInfo] run clang-format on some unformatted files.

In general doing a clang-format before extensive work on some files is an obvious NFC, but I can see why you might have wanted some review on this.

Nov 10 2021, 10:39 AM · Restricted Project

Nov 8 2021

probinson committed rG26c2afce7896: Fix test dependencies to add llvm-tli-checker (authored by probinson).
Fix test dependencies to add llvm-tli-checker
Nov 8 2021, 5:22 PM
probinson committed rG38be8f4057c1: Add llvm-tli-checker (authored by probinson).
Add llvm-tli-checker
Nov 8 2021, 4:30 PM
probinson added a reverting change for rG62dd488164f5: Add llvm-tli-checker: rG1297c214060a: Revert "Add llvm-tli-checker".
Nov 8 2021, 3:48 PM
probinson committed rG1297c214060a: Revert "Add llvm-tli-checker" (authored by probinson).
Revert "Add llvm-tli-checker"
Nov 8 2021, 3:48 PM
probinson added a reverting change for D111358: TargetLibraryInfo checker tool: rG1297c214060a: Revert "Add llvm-tli-checker".
Nov 8 2021, 3:48 PM · Restricted Project
probinson committed rG62dd488164f5: Add llvm-tli-checker (authored by probinson).
Add llvm-tli-checker
Nov 8 2021, 3:02 PM
probinson closed D111358: TargetLibraryInfo checker tool.
Nov 8 2021, 3:02 PM · Restricted Project
probinson accepted D113406: [llvm-dwarfdump] dump link to the immediate parent..

LGTM

Nov 8 2021, 2:03 PM · Restricted Project
probinson added a comment to D113406: [llvm-dwarfdump] dump link to the immediate parent..

I'd rather see this as part of Verbose. The DIEs are indented to show nesting already, so the explicit parent offset is really additional information.

Nov 8 2021, 9:56 AM · Restricted Project

Nov 4 2021

probinson added a comment to D110720: Verify inferattrs doesn't infer unexpected attributes.

The lines where CHECK is split into CHECK-LINUX and CHECK-NOLINUX are also enabling the test for nvptx.

Nov 4 2021, 1:13 PM · Restricted Project
probinson updated the diff for D110720: Verify inferattrs doesn't infer unexpected attributes.

Sorry it took a while to cycle back to this.

Nov 4 2021, 12:58 PM · Restricted Project
probinson updated the diff for D111358: TargetLibraryInfo checker tool.

Updated the UI:
Removed --verbose, replaced with --report=[summary,discrepancy,full]
Added --dump-tli to get info about TLI without reference to a library file

Nov 4 2021, 9:18 AM · Restricted Project

Nov 3 2021

probinson added a comment to D111358: TargetLibraryInfo checker tool.

Sorry for the long delay, between CPPcon and putting together a dev-meeting talk I've been pretty distracted.

Nov 3 2021, 1:03 PM · Restricted Project

Oct 26 2021

probinson accepted D111770: [DebugInfo] Skip ODRUniquing for mismatched tags.

Given that enum is really the only problematic case, LGTM.

Oct 26 2021, 1:00 PM · Restricted Project

Oct 22 2021

probinson added a comment to D111770: [DebugInfo] Skip ODRUniquing for mismatched tags.

I'm not a verifier expert, but I'm also not convinced the verifier change is doing quite the right thing. Yes, it finds the case we ran into, but it seems like it's just checking for that one bogus case where the containing scope is incorrectly an enum. It seems to me that proper scope-checking should be looking for the tag to be something that we agree should be allowed to be a scope, rather than looking for the tag to be one thing (of many?) that we agree should not be a scope.

Oct 22 2021, 11:26 AM · Restricted Project

Oct 8 2021

probinson updated subscribers of D111358: TargetLibraryInfo checker tool.

+ @jhenderson for object-file-reading expertise.

Oct 8 2021, 7:19 AM · Restricted Project
probinson updated subscribers of D111358: TargetLibraryInfo checker tool.

+folks who participated in D107509

Oct 8 2021, 7:16 AM · Restricted Project
probinson accepted D111352: [clang] Fix absolute file paths with -fdebug-prefix-map.

I suspect this is not the only way for directories and filenames to become confused, but it certainly helps. LGTM.

Oct 8 2021, 7:12 AM · Restricted Project

Oct 7 2021

probinson requested review of D111358: TargetLibraryInfo checker tool.
Oct 7 2021, 2:49 PM · Restricted Project
probinson accepted D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

Thanks for the ping, I hadn't added this to my to-do list. LGTM

Oct 7 2021, 11:40 AM · Restricted Project, debug-info
probinson committed rGaec66f895bf5: [PS4][TargetLibraryInfo] Set TLI info correctly for PS4 (authored by probinson).
[PS4][TargetLibraryInfo] Set TLI info correctly for PS4
Oct 7 2021, 10:05 AM

Oct 6 2021

probinson accepted D111172: [PS4 UBSAN] Emit ud2 for ubsantrap for the PS4 target..

One minor thing and LGTM.

Oct 6 2021, 8:29 AM · Restricted Project

Oct 5 2021

probinson accepted D110455: DebugInfo: Use clang's preferred names for integer types.

Seems like a good simplification. LGTM.

Oct 5 2021, 7:08 AM · Restricted Project, Restricted Project, Restricted Project
probinson added a comment to D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd.

Is there a config tweak needed to get this to run properly for us? Given the upstream Windows bots are not seeing a problem.

Oct 5 2021, 5:55 AM · Restricted Project

Oct 4 2021

probinson added a comment to D111072: [llvm-cxxfilt][NFC] Fix test for running in Windows cmd.

We were seeing this in a downstream windows bot, although it doesn't seem to affect any public bots. If anyone has suggestions about why that might be, we're open to fiddling our downstream bot.

Oct 4 2021, 10:02 AM · Restricted Project

Sep 30 2021

probinson added a comment to D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

It may feel like I'm being a bit picky, but the prologue_end business is a bit picky, and it's helpful to have the tests be as clear as possible about what's expected.

Sep 30 2021, 2:18 PM · Restricted Project, debug-info

Sep 29 2021

probinson added inline comments to D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.
Sep 29 2021, 12:35 PM · Restricted Project, debug-info
probinson added a comment to D110720: Verify inferattrs doesn't infer unexpected attributes.

A bit of yak shaving because I had wanted to add __sqrt*_finite to annotate.ll, but it wasn't doing quite the right thing.

Sep 29 2021, 8:12 AM · Restricted Project
probinson requested review of D110720: Verify inferattrs doesn't infer unexpected attributes.
Sep 29 2021, 8:09 AM · Restricted Project

Sep 28 2021

probinson committed rG56e681afcce5: [TargetLibraryInfo] Pick new/delete calls by target (authored by probinson).
[TargetLibraryInfo] Pick new/delete calls by target
Sep 28 2021, 10:11 AM
probinson closed D110419: [TargetLibraryInfo] Pick new/delete calls by target.
Sep 28 2021, 10:11 AM · Restricted Project

Sep 24 2021

probinson updated the diff for D110419: [TargetLibraryInfo] Pick new/delete calls by target.

Split test into 3 parts.

Sep 24 2021, 2:19 PM · Restricted Project
probinson committed rG6185ad03f108: [TargetLibraryInfo] Correctly handle sqrt*_finite (authored by probinson).
[TargetLibraryInfo] Correctly handle sqrt*_finite
Sep 24 2021, 11:58 AM
probinson closed D110418: [TargetLibraryInfo] Correctly handle sqrt*_finite.
Sep 24 2021, 11:57 AM · Restricted Project
probinson committed rG1376ae909431: [TargetLibraryInfo][AMDGPU] Minor cleanup, NFC (authored by probinson).
[TargetLibraryInfo][AMDGPU] Minor cleanup, NFC
Sep 24 2021, 7:53 AM
probinson requested review of D110419: [TargetLibraryInfo] Pick new/delete calls by target.
Sep 24 2021, 7:24 AM · Restricted Project
probinson requested review of D110418: [TargetLibraryInfo] Correctly handle sqrt*_finite.
Sep 24 2021, 7:22 AM · Restricted Project

Sep 23 2021

probinson added a comment to D107162: [lit] Have REQUIRES support the target triple.

As this patch has had to be reverted due to a completely baffling failure on one bot, we can reopen the debate about how to solve the original problem, which is: XFAIL and UNSUPPORTED allow triples (with substring handling), but REQUIRES doesn't know about triples at all.

Sep 23 2021, 6:52 AM · Restricted Project

Sep 22 2021

probinson accepted D110129: [DebugInfo] Support typedef with btf_decl_tag attributes.
  • The only thing left is for llvm/test/DebugInfo/X86/attr-btf_tag-typedef.ll for which I didn't use %itanium_abi_triple as it seems only available for %clang ... and not available for llc.
Sep 22 2021, 7:45 AM · Restricted Project, Restricted Project, debug-info

Sep 21 2021

probinson added inline comments to D110129: [DebugInfo] Support typedef with btf_decl_tag attributes.
Sep 21 2021, 7:09 AM · Restricted Project, Restricted Project, debug-info

Sep 20 2021

probinson committed rGfa822a2ee52f: [DebugInfo] Add test for dumping DW_AT_defaulted (authored by probinson).
[DebugInfo] Add test for dumping DW_AT_defaulted
Sep 20 2021, 1:44 PM
probinson abandoned D109970: [DebugInfo] Support DW_AT_defaulted.

I've poked around in the copy of gdb that we're using for testing; I see it noting DW_AT_defaulted, and factoring it into pass by reference/value decisions; but, if DW_AT_calling_convention is present, the latter takes precedence.
It looks like CGDebugInfo::CreateLimitedType will always set the CC flags for a CXXRecordDecl, and I think we always go through that path for complete type descriptions, so I accept that DW_AT_defaulted isn't really necessary.

Sep 20 2021, 12:12 PM · Restricted Project, debug-info

Sep 17 2021

probinson added a comment to D109970: [DebugInfo] Support DW_AT_defaulted.

Any particular use case in mind for this debug info? (generally I'd rather we not emit extra DWARF we don't have some use case for in mind)

Sep 17 2021, 2:27 PM · Restricted Project, debug-info
probinson added a comment to D109970: [DebugInfo] Support DW_AT_defaulted.

I think this is the last of the new DWARF v5 tags/attributes.

Sep 17 2021, 8:32 AM · Restricted Project, debug-info
probinson requested review of D109970: [DebugInfo] Support DW_AT_defaulted.
Sep 17 2021, 8:29 AM · Restricted Project, debug-info

Aug 31 2021

probinson committed rG71fbfd4e73b1: Make a generic test generic again. (authored by probinson).
Make a generic test generic again.
Aug 31 2021, 8:46 AM
probinson added a comment to D106621: [DWARF] Support new TAG DW_TAG_LLVM_annotation.

Looks generally OK to me. (not 100% sure that DW_TAG extension space is unused, but I think we've generally got most of the extensions in llvm-dwarfdump, so it probably is unused - and worst-case we can change it if needed)

Aug 31 2021, 7:57 AM · Restricted Project, debug-info

Aug 17 2021

probinson accepted D106906: [Nomination] Adding an Nvidia representative to security group.
Aug 17 2021, 11:09 AM · Restricted Project