- User Since
- May 9 2013, 11:10 AM (453 w, 5 d)
Thu, Jan 13
Wed, Jan 12
Fri, Jan 7
Thu, Jan 6
Wed, Jan 5
Tue, Jan 4
Code looks quite reasonable; the test needs a little cleanup.
Dec 13 2021
Presumably we can generate the team memberships from the Bugzilla component auto-subscribers easily enough, even if it's manual.
I take it we'd need one of these sub-teams per label (mostly); is there a max number of teams?
Dec 10 2021
Dec 2 2021
Address review comments.
Dec 1 2021
Nov 30 2021
Fix warning capitalization
Nov 29 2021
Tidy up error handling for more consistency.
Ignore unsupported symbols.
Nov 24 2021
Remove more unnecessary sections/fields from yaml file.
Report filename in a warning message.
Unconditionally demangle function name for future-proofing.
OVERVIEW: Create an object file from a YAML description USAGE: yaml2obj [options] <input file>
Nov 23 2021
Nov 16 2021
Nov 12 2021
Typically I've done "support" for a tag or other DWARF feature in several phases, each usually (not necessarily) with its own patch. Each phase builds on the previous one, which is the project's preferred incremental-development model.
This should be in the same patch as the code changes, D113633.
Nov 11 2021
Nov 10 2021
In general doing a clang-format before extensive work on some files is an obvious NFC, but I can see why you might have wanted some review on this.
Nov 8 2021
I'd rather see this as part of Verbose. The DIEs are indented to show nesting already, so the explicit parent offset is really additional information.
Nov 4 2021
The lines where CHECK is split into CHECK-LINUX and CHECK-NOLINUX are also enabling the test for nvptx.
Sorry it took a while to cycle back to this.
Updated the UI:
Removed --verbose, replaced with --report=[summary,discrepancy,full]
Added --dump-tli to get info about TLI without reference to a library file
Nov 3 2021
Sorry for the long delay, between CPPcon and putting together a dev-meeting talk I've been pretty distracted.
Oct 26 2021
Given that enum is really the only problematic case, LGTM.
Oct 22 2021
I'm not a verifier expert, but I'm also not convinced the verifier change is doing quite the right thing. Yes, it finds the case we ran into, but it seems like it's just checking for that one bogus case where the containing scope is incorrectly an enum. It seems to me that proper scope-checking should be looking for the tag to be something that we agree should be allowed to be a scope, rather than looking for the tag to be one thing (of many?) that we agree should not be a scope.
Oct 8 2021
+ @jhenderson for object-file-reading expertise.
+folks who participated in D107509
I suspect this is not the only way for directories and filenames to become confused, but it certainly helps. LGTM.
Oct 7 2021
Thanks for the ping, I hadn't added this to my to-do list. LGTM
Oct 6 2021
One minor thing and LGTM.
Oct 5 2021
Seems like a good simplification. LGTM.
Is there a config tweak needed to get this to run properly for us? Given the upstream Windows bots are not seeing a problem.
Oct 4 2021
We were seeing this in a downstream windows bot, although it doesn't seem to affect any public bots. If anyone has suggestions about why that might be, we're open to fiddling our downstream bot.
Sep 30 2021
It may feel like I'm being a bit picky, but the prologue_end business is a bit picky, and it's helpful to have the tests be as clear as possible about what's expected.
Sep 29 2021
A bit of yak shaving because I had wanted to add __sqrt*_finite to annotate.ll, but it wasn't doing quite the right thing.
Sep 28 2021
Sep 24 2021
Split test into 3 parts.
Sep 23 2021
As this patch has had to be reverted due to a completely baffling failure on one bot, we can reopen the debate about how to solve the original problem, which is: XFAIL and UNSUPPORTED allow triples (with substring handling), but REQUIRES doesn't know about triples at all.
Sep 22 2021
Sep 21 2021
Sep 20 2021
I've poked around in the copy of gdb that we're using for testing; I see it noting DW_AT_defaulted, and factoring it into pass by reference/value decisions; but, if DW_AT_calling_convention is present, the latter takes precedence.
It looks like CGDebugInfo::CreateLimitedType will always set the CC flags for a CXXRecordDecl, and I think we always go through that path for complete type descriptions, so I accept that DW_AT_defaulted isn't really necessary.
Sep 17 2021
I think this is the last of the new DWARF v5 tags/attributes.