Page MenuHomePhabricator

Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph()
ClosedPublic

Authored by rampitec on Apr 5 2021, 1:23 PM.

Details

Summary

clang++ uses llvm.compiler.used in certain cases to preserve
symbol which is fully inlined. D96087 has resulted in undefined
symbols in such cases. Set it to false by default to preserve
old behavior but keep the option for specific uses where we
want to ignore these (e.g. to detect a potential indirect call
to a function).

Diff Detail

Event Timeline

rampitec created this revision.Apr 5 2021, 1:23 PM
rampitec requested review of this revision.Apr 5 2021, 1:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 1:23 PM
Herald added a subscriber: wdng. · View Herald Transcript
SeanP added a subscriber: SeanP.Apr 5 2021, 6:26 PM
SeanP accepted this revision.Apr 8 2021, 10:25 AM

LGTM

This revision is now accepted and ready to land.Apr 8 2021, 10:25 AM