Build HIP tests from llvm-test-suite using AMDGPU.
There will be an upcoming patch to add HIP test to llvm-test-suite/External/HIP.
That sounds good. I've opened a patch for that script (although still under-development):
AnnotatedBuilder.py seems to enforce running python on scripts in relative local paths. Should I wrap my bash script with a python script so that it can run the bash script? I noticed cuda also using full path /buildbot/cuda-build outside of zorg. Thanks.
No. Cuda builders got that in the code base as a temporary solution while they are working on their annotated script. Exactly the same arguments as yours. And I see that being confusing, and don't think it worth it after all.
To get it working in the production you need to add the support for shell scripts anyway. With that in place you could put your script in the right place and keep working on that while your builder is staged. It seems the right thing to do.
Please feel free to ask if you have questions or will need help with adding the shell script support.
Hi Galina, I've opened a small patch that should execute .py scripts with python, and all other scripts directly. Is there any public buildbot test that ensures the change works, I won't have access to all the various environments using AnnotatedBuilder.py. Thank you.
Looks good with a nitpick. Please see my comment inline.
I will keep it as a local uncommitted script during bring-up.
This is fine, but please make sure everything is complete and committed before you will be ready to move the bot to the production.
How about script_interpreter=None instead?