Move #include <complex.h> to complex-reduction.h, where
it is needed in MSVC builds.
Exclude code that requires a native 128-bit integer type from
compilation by MSVC.
Paths
| Differential D99806
[flang] Address more MSVC build issues with reduction & numeric intrinsics ClosedPublic Authored by klausler on Apr 2 2021, 11:10 AM.
Details Summary Move #include <complex.h> to complex-reduction.h, where Exclude code that requires a native 128-bit integer type from
Diff Detail
Event Timelineklausler retitled this revision from [flang] Address more MSVC build issues with reductions to [flang] Address more MSVC build issues with reduction & numeric intrinsics. Comment ActionsExclude more entry points. Comment Actions I get this error: D:\dev\llvm-project\flang\runtime\reduction.cpp(95): error C2059: syntax error: 'template' D:\dev\llvm-project\flang\runtime\reduction.cpp(404): note: see reference to function template instantiation 'signed char Fortran::runtime::GetTotalReduction<Fortran::common::TypeCategory::Integer,1,Fortran::runtime::IntegerSumAccumulator<int>>(const Fortran::runtime::Descriptor &,const char *,int,int,const Fortran::runtime::Descriptor *,ACCUMULATOR &&,const char *)' being compiled with [ ACCUMULATOR=Fortran::runtime::IntegerSumAccumulator<int> ] Could you fix it? Comment Actions Add attempted MSVC work-around to dodge error on "accumulator.template GetResult(...)" in function template. Comment Actions It works Remaining (after applying the patch) D:\dev\llvm-project\flang\runtime\reduction.cpp(161): error C2059: syntax error: 'template' D:\dev\llvm-project\flang\runtime\reduction.cpp(137): error C2059: syntax error: 'template' Comment Actions
Thank you for your help. Please approve when convenient. This revision is now accepted and ready to land.Apr 2 2021, 2:00 PM Closed by commit rGc115c28914a0: [flang] Address more MSVC build issues with reductions (authored by klausler). · Explain WhyApr 2 2021, 3:01 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 335012 flang/runtime/complex-reduction.h
flang/runtime/complex-reduction.c
flang/runtime/numeric.h
flang/runtime/numeric.cpp
flang/runtime/reduction.h
flang/runtime/reduction.cpp
|