This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO] Skip dangling probe value when computing profile summary
ClosedPublic

Authored by wenlei on Apr 1 2021, 10:14 PM.

Details

Summary

Recently we switched to use InvalidProbeCount = UINT64_MAX (instead of 0) to represent dangling probe, but UINT64_MAX is not excluded when computing profile summary. This caused profile summary to produce incorrect hot/cold threshold. The change fixed it by excluding UINT64_MAX from summary builder.

Diff Detail

Event Timeline

wenlei created this revision.Apr 1 2021, 10:14 PM
wenlei requested review of this revision.Apr 1 2021, 10:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 10:14 PM
hoy accepted this revision.Apr 1 2021, 10:45 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 1 2021, 10:45 PM
wlei added a comment.Apr 1 2021, 10:46 PM

lgtm, thanks!

wlei accepted this revision.Apr 1 2021, 10:47 PM