This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in lib/AsmParser
AbandonedPublic

Authored by LegalizeAdulthood on May 24 2015, 11:40 PM.

Reviewers

Summary

Use clang-tidy to simplify boolean conditional return statements.

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in lib/AsmParser.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

LGTM

Can someone commit this for me, please? Thanks.

Richard Thomson <legalize@xmission.com>

r238250

Path

Size

lib/

AsmParser/

5 lines

Show First 20 Lines • Show All 558 Lines • ▼ Show 20 Lines	do {
if (ParseToken(lltok::exclaim, "Expected '!' here"))		if (ParseToken(lltok::exclaim, "Expected '!' here"))
return true;		return true;

MDNode *N = nullptr;		MDNode *N = nullptr;
if (ParseMDNodeID(N)) return true;		if (ParseMDNodeID(N)) return true;
NMD->addOperand(N);		NMD->addOperand(N);
} while (EatIfPresent(lltok::comma));		} while (EatIfPresent(lltok::comma));

if (ParseToken(lltok::rbrace, "expected end of metadata node"))		return ParseToken(lltok::rbrace, "expected end of metadata node");
return true;

return false;
}		}

/// ParseStandaloneMetadata:		/// ParseStandaloneMetadata:
/// !42 = !{...}		/// !42 = !{...}
bool LLParser::ParseStandaloneMetadata() {		bool LLParser::ParseStandaloneMetadata() {
assert(Lex.getKind() == lltok::exclaim);		assert(Lex.getKind() == lltok::exclaim);
Lex.Lex();		Lex.Lex();
unsigned MetadataID = 0;		unsigned MetadataID = 0;
▲ Show 20 Lines • Show All 5,204 Lines • Show Last 20 Lines