This is an archive of the discontinued LLVM Phabricator instance.

Differential D99644

[WebAssembly] Raname a test and fix comments
ClosedPublic

Authored by aheejin on Mar 31 2021, 2:34 AM.

Details

Reviewers
dschuff
Commits
rGf38a9d63402d: [WebAssembly] Raname a test and fix comments
Summary

D99627 fixed a decoding bug, not an encoding bug. This renames the test
to correct it and fix comments.

Diff Detail

Event Timeline

aheejin created this revision.Mar 31 2021, 2:34 AM
Herald added subscribers: wingo, ecnelises, sunfish and 2 others. · View Herald TranscriptMar 31 2021, 2:34 AM
aheejin requested review of this revision.Mar 31 2021, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2021, 2:34 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B96489: Diff 334387.Mar 31 2021, 3:09 AM
dschuff accepted this revision.Mar 31 2021, 8:49 AM
This revision is now accepted and ready to land.Mar 31 2021, 8:49 AM
Closed by commit rGf38a9d63402d: [WebAssembly] Raname a test and fix comments (authored by aheejin). · Explain WhyMar 31 2021, 9:13 AM
This revision was automatically updated to reflect the committed changes.
aheejin added a commit: rGf38a9d63402d: [WebAssembly] Raname a test and fix comments.

Revision Contents

PathSize
llvm/
test/
MC/
WebAssembly/
event-section-decoding.ll
event-section-encoding.ll
6 lines

Diff 334459

llvm/test/MC/WebAssembly/event-section-decoding.ll

  • This file was moved from llvm/test/MC/WebAssembly/event-section-encoding.ll.
; RUN: llc -filetype=obj -exception-model=wasm -mattr=+exception-handling %s -o - | obj2yaml | FileCheck %s ; RUN: llc -filetype=obj -exception-model=wasm -mattr=+exception-handling %s -o - | obj2yaml | FileCheck %s
; This is a regression test for an encoding bug that happens when an event's ; This is a regression test for a decoding bug that happens when an event's
; sigindex is greater than 63, so we put 63 dummy functions with different ; sigindex is greater than 63, so we put 63 dummy functions with different
; signatures before the function that contains the 'throw' instruction to make ; signatures before the function that contains the 'throw' instruction to make
; the event's sigindex 64. ; the event's sigindex 64.
target triple = "wasm32-unknown-unknown" target triple = "wasm32-unknown-unknown"
declare void @llvm.wasm.throw(i32, i8*) declare void @llvm.wasm.throw(i32, i8*)
▲ Show 20 Lines • Show All 317 Lines • ▼ Show 20 Linesentry:
ret i32 0 ret i32 0
} }
define i32 @test_throw(i8* %p) { define i32 @test_throw(i8* %p) {
call void @llvm.wasm.throw(i32 0, i8* %p) call void @llvm.wasm.throw(i32 0, i8* %p)
ret i32 0 ret i32 0
} }
; Checks to see if the event index is correctly encoded in ULEB128. If it is ; Checks to see if the event index is correctly decoded in ULEB128. If it is
; encoded with LEB128, 64 will not be correctly decoded. 64 is the smallest ; decoded with LEB128, 64 will not be correctly decoded. 64 is the smallest
; number with which its LEB128 and ULEB128 encodings are different, because its ; number with which its LEB128 and ULEB128 encodings are different, because its
; 7th least significant bit is not 0. ; 7th least significant bit is not 0.
; CHECK: - Type: EVENT ; CHECK: - Type: EVENT
; CHECK-NEXT: Events: ; CHECK-NEXT: Events:
; CHECK-NEXT: - Index: 0 ; CHECK-NEXT: - Index: 0
; CHECK-NEXT: Attribute: 0 ; CHECK-NEXT: Attribute: 0
; CHECK-NEXT: SigIndex: 64 ; CHECK-NEXT: SigIndex: 64

llvm/test/MC/WebAssembly/event-section-encoding.ll

  • This file was moved to llvm/test/MC/WebAssembly/event-section-decoding.ll.