Page MenuHomePhabricator

[libc++] Add a CI configuration with static libc++/libc++abi
ClosedPublic

Authored by ldionne on Mar 24 2021, 7:53 AM.

Details

Diff Detail

Event Timeline

ldionne created this revision.Mar 24 2021, 7:53 AM
ldionne requested review of this revision.Mar 24 2021, 7:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 7:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
curdeius added inline comments.
libcxx/utils/ci/run-buildbot
89–90

Does it change anything for other (non-static) test configurations?
IIUC, without installing first, tests would find a possibly different instance of libc++.a (if there's one somewhere in link dirs) or find none, right?
Was it the case with the dynamic lib?

ldionne added inline comments.Mar 24 2021, 8:36 AM
libcxx/utils/ci/run-buildbot
89–90

I don't expect there should be any difference. This is only a cheap way to fix the issue that dependencies are not properly specified with the static library, i.e. check-cxx won't build the static library first when you run it. I looked into solving the underlying issue and it would complicate the CMake quite a bit in the current state of things, so I wanted to start by simplifying the CMake configuration (https://reviews.llvm.org/D97565 will enable that as a follow-up step).

curdeius accepted this revision as: curdeius.Mar 24 2021, 8:42 AM

OK, thanks for the explanation.
LGTM.

ldionne updated this revision to Diff 333081.Mar 24 2021, 12:04 PM

Fix a few issues with the experimental tests.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 24 2021, 1:31 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.