This is an archive of the discontinued LLVM Phabricator instance.

Differential D99258

[OpenCL] Fix AST check in address-space-templates test
ClosedPublic

Authored by Anastasia on Mar 24 2021, 6:12 AM.

Details

Reviewers
bader
Commits
rG6e46f0b62830: [OpenCL] Fix AST check in address-space-templates test
Summary

See comment: https://reviews.llvm.org/D95624#2621226

Diff Detail

Event Timeline

Anastasia created this revision.Mar 24 2021, 6:12 AM
Herald added subscribers: ebevhan, yaxunl. · View Herald TranscriptMar 24 2021, 6:12 AM
Anastasia requested review of this revision.Mar 24 2021, 6:12 AM
Anastasia mentioned this in D95624: [OpenCL][PR48896] Fix default address space in template argument deduction.
bader accepted this revision.Mar 24 2021, 6:20 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 24 2021, 6:20 AM
Harbormaster completed remote builds in B95467: Diff 332954.Mar 24 2021, 11:13 AM
Closed by commit rG6e46f0b62830: [OpenCL] Fix AST check in address-space-templates test (authored by Anastasia). · Explain WhyMar 26 2021, 7:24 AM
This revision was automatically updated to reflect the committed changes.
Anastasia added a commit: rG6e46f0b62830: [OpenCL] Fix AST check in address-space-templates test.
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 7:24 AM
Herald added a subscriber: ldrumm. · View Herald Transcript

Revision Contents

PathSize
clang/
test/
SemaOpenCLCXX/
4 lines

Diff 333551

clang/test/SemaOpenCLCXX/address-space-templates.clcpp

Show All 25 Lines
template <class _Tp> struct remove_reference<_Tp &> { typedef _Tp type; }; template <class _Tp> struct remove_reference<_Tp &> { typedef _Tp type; };
template <class _Tp> struct as_pointer { template <class _Tp> struct as_pointer {
typedef typename remove_reference<_Tp>::type* type; typedef typename remove_reference<_Tp>::type* type;
}; };
// Check address space deduction in template parameter deduction. // Check address space deduction in template parameter deduction.
struct rep { struct rep {
// When there is no address space on a reference use __generic. // When there is no address space on a reference use __generic.
// CHECK: |-CXXConstructorDecl {{.*}} rep 'void (const __generic rep &__private) __generic' // CHECK: |-CXXConstructorDecl {{.*}} rep 'void (const __generic rep &__private){{.*}} __generic'
template<class U, class = typename as_pointer<U>::type> template<class U, class = typename as_pointer<U>::type>
rep(U&& v) {} rep(U&& v) {}
}; };
struct rep_outer : private rep { struct rep_outer : private rep {
rep_outer() rep_outer()
: rep(0) {} : rep(0) {}
}; };
Show All 9 Linesvoid bar() {
foo1<__local int>(1); // expected-error{{no matching function for call to 'foo1'}} foo1<__local int>(1); // expected-error{{no matching function for call to 'foo1'}}
foo2<__global int>(0); foo2<__global int>(0);
foo3<__global int>(); // expected-note{{in instantiation of function template specialization 'foo3<__global int>' requested here}} foo3<__global int>(); // expected-note{{in instantiation of function template specialization 'foo3<__global int>' requested here}}
rep_outer r; rep_outer r;
int i; int i;
// Preserve the address space of the type in forwarding reference. // Preserve the address space of the type in forwarding reference.
// CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int &__private) const __generic' // CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int &__private){{.*}} const __generic'
foo4(i, [](auto&& x){;}); foo4(i, [](auto&& x){;});
} }