Page MenuHomePhabricator

[lld-macho][nfc] minor clean up, follow up to D98559
ClosedPublic

Authored by oontvoo on Mar 23 2021, 12:55 PM.

Diff Detail

Event Timeline

oontvoo created this revision.Mar 23 2021, 12:55 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: mgrang. · View Herald Transcript
oontvoo requested review of this revision.Mar 23 2021, 12:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2021, 12:55 PM
int3 accepted this revision.Mar 23 2021, 1:03 PM

Thanks!

This revision is now accepted and ready to land.Mar 23 2021, 1:03 PM
This revision was landed with ongoing or failed builds.Mar 23 2021, 1:13 PM
This revision was automatically updated to reflect the committed changes.

The test fails on Windows: http://45.33.8.238/win/35613/step_10.txt

PTAL, and please revert for now if it takes a while to fix.

int3 added a comment.Mar 23 2021, 2:18 PM

@oontvoo next time let's wait for the tests to finish before landing, especially if it's something that isn't testable locally

oontvoo reopened this revision.Mar 23 2021, 7:59 PM
This revision is now accepted and ready to land.Mar 23 2021, 7:59 PM
oontvoo updated this revision to Diff 332854.Mar 23 2021, 8:00 PM

Updated path-expectations to accept both backslash and forwardslash.

Will wait and commit this tomorrow.

oontvoo updated this revision to Diff 333376.Mar 25 2021, 11:37 AM

updated diff