Page MenuHomePhabricator

[Docs] Suggest mentioning review page in the commit message
ClosedPublic

Authored by vaivaswatha on Mar 16 2021, 4:21 AM.

Details

Summary

Most commits have a link to the corresponding reviews.llvm.org message. This isn't however mentioned in the developer policy.

Diff Detail

Event Timeline

vaivaswatha requested review of this revision.Mar 16 2021, 4:21 AM
vaivaswatha created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2021, 4:21 AM

Actually, this is mentioned in a different document: https://www.llvm.org/docs/Phabricator.html#committing-a-change

I agree this isn't perfect and I think your change is worth doing. Can you also add a link to the URL above?

Something like "add a link to its review page, as shown in [Phab link]".

Thanks!

Link to Phabricator page that mentions the same topic.

Add missing fullstop.

Actually, this is mentioned in a different document: https://www.llvm.org/docs/Phabricator.html#committing-a-change

I agree this isn't perfect and I think your change is worth doing. Can you also add a link to the URL above?

Something like "add a link to its review page, as shown in [Phab link]".

Thanks!

Thank you @rengolin . I've added this link now.

lattner accepted this revision.Mar 16 2021, 8:53 AM

LGTM thanks!

This revision is now accepted and ready to land.Mar 16 2021, 8:53 AM
This revision was landed with ongoing or failed builds.Mar 16 2021, 10:35 AM
This revision was automatically updated to reflect the committed changes.