This patch is a pre-commit patch for D98423
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
Comment Actions
No, but it seems the testcase didn't pass the CI test becasue the check is not correct. Wroking on that.
Comment Actions
Thanks a lot, I am waiting for the build status. Does it still need anton @anton-afanasyev to review it first? since I have changed the code a lot.
Comment Actions
I believe it is ok to commit. The windows pre-merge failure is not caused by my testcase. It fails because reorder python script failed.
Comment Actions
I've reviewed it, it's ok. Could you please provide the name and email address you would like to use in the Author property of the commit?