This is an archive of the discontinued LLVM Phabricator instance.

Differential D98544

[asan] Ensure SHADOW_OFFSET is kSPARC64_ShadowOffset64 on sparc64 only
AbandonedPublic

Authored by glaubitz on Mar 12 2021, 11:43 AM.

Details

Reviewers
jrtc27
dvyukov
vitalybuka
Summary

Since the compiler defines the sparc macro for both 32- and 64-bit
sparc targets, SHADOW_OFFSET should be defined as kSPARC64_ShadowOffset64
only if SANITIZER_WORDSIZE==64.

Diff Detail

Event Timeline

glaubitz created this revision.Mar 12 2021, 11:43 AM
Herald added subscribers: fedor.sergeev, jyknight. · View Herald TranscriptMar 12 2021, 11:43 AM
glaubitz requested review of this revision.Mar 12 2021, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 11:43 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
glaubitz added a comment.Mar 12 2021, 12:06 PM

I just realized this change isn't necessary and it also doesn't fix my build problem.

glaubitz abandoned this revision.Mar 12 2021, 12:08 PM
Harbormaster completed remote builds in B93573: Diff 330330.Mar 12 2021, 2:10 PM

Revision Contents

PathSize
compiler-rt/
lib/
asan/
2 lines

Diff 330330

compiler-rt/lib/asan/asan_mapping.h

Context not available.
# define SHADOW_OFFSET kDefaultShadowOffset64 # define SHADOW_OFFSET kDefaultShadowOffset64
# elif defined(__mips64) # elif defined(__mips64)
# define SHADOW_OFFSET kMIPS64_ShadowOffset64 # define SHADOW_OFFSET kMIPS64_ShadowOffset64
#elif defined(__sparc__) #elif defined(__sparc__) && SANITIZER_WORDSIZE == 64
#define SHADOW_OFFSET kSPARC64_ShadowOffset64 #define SHADOW_OFFSET kSPARC64_ShadowOffset64
# elif SANITIZER_WINDOWS64 # elif SANITIZER_WINDOWS64
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address # define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
Context not available.