Page MenuHomePhabricator

[lld-macho] minimal TimeTrace support
ClosedPublic

Authored by tschuett on Mar 11 2021, 6:07 AM.

Details

Reviewers
int3
thakis
Group Reviewers
Restricted Project
Commits
rG50c1b21851a1: [lld-macho] minimal TimeTrace support
Summary

This is the minimal port from ELF. Any extension should easy from here

Test plan: ninja check-all-macho

Diff Detail

Event Timeline

tschuett created this revision.Mar 11 2021, 6:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: dang. · View Herald Transcript
tschuett requested review of this revision.Mar 11 2021, 6:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2021, 6:07 AM
tschuett added inline comments.Mar 11 2021, 6:08 AM
lld/MachO/Driver.cpp
783

I add this back in the next iteration.

tschuett updated this revision to Diff 329947.Mar 11 2021, 6:10 AM

blank line

thakis accepted this revision.Mar 11 2021, 6:27 AM
thakis added a subscriber: thakis.

Nice!

lld/MachO/Driver.cpp
948

ELF has just "Link" here, no 2nd arg. Do we need the 2nd arg?

This revision is now accepted and ready to land.Mar 11 2021, 6:27 AM
tschuett added inline comments.Mar 11 2021, 6:29 AM
lld/MachO/Driver.cpp
948

The ELF test checks for ExecuteLinker?!?

This revision was landed with ongoing or failed builds.Mar 11 2021, 6:30 AM
This revision was automatically updated to reflect the committed changes.