[lld-macho] Avoid requiring shell in tests

[int3]

Summary

There are 3 remaining tests that still have REQUIRE: shell:

• color-diagnostics.test -- seems necessary for ANSI escape sequence support
• stabs.s -- the shell part could be removed, but I don't think we can support the test on Windows anyway due to its reliance on touch to set the modtime
• framework.s -- uses symlinks, I'm not sure this works on Windows

Addresses PR49512.

[thakis]

Thanks for the fix! re touch: LLVM requires a whole bunch of unixy utilities for running tests even on Windows. http://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-14.zip contains the ones that are currently needed. touch is among them, so that test should Just Work on Windows – many other tests use touch too.

The other two tests sound mostly fine as-is: The ANSI thing sounds like it might need shell for now (very new versions of windows apparently ship with the new win terminal that has ansi support, but we can't rely on this). For the symlink thing, maybe UNSUPPORTED: system-windows is clearer than REQUIRES: shell if it's for symlinks? But those are both nits.

lld/test/MachO/arm64-relocs.s

-# REQUIRES: aarch64, shell
+# REQUIRES: aarch64
 # RUN: llvm-mc -filetype=obj -triple=arm64-apple-darwin %s -o %t.o
 # RUN: %lld -dylib -arch arm64 -lSystem -o %t %t.o
-# RUN: (llvm-objdump --syms %t; llvm-objdump --macho -d --section=__const %t) | FileCheck %s
+# RUN: llvm-objdump --syms %t > %t.objdump
+# RUN: llvm-objdump --macho -d --section=__const %t >> %t.objdump
+# RUN: FileCheck %s < %t.objdump
 
 # CHECK-LABEL: SYMBOL TABLE:
 # CHECK-DAG:   [[#%x,PTR_1:]] l     O __DATA_CONST,__const _ptr_1
 # CHECK-DAG:   [[#%x,PTR_2:]] l     O __DATA_CONST,__const _ptr_2
 # CHECK-DAG:   [[#%x,BAR:]]   g     F __TEXT,__text _bar
 # CHECK-DAG:   [[#%x,BAZ:]]   g     O __DATA,__data _baz
 
 # CHECK-LABEL: _foo:

lld/test/MachO/dylink-lazy.s

-# REQUIRES: x86, shell
+# REQUIRES: x86
 # RUN: mkdir -p %t
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s \
 # RUN:   -o %t/libhello.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libgoodbye.s \
 # RUN:   -o %t/libgoodbye.o
 # RUN: %lld -dylib \
 # RUN:   -install_name @executable_path/libhello.dylib %t/libhello.o \
 # RUN:   -o %t/libhello.dylib
 # RUN: %lld -dylib \
 # RUN:   -install_name @executable_path/libgoodbye.dylib %t/libgoodbye.o \
 # RUN:   -o %t/libgoodbye.dylib
 
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/dylink-lazy.o
 # RUN: %lld -o %t/dylink-lazy \
 # RUN:   -L%t -lhello -lgoodbye %t/dylink-lazy.o -lSystem
 
 ## When looking at the __stubs section alone, we are unable to easily tell which
 ## symbol each entry points to. So we call objdump twice in order to get the
 ## disassembly of __text and the bind tables first, which allow us to check for
 ## matching entries in __stubs.
-# RUN: (llvm-objdump -d --no-show-raw-insn --syms --rebase --bind --lazy-bind %t/dylink-lazy; \
-# RUN:  llvm-objdump -D --no-show-raw-insn %t/dylink-lazy) | FileCheck %s
+# RUN: llvm-objdump -d --no-show-raw-insn --syms --rebase --bind --lazy-bind %t/dylink-lazy > %t/objdump
+# RUN: llvm-objdump -D --no-show-raw-insn %t/dylink-lazy >> %t/objdump
+# RUN: FileCheck %s < %t/objdump
 
 # RUN: %lld -pie -o %t/dylink-lazy-pie \
 # RUN:   -L%t -lhello -lgoodbye %t/dylink-lazy.o -lSystem
 # RUN: llvm-objdump --macho --rebase %t/dylink-lazy-pie | FileCheck %s --check-prefix=PIE
 
 # CHECK-LABEL: SYMBOL TABLE:
 # CHECK:       {{0*}}[[#%x, IMGLOADER:]] l {{.*}} __DATA,__data __dyld_private
 

lld/test/MachO/function-starts.s

-# REQUIRES: x86, shell
-# UNSUPPORTED: system-windows
+# REQUIRES: x86
 
 # RUN: split-file %s %t
 
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/basic.s -o %t.basic.o
 # RUN: %lld %t.basic.o -o %t.basic
-# RUN: (llvm-objdump --syms %t.basic; llvm-objdump --macho --function-starts %t.basic) | FileCheck %s --check-prefix=BASIC
+# RUN: llvm-objdump --syms %t.basic > %t.objdump
+# RUN: llvm-objdump --macho --function-starts %t.basic >> %t.objdump
+# RUN: FileCheck %s --check-prefix=BASIC < %t.objdump
 
 # BASIC:      SYMBOL TABLE:
 # BASIC-NEXT: [[#%x,MAIN:]] g F __TEXT,__text _main
 # BASIC-NEXT: [[#%x,F1:]] g F __TEXT,__text _f1
 # BASIC-NEXT: [[#%x,F2:]] g F __TEXT,__text _f2
 # BASIC:      [[#MAIN]]
 # BASIC:      [[#F1]]
 # BASIC:      [[#F2]]
 
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/alias.s -o %t.alias.o
 # RUN: %lld %t.alias.o -o %t.alias
-# RUN: (llvm-objdump --syms  %t.alias; llvm-objdump --macho --function-starts %t.alias) | FileCheck %s --check-prefix=ALIAS
+# RUN: llvm-objdump --syms  %t.alias > %t.objdump
+# RUN: llvm-objdump --macho --function-starts %t.alias >> %t.objdump
+# RUN: FileCheck %s --check-prefix=ALIAS < %t.objdump
 
 # ALIAS:      SYMBOL TABLE:
 # ALIAS-NEXT: [[#%x,F2:]] l F __TEXT,__text _f2
 # ALIAS-NEXT: [[#%x,MAIN:]] g F __TEXT,__text _main
 # ALIAS-NEXT: [[#%x,F1:]] g F __TEXT,__text _f1
 # ALIAS:      [[#MAIN]]
 # ALIAS:      [[#F1]]
 

lld/test/MachO/segments.s

-# REQUIRES: x86, shell
+# REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
 # RUN: %lld -o %t %t.o
-# RUN: (llvm-readobj --macho-segment %t; echo "Total file size"; wc -c %t) | FileCheck %s
+# RUN: llvm-readobj --macho-segment %t > %t.out
+# RUN: echo "Total file size" >> %t.out
+# RUN: wc -c %t >> %t.out
+# RUN: FileCheck %s < %t.out
 
 ## These two segments must always be present at the start of an executable.
 # CHECK-NOT:  Segment {
 # CHECK:      Segment {
 # CHECK-NEXT:   Cmd: LC_SEGMENT_64
 # CHECK-NEXT:   Name: __PAGEZERO
 # CHECK-NEXT:   Size: 72
 # CHECK-NEXT:   vmaddr: 0x0