This is an archive of the discontinued LLVM Phabricator instance.

Differential D98271

[Support][test] Unconditionally use setenv macro when compiling on Windows
ClosedPublic

Authored by zero9178 on Mar 9 2021, 10:49 AM.

Details

Reviewers
rnk
mstorsjo
aganea
Commits
rG1956288fbbaf: [Support][test] Unconditionally use setenv macro when compiling on Windows
Summary

This test currently fails to compile when using a MinGW toolchain as setenv is not defined. This function is a POSIX function Windows does not implement.

This patch enables the setenv macro used in the unit test for all of Windows, making the test compile and run successfully.

Diff Detail

Event Timeline

zero9178 requested review of this revision.Mar 9 2021, 10:49 AM
zero9178 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 10:49 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
mstorsjo accepted this revision.Mar 9 2021, 10:51 AM

LGTM

This revision is now accepted and ready to land.Mar 9 2021, 10:51 AM
This revision was landed with ongoing or failed builds.Mar 9 2021, 10:53 AM
Closed by commit rG1956288fbbaf: [Support][test] Unconditionally use setenv macro when compiling on Windows (authored by zero9178). · Explain Why
This revision was automatically updated to reflect the committed changes.
zero9178 added a commit: rG1956288fbbaf: [Support][test] Unconditionally use setenv macro when compiling on Windows.
Harbormaster completed remote builds in B92914: Diff 329387.Mar 9 2021, 10:54 AM

Revision Contents

PathSize
llvm/
unittests/
Support/
2 lines

Diff 329395

llvm/unittests/Support/ThreadPool.cpp

Show First 20 Lines • Show All 234 Lines • ▼ Show 20 Lines
} }
// From TestMain.cpp. // From TestMain.cpp.
extern const char *TestMainArgv0; extern const char *TestMainArgv0;
// Just a reachable symbol to ease resolving of the executable's path. // Just a reachable symbol to ease resolving of the executable's path.
static cl::opt<std::string> ThreadPoolTestStringArg1("thread-pool-string-arg1"); static cl::opt<std::string> ThreadPoolTestStringArg1("thread-pool-string-arg1");
#ifdef _MSC_VER #ifdef _WIN32
#define setenv(name, var, ignore) _putenv_s(name, var) #define setenv(name, var, ignore) _putenv_s(name, var)
#endif #endif
TEST_F(ThreadPoolTest, AffinityMask) { TEST_F(ThreadPoolTest, AffinityMask) {
CHECK_UNSUPPORTED(); CHECK_UNSUPPORTED();
// FIXME: implement AffinityMask in Support/Unix/Program.inc // FIXME: implement AffinityMask in Support/Unix/Program.inc
SKIP_NON_WINDOWS(); SKIP_NON_WINDOWS();
Show All 32 Lines