This is an archive of the discontinued LLVM Phabricator instance.

[test] Fix new CodeGenPrepare test for non-X86 systems
ClosedPublic

Authored by thejh on Mar 4 2021, 7:50 AM.

Details

Summary

The new test llvm/test/Transforms/CodeGenPrepare/remove-assume-block.ll
breaks on non-X86 machines. Change it to look like the existing test
llvm/test/Transforms/CodeGenPrepare/X86/delete-assume-dead-code.ll
to fix it.

Diff Detail

Event Timeline

thejh created this revision.Mar 4 2021, 7:50 AM
thejh requested review of this revision.Mar 4 2021, 7:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2021, 7:50 AM
thejh added a comment.Mar 4 2021, 7:54 AM

Is there a way to force a specific builder (like https://lab.llvm.org/buildbot/#/builders/107) to test a change like this? Or does the change have to be committed before those builders can run on it?

bkramer accepted this revision.Mar 5 2021, 2:48 AM

Is there a way to force a specific builder (like https://lab.llvm.org/buildbot/#/builders/107) to test a change like this? Or does the change have to be committed before those builders can run on it?

Yeah, those builders can't run pre-commit. And the few pre-commit bots we have don't have the non-x86 config.

This revision is now accepted and ready to land.Mar 5 2021, 2:48 AM
This revision was landed with ongoing or failed builds.Mar 5 2021, 2:48 AM
This revision was automatically updated to reflect the committed changes.