This is an archive of the discontinued LLVM Phabricator instance.

[flang] Prohibit MODULE procedures in the global scope
ClosedPublic

Authored by PeteSteinfeld on Mar 3 2021, 10:53 AM.

Details

Summary

We were allowing procedures with the MODULE prefix to be declared at the global
scope. This is prohibited by C1547 and was causing an internal check of the
compiler to fail.

I fixed this by adding a check. I also added a test that would trigger a crash
without this change.

Diff Detail

Event Timeline

PeteSteinfeld requested review of this revision.Mar 3 2021, 10:53 AM
PeteSteinfeld created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2021, 10:53 AM
PeteSteinfeld added a project: Restricted Project.Mar 3 2021, 10:54 AM
klausler accepted this revision.Mar 3 2021, 11:19 AM
This revision is now accepted and ready to land.Mar 3 2021, 11:19 AM
This revision was landed with ongoing or failed builds.Mar 3 2021, 11:51 AM
This revision was automatically updated to reflect the committed changes.