This is an archive of the discontinued LLVM Phabricator instance.

Differential D97796

[test] Fix apparent typo in clang/test/Driver/std.c
ClosedPublic

Authored by DanielMcIntosh-IBM on Mar 2 2021, 12:50 PM.

Details

Reviewers
thakis
Commits
rG9403b59a7dbb: [test] Fix apparent typo in clang/test/Driver/std.c
Summary

Currently the test on line 3 is identical to the test on line 1.
Looking at the rest of the file (particularily the use of FOVERRIDE
as the check-prefix), I think it's pretty clear that this line
was supposed to use -ftrigraphs instead of -trigraphs.

Diff Detail

Event Timeline

DanielMcIntosh-IBM requested review of this revision.Mar 2 2021, 12:50 PM
DanielMcIntosh-IBM created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2021, 12:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B91646: Diff 327549.Mar 2 2021, 3:59 PM
thakis accepted this revision.Mar 2 2021, 4:47 PM

I have no memories of this file, but I agree with your analysis :) Thanks for the fix!

This revision is now accepted and ready to land.Mar 2 2021, 4:47 PM
This revision was landed with ongoing or failed builds.Mar 3 2021, 7:32 AM
Closed by commit rG9403b59a7dbb: [test] Fix apparent typo in clang/test/Driver/std.c (authored by DanielMcIntosh-IBM, committed by abhina.sreeskantharajan). · Explain Why
This revision was automatically updated to reflect the committed changes.
abhina.sreeskantharajan added a commit: rG9403b59a7dbb: [test] Fix apparent typo in clang/test/Driver/std.c.

Revision Contents

PathSize
clang/
test/
Driver/
2 lines

Diff 327796

clang/test/Driver/std.c

// RUN: %clang -w -std=c99 -trigraphs -std=gnu99 %s -E -o - | FileCheck -check-prefix=OVERRIDE %s // RUN: %clang -w -std=c99 -trigraphs -std=gnu99 %s -E -o - | FileCheck -check-prefix=OVERRIDE %s
// OVERRIDE: ??(??) // OVERRIDE: ??(??)
// RUN: %clang -w -std=c99 -trigraphs -std=gnu99 %s -E -o - | FileCheck -check-prefix=FOVERRIDE %s // RUN: %clang -w -std=c99 -ftrigraphs -std=gnu99 %s -E -o - | FileCheck -check-prefix=FOVERRIDE %s
// FOVERRIDE: ??(??) // FOVERRIDE: ??(??)
// RUN: %clang -w -ansi %s -E -o - | FileCheck -check-prefix=ANSI %s // RUN: %clang -w -ansi %s -E -o - | FileCheck -check-prefix=ANSI %s
// ANSI: [] // ANSI: []
// RUN: %clang -w -ansi %s -fno-trigraphs -E -o - | FileCheck -check-prefix=ANSI-OVERRIDE %s // RUN: %clang -w -ansi %s -fno-trigraphs -E -o - | FileCheck -check-prefix=ANSI-OVERRIDE %s
// ANSI-OVERRIDE: ??(??) // ANSI-OVERRIDE: ??(??)
// RUN: %clang -w -std=gnu99 -trigraphs %s -E -o - | FileCheck -check-prefix=EXPLICIT %s // RUN: %clang -w -std=gnu99 -trigraphs %s -E -o - | FileCheck -check-prefix=EXPLICIT %s
// EXPLICIT: [] // EXPLICIT: []
// RUN: %clang -w -std=gnu99 -ftrigraphs %s -E -o - | FileCheck -check-prefix=FEXPLICIT %s // RUN: %clang -w -std=gnu99 -ftrigraphs %s -E -o - | FileCheck -check-prefix=FEXPLICIT %s
// FEXPLICIT: [] // FEXPLICIT: []
// RUN: %clang -w -ftrigraphs -fno-trigraphs %s -E -o - | FileCheck -check-prefix=ONOFF %s // RUN: %clang -w -ftrigraphs -fno-trigraphs %s -E -o - | FileCheck -check-prefix=ONOFF %s
// ONOFF: ??(??) // ONOFF: ??(??)
// RUN: %clang -w -fno-trigraphs -trigraphs %s -E -o - | FileCheck -check-prefix=OFFFON %s // RUN: %clang -w -fno-trigraphs -trigraphs %s -E -o - | FileCheck -check-prefix=OFFFON %s
// OFFFON: [] // OFFFON: []
??(??) ??(??)