Page MenuHomePhabricator

[flang] Runtime: SCAN and VERIFY
ClosedPublic

Authored by klausler on Feb 26 2021, 2:34 PM.

Details

Summary

Implement the related character intrinsic functions
SCAN and VERIFY.

Diff Detail

Event Timeline

klausler created this revision.Feb 26 2021, 2:34 PM
klausler requested review of this revision.Feb 26 2021, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2021, 2:34 PM
jeanPerier accepted this revision.Mar 1 2021, 12:40 AM

Logic looks good to me. Please take care of the Pre-merge checks if they make sense.

flang/runtime/character.cpp
273

Given the logic of the code, the 3 narrowing warnings from clang-tidy do not look harmful to me, but I think it might be worth adding explicit casts/removing the initializer list to avoid compiler warnings here.

305

Is this clang-format warning coming from a clang-format version difference ?

This revision is now accepted and ready to land.Mar 1 2021, 12:40 AM
klausler added inline comments.Mar 1 2021, 8:11 AM
flang/runtime/character.cpp
305

Maybe, but I'm not sure which is the newer one. I use clang-format built from llvm-project/main clang source.

klausler updated this revision to Diff 327122.Mar 1 2021, 8:13 AM

Obey clang-tidy and the version of clang-format used by a bot.

This revision was automatically updated to reflect the committed changes.