This is a part of https://reviews.llvm.org/D95835.
One issue is about origin load optimization: see the
comments of useCallbackLoadLabelAndOrigin
@gbalats This change may have some conflicts with your 8bit change. PTAL the change at visitLoad.
Paths
| Differential D97570
[dfsan] Propagate origin tracking at load ClosedPublic Authored by stephan.yichao.zhao on Feb 26 2021, 12:08 PM.
Details
Summary This is a part of https://reviews.llvm.org/D95835. One issue is about origin load optimization: see the @gbalats This change may have some conflicts with your 8bit change. PTAL the change at visitLoad.
Diff Detail
Unit TestsFailed Event Timeline
stephan.yichao.zhao marked 6 inline comments as done. Comment Actionsupdate
This revision is now accepted and ready to land.Mar 2 2021, 7:46 AM
stephan.yichao.zhao marked an inline comment as done. Comment Actionsupdated test cases to use meta data This revision was landed with ongoing or failed builds.Mar 2 2021, 8:33 PM Closed by commit rGd866b9c99d0a: [dfsan] Propagate origin tracking at load (authored by Jianzhou Zhao <jianzhouzh@google.com>). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 326764 llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
llvm/test/Instrumentation/DataFlowSanitizer/origin_ldst.ll
|
I think it would be cleaner if we retained the older function (with its older return value) and introduced a new one:
loadShadowAndOrigin