Page MenuHomePhabricator

stephan.yichao.zhao
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2020, 11:38 PM (100 w, 2 d)

Recent Activity

Oct 28 2021

stephan.yichao.zhao accepted D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

LGTM. Thank you! will leave this to @MaskRay for the final check.

Oct 28 2021, 8:01 PM · Restricted Project
stephan.yichao.zhao added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

Thank you for testing this.

Oct 28 2021, 8:44 AM · Restricted Project

Oct 27 2021

stephan.yichao.zhao added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

Agreed. Does this change address this patch's issue (ld.lld --plugin-opt=emit-llvm -mllvm -bitcode-flush-threshold=0 -o /dev/null %t.o)?

Can you post a patch? (Patching lld/ELF/LTO.cpp gives me a feeling working around a pitfall which might well hit others, so fixing the source would be nice.)

Oct 27 2021, 9:44 PM · Restricted Project
stephan.yichao.zhao added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

To limit the restriction to only devices-like file, this says character and block types are devices, using LLVM enums, it could be like this around here:

Oct 27 2021, 5:38 PM · Restricted Project
stephan.yichao.zhao added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

Thanks for the pointer. Do you have suggestion on how/where to fix the issue leveraging SupportsSeeking?

Oct 27 2021, 5:30 PM · Restricted Project
stephan.yichao.zhao added a comment to D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output..

Before openLTOOutputFile is called, the output may be non-existent.
Then if (!sys::fs::is_regular_file(file)) will disable the D86905 memory optimization.

Oct 27 2021, 5:00 PM · Restricted Project

Oct 9 2021

stephan.yichao.zhao added a comment to D86905: Flush bitcode incrementally for LTO output.

I didn't notice this was already committed, but numbers are still interesting to go with the change, can you post some here?

Oct 9 2021, 1:09 PM · Restricted Project

Jul 27 2021

stephan.yichao.zhao updated the diff for D106903: [dfsan][NFC] Describe how origin trace tracking works.

typos

Jul 27 2021, 1:21 PM · Restricted Project
stephan.yichao.zhao updated the diff for D106903: [dfsan][NFC] Describe how origin trace tracking works.

tweak

Jul 27 2021, 1:19 PM · Restricted Project
stephan.yichao.zhao updated the diff for D106903: [dfsan][NFC] Describe how origin trace tracking works.

explained what a trace and a chain are.

Jul 27 2021, 1:17 PM · Restricted Project
stephan.yichao.zhao requested review of D106903: [dfsan][NFC] Describe how origin trace tracking works.
Jul 27 2021, 11:58 AM · Restricted Project
stephan.yichao.zhao requested review of D106895: [dfsan][NFC] Update API interfaces.
Jul 27 2021, 10:47 AM · Restricted Project

Jul 26 2021

stephan.yichao.zhao updated the diff for D106833: [dfsan][NFC] Add compile flags and environment variables to doc.

applied comments

Jul 26 2021, 5:18 PM · Restricted Project
stephan.yichao.zhao requested review of D106833: [dfsan][NFC] Add compile flags and environment variables to doc.
Jul 26 2021, 3:27 PM · Restricted Project

Jul 23 2021

stephan.yichao.zhao added inline comments to D106631: [dfsan] Handle more uninstrumented functions.
Jul 23 2021, 1:00 PM · Restricted Project, Unknown Object (Project)

Jul 22 2021

stephan.yichao.zhao added inline comments to D106631: [dfsan] Handle more uninstrumented functions.
Jul 22 2021, 9:09 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao closed D106594: [dfsan] Make warn_unimplemented off by default.

https://github.com/llvm/llvm-project/commit/a806f933a2bf7db444c5687d8d4e07910150ed9c#diff-16afbead86e233f55f648488eae9df30bfd3467147380dfcdeb5a4df0a733905

Jul 22 2021, 3:40 PM · Unknown Object (Project)
stephan.yichao.zhao added a comment to D106195: [dfsan] Add wrappers for v*printf functions.

vfprintf is actually a potential output point, and can be considered as a sink.

It is like __dfsw_write, and needs a callback so that users can decide whether to take this as a sink.

Isn't this the same for fprintf then which is also discarded currently?

Jul 22 2021, 3:01 PM · Unknown Object (Project), Restricted Project
stephan.yichao.zhao added a comment to D106594: [dfsan] Make warn_unimplemented off by default.

This makes issues silent by default.

Jul 22 2021, 2:43 PM · Unknown Object (Project)
stephan.yichao.zhao requested review of D106594: [dfsan] Make warn_unimplemented off by default.
Jul 22 2021, 2:02 PM · Unknown Object (Project)
stephan.yichao.zhao accepted D106195: [dfsan] Add wrappers for v*printf functions.

Please remove vfprintf from the change's description or add a TODO in vfprintf about adding a callback to track it as an output point.

Jul 22 2021, 1:40 PM · Unknown Object (Project), Restricted Project

Jul 21 2021

stephan.yichao.zhao abandoned D96842: [dfsan] Do not specialize vector<bool> for DFSan.
Jul 21 2021, 8:12 PM · Restricted Project
stephan.yichao.zhao abandoned D95835: [dfsan] Support origin tracking.

All changes in this CL were submitted in split CLs.

Jul 21 2021, 8:11 PM · Restricted Project, Unknown Object (Project)

Jul 16 2021

stephan.yichao.zhao added inline comments to D106195: [dfsan] Add wrappers for v*printf functions.
Jul 16 2021, 4:50 PM · Unknown Object (Project), Restricted Project
stephan.yichao.zhao added inline comments to D106195: [dfsan] Add wrappers for v*printf functions.
Jul 16 2021, 4:42 PM · Unknown Object (Project), Restricted Project
stephan.yichao.zhao updated the summary of D106195: [dfsan] Add wrappers for v*printf functions.
Jul 16 2021, 4:15 PM · Unknown Object (Project), Restricted Project
stephan.yichao.zhao added a comment to D106195: [dfsan] Add wrappers for v*printf functions.

vfprintf is actually a potential output point, and can be considered as a sink.

Jul 16 2021, 4:14 PM · Unknown Object (Project), Restricted Project
stephan.yichao.zhao added inline comments to D106195: [dfsan] Add wrappers for v*printf functions.
Jul 16 2021, 4:06 PM · Unknown Object (Project), Restricted Project

Jul 7 2021

stephan.yichao.zhao added a comment to D105378: [dfsan][NFC] Add Origin Tracking into doc.

We may also want to consider creating a frontend flag like MSan's origin tracking (-fsanitize-memory-track-origins).

Jul 7 2021, 11:18 AM · Restricted Project
stephan.yichao.zhao updated the diff for D105378: [dfsan][NFC] Add Origin Tracking into doc.

clang -> clange++

Jul 7 2021, 11:08 AM · Restricted Project

Jul 2 2021

stephan.yichao.zhao requested review of D105378: [dfsan][NFC] Add Origin Tracking into doc.
Jul 2 2021, 3:20 PM · Restricted Project

Jun 29 2021

stephan.yichao.zhao added inline comments to D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.
Jun 29 2021, 12:44 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao updated the diff for D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.

Added more comments to dfsan_get_track_origins.

Jun 29 2021, 12:43 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao updated the diff for D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.

update

Jun 29 2021, 9:33 AM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao updated the diff for D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.

added a missing file

Jun 29 2021, 9:31 AM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao requested review of D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.
Jun 29 2021, 8:35 AM · Restricted Project, Unknown Object (Project)

Jun 25 2021

stephan.yichao.zhao accepted D104896: [DFSan] Change shadow and origin memory layouts to match MSan..
Jun 25 2021, 2:45 PM · Restricted Project, Unknown Object (Project), Restricted Project
stephan.yichao.zhao added a comment to D104896: [DFSan] Change shadow and origin memory layouts to match MSan..

Thank you for making this work!

Jun 25 2021, 10:27 AM · Restricted Project, Unknown Object (Project), Restricted Project
stephan.yichao.zhao added inline comments to D104896: [DFSan] Change shadow and origin memory layouts to match MSan..
Jun 25 2021, 9:40 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 18 2021

stephan.yichao.zhao accepted D104568: [libfuzzer] Disable failing DFSan-related tests.
Jun 18 2021, 2:38 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao accepted D104565: [DFSan][NFC] Refactor Origin Address Alignment code..

Thank you for the refactoring.

Jun 18 2021, 1:56 PM · Unknown Object (Project)

Jun 17 2021

stephan.yichao.zhao accepted D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix.
Jun 17 2021, 5:38 PM · Restricted Project, Restricted Project, Unknown Object (Project)
stephan.yichao.zhao accepted D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..
Jun 17 2021, 5:04 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added inline comments to D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix.
Jun 17 2021, 5:02 PM · Restricted Project, Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added a comment to rG39295e92f7f9: Revert "[DFSan] Cleanup code for platforms other than Linux x86_64.".

Did anyone use mips64 or aarch64...?

Jun 17 2021, 2:49 PM
stephan.yichao.zhao accepted D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..
Jun 17 2021, 12:40 PM · Restricted Project, Unknown Object (Project)

Jun 15 2021

stephan.yichao.zhao accepted D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 15 2021, 6:14 PM · Restricted Project
stephan.yichao.zhao added inline comments to D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 15 2021, 2:39 PM · Restricted Project
stephan.yichao.zhao added inline comments to D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 15 2021, 1:58 PM · Restricted Project

Jun 14 2021

stephan.yichao.zhao updated subscribers of D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 14 2021, 3:29 PM · Restricted Project
stephan.yichao.zhao accepted D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Jun 14 2021, 12:59 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added inline comments to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Jun 14 2021, 9:40 AM · Restricted Project, Unknown Object (Project)

Jun 12 2021

stephan.yichao.zhao added inline comments to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Jun 12 2021, 7:00 PM · Restricted Project, Unknown Object (Project)

Jun 11 2021

stephan.yichao.zhao added inline comments to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Jun 11 2021, 6:56 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added a comment to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.

why __sanitizer_print_stack_trace is not enough?

Jun 11 2021, 6:40 PM · Restricted Project, Unknown Object (Project)

Jun 7 2021

stephan.yichao.zhao accepted D103745: [dfsan] Add full fast8 support.
Jun 7 2021, 2:21 PM · Restricted Project, Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added a comment to D103745: [dfsan] Add full fast8 support.

How did we fix that alignment error from compiler-rt/test/dfsan/origin_ldst.c?

Jun 7 2021, 9:42 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 6 2021

stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

added a missing test case

Jun 6 2021, 1:59 PM · Unknown Object (Project)

Jun 5 2021

stephan.yichao.zhao added inline comments to D103745: [dfsan] Add full fast8 support.
Jun 5 2021, 8:45 AM · Restricted Project, Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added a comment to D103745: [dfsan] Add full fast8 support.

The failed test cases from x64 debian > libFuzzer.libFuzzer::* seem related. They still use -dfsan-fast-16-labels.

Jun 5 2021, 8:11 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 2 2021

stephan.yichao.zhao accepted D103542: Fix dfsan handling of musttail calls..
Jun 2 2021, 11:33 AM · Restricted Project
stephan.yichao.zhao updated subscribers of D103542: Fix dfsan handling of musttail calls..
Jun 2 2021, 11:10 AM · Restricted Project

May 27 2021

stephan.yichao.zhao updated the diff for D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.

update

May 27 2021, 4:34 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added inline comments to D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.
May 27 2021, 4:31 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao updated the diff for D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.

update

May 27 2021, 4:31 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao updated the diff for D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.

update

May 27 2021, 1:35 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added inline comments to D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.
May 27 2021, 11:21 AM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao updated the diff for D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.

switched back from option set to individual options.

May 27 2021, 11:19 AM · Restricted Project, Unknown Object (Project)

May 26 2021

stephan.yichao.zhao requested review of D103176: [dfsan] Add a flag about whether to propagate offset labels at gep.
May 26 2021, 8:57 AM · Restricted Project, Unknown Object (Project)

May 21 2021

stephan.yichao.zhao accepted D102451: [dfsan] Add function that prints origin stack trace to buffer.
May 21 2021, 2:11 PM · Restricted Project, Unknown Object (Project)
stephan.yichao.zhao added inline comments to D102451: [dfsan] Add function that prints origin stack trace to buffer.
May 21 2021, 12:13 PM · Restricted Project, Unknown Object (Project)

May 20 2021

stephan.yichao.zhao accepted D102898: [sanitizer_common] Remove unused var in test.
May 20 2021, 8:39 PM · Restricted Project, Unknown Object (Project)

May 19 2021

stephan.yichao.zhao accepted D102815: [sanitizer_common] Add StackTrace::PrintTo method.
May 19 2021, 4:33 PM · Restricted Project, Unknown Object (Project)

May 13 2021

stephan.yichao.zhao added a comment to D102451: [dfsan] Add function that prints origin stack trace to buffer.

Please split the sanitizer common change in a separate CL.

May 13 2021, 4:28 PM · Restricted Project, Unknown Object (Project)

May 12 2021

stephan.yichao.zhao added inline comments to D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.
May 12 2021, 3:06 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

update

May 12 2021, 3:05 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

update

May 12 2021, 3:03 PM · Unknown Object (Project)

May 11 2021

stephan.yichao.zhao added a comment to D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

ping

May 11 2021, 4:39 PM · Unknown Object (Project)

May 6 2021

stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

update

May 6 2021, 6:05 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

update

May 6 2021, 6:03 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

rebased after D101649

May 6 2021, 6:02 PM · Unknown Object (Project)
stephan.yichao.zhao added a comment to D101649: [dfsan] Rename and fix an internal test issue for mmap+calloc.

Change is fine with me, though I wish we understood why it's needed.

May 6 2021, 5:57 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101649: [dfsan] Rename and fix an internal test issue for mmap+calloc.

added comments

May 6 2021, 5:57 PM · Unknown Object (Project)
stephan.yichao.zhao updated the summary of D101649: [dfsan] Rename and fix an internal test issue for mmap+calloc.
May 6 2021, 5:54 PM · Unknown Object (Project)

May 5 2021

stephan.yichao.zhao added a comment to D101649: [dfsan] Rename and fix an internal test issue for mmap+calloc.

ping

May 5 2021, 5:25 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

rebased after D101877

May 5 2021, 5:24 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

update

May 5 2021, 9:21 AM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101204: [dfsan] Use the sanitizer allocator to reduce memory cost.

rebased after D101666

May 5 2021, 9:18 AM · Unknown Object (Project)

May 4 2021

stephan.yichao.zhao added inline comments to D101666: [dfsan] Add a DFSan allocator.
May 4 2021, 6:18 PM · Unknown Object (Project)
stephan.yichao.zhao requested review of D101877: [dfsan] extend a test case to measure origin memory usage.
May 4 2021, 5:55 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101666: [dfsan] Add a DFSan allocator.

update

May 4 2021, 5:50 PM · Unknown Object (Project)
stephan.yichao.zhao added inline comments to D101666: [dfsan] Add a DFSan allocator.
May 4 2021, 4:15 PM · Unknown Object (Project)
stephan.yichao.zhao requested review of D101857: [dfsan] move dfsan_flags.h to cc files.
May 4 2021, 2:20 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101666: [dfsan] Add a DFSan allocator.

update

May 4 2021, 2:17 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101666: [dfsan] Add a DFSan allocator.

update

May 4 2021, 2:14 PM · Unknown Object (Project)
stephan.yichao.zhao updated the diff for D101666: [dfsan] Add a DFSan allocator.

update

May 4 2021, 2:07 PM · Unknown Object (Project)
stephan.yichao.zhao added inline comments to D101666: [dfsan] Add a DFSan allocator.
May 4 2021, 2:07 PM · Unknown Object (Project)

May 3 2021

stephan.yichao.zhao updated the diff for D101666: [dfsan] Add a DFSan allocator.

update

May 3 2021, 4:28 PM · Unknown Object (Project)
stephan.yichao.zhao added inline comments to D101666: [dfsan] Add a DFSan allocator.
May 3 2021, 4:28 PM · Restricted Project
stephan.yichao.zhao added inline comments to D101649: [dfsan] Rename and fix an internal test issue for mmap+calloc.
May 3 2021, 12:10 PM · Restricted Project