Page MenuHomePhabricator
People stephan.yichao.zhao

stephan.yichao.zhao
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2020, 11:38 PM (36 w, 4 h)

Recent Activity
View All

Wed, Mar 31

stephan.yichao.zhao requested review of D99678: [dfsan] Set sigemptyset's return label to be 0.
Wed, Mar 31, 12:47 PM · Restricted Project

Wed, Mar 24

stephan.yichao.zhao requested review of D99295: [dfsan] Test dfsan_flush with origins.
Wed, Mar 24, 1:24 PM · Restricted Project
stephan.yichao.zhao updated the diff for D98966: [dfsan] Add Origin ABI Wrappers.

updated after rebase

Wed, Mar 24, 11:21 AM · Restricted Project
stephan.yichao.zhao updated the diff for D98966: [dfsan] Add Origin ABI Wrappers.

rebased after D99109
fixed format

Wed, Mar 24, 10:00 AM · Restricted Project
stephan.yichao.zhao closed D99109: [dfsan] Add Origin ABI Wrappers.

submitted by https://github.com/llvm/llvm-project/commit/91516925ddab3d364648aa5c94b6d29e47e56254

Wed, Mar 24, 9:15 AM · Restricted Project

Tue, Mar 23

stephan.yichao.zhao added a comment to D98966: [dfsan] Add Origin ABI Wrappers.

@morehouse: ping

Tue, Mar 23, 6:04 PM · Restricted Project

Mon, Mar 22

stephan.yichao.zhao added inline comments to D99109: [dfsan] Add Origin ABI Wrappers.
Mon, Mar 22, 5:45 PM · Restricted Project
stephan.yichao.zhao updated the diff for D99109: [dfsan] Add Origin ABI Wrappers.

update

Mon, Mar 22, 5:44 PM · Restricted Project
stephan.yichao.zhao updated the summary of D99109: [dfsan] Add Origin ABI Wrappers.
Mon, Mar 22, 5:44 PM · Restricted Project
stephan.yichao.zhao requested review of D99109: [dfsan] Add Origin ABI Wrappers.
Mon, Mar 22, 2:15 PM · Restricted Project

Fri, Mar 19

stephan.yichao.zhao requested review of D98966: [dfsan] Add Origin ABI Wrappers.
Fri, Mar 19, 10:29 AM · Restricted Project

Thu, Mar 18

stephan.yichao.zhao accepted D98734: [dfsan] Add -dfsan-fast-8-labels flag.
Thu, Mar 18, 3:25 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D98734: [dfsan] Add -dfsan-fast-8-labels flag.
Thu, Mar 18, 3:25 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D98734: [dfsan] Add -dfsan-fast-8-labels flag.
Thu, Mar 18, 1:40 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D98734: [dfsan] Add -dfsan-fast-8-labels flag.
Thu, Mar 18, 12:43 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98790: [dfsan] Add origin ABI wrappers.

turned on testing strncpy

Thu, Mar 18, 11:34 AM · Restricted Project
stephan.yichao.zhao updated the diff for D98790: [dfsan] Add origin ABI wrappers.

turned on testing strncpy

Thu, Mar 18, 11:33 AM · Restricted Project
stephan.yichao.zhao updated the diff for D98790: [dfsan] Add origin ABI wrappers.

updated

Thu, Mar 18, 11:00 AM · Restricted Project
stephan.yichao.zhao added inline comments to D98790: [dfsan] Add origin ABI wrappers.
Thu, Mar 18, 11:00 AM · Restricted Project

Wed, Mar 17

stephan.yichao.zhao added inline comments to D98734: [dfsan] Add -dfsan-fast-8-labels flag.
Wed, Mar 17, 1:28 PM · Restricted Project, Restricted Project
stephan.yichao.zhao requested review of D98790: [dfsan] Add origin ABI wrappers.
Wed, Mar 17, 9:26 AM · Restricted Project

Tue, Mar 16

stephan.yichao.zhao added inline comments to D98734: [dfsan] Add -dfsan-fast-8-labels flag.
Tue, Mar 16, 7:21 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98636: [dfsan] Add origin ABI wrappers.

refactored code

Tue, Mar 16, 11:24 AM · Restricted Project
stephan.yichao.zhao added inline comments to D98636: [dfsan] Add origin ABI wrappers.
Tue, Mar 16, 11:24 AM · Restricted Project

Mon, Mar 15

stephan.yichao.zhao added inline comments to D98636: [dfsan] Add origin ABI wrappers.
Mon, Mar 15, 3:30 PM · Restricted Project
stephan.yichao.zhao updated the diff for D98636: [dfsan] Add origin ABI wrappers.

updated

Mon, Mar 15, 3:29 PM · Restricted Project
stephan.yichao.zhao added a comment to rG2fcd872d8a9c: [dfsan] Remove dfsan_get_origin from done_abilist.txt.

I need to fix this: https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/dfsan/scripts/check_custom_wrappers.sh#L23

Mon, Mar 15, 11:51 AM
stephan.yichao.zhao added a comment to rG2fcd872d8a9c: [dfsan] Remove dfsan_get_origin from done_abilist.txt.

https://reviews.llvm.org/D98359#change-BvukghiAat3C added __dfsw_dfsan_get_origin, but the latest build still has warnings like the following... Do we need to change any other things?
This dfsan_get_origin wrapper is similar to dfsan_get_label. They are different from others that they are defined in dfsan.cpp but not dfsan_custom.cpp. But I did not see any special code about dfsan_get_label.

Mon, Mar 15, 10:25 AM
stephan.yichao.zhao requested review of D98636: [dfsan] Add origin ABI wrappers.
Mon, Mar 15, 9:24 AM · Restricted Project

Fri, Mar 12

stephan.yichao.zhao updated the diff for D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.

addressed comments

Fri, Mar 12, 3:27 PM · Restricted Project
stephan.yichao.zhao added inline comments to D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.
Fri, Mar 12, 3:27 PM · Restricted Project
stephan.yichao.zhao updated the diff for D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.

update

Fri, Mar 12, 10:37 AM · Restricted Project
stephan.yichao.zhao updated the diff for D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.

updated

Fri, Mar 12, 10:35 AM · Restricted Project
stephan.yichao.zhao added inline comments to D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.
Fri, Mar 12, 10:35 AM · Restricted Project

Mar 11 2021

stephan.yichao.zhao updated the diff for D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.

merged test cases to dedup same code.

Mar 11 2021, 6:16 PM · Restricted Project
stephan.yichao.zhao added inline comments to D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.
Mar 11 2021, 6:15 PM · Restricted Project
stephan.yichao.zhao accepted D98454: [dfsan] Update shadow-args-zext.ll test.
Mar 11 2021, 5:19 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.

disabled testing on non-x86-64 CPUs

Mar 11 2021, 1:30 PM · Restricted Project
stephan.yichao.zhao added a comment to D95835: [dfsan] Support origin tracking.
In D95835#2619071, @ostannard wrote:

Many of the tests added here are failing on the AArch64 buildbots (e.g. http://lab.llvm.org:8011/#/builders/7/builds/1974). Is this expected to work on AArch64, or should these tests be disabled for those bots?

Mar 11 2021, 9:48 AM · Restricted Project, Restricted Project

Mar 10 2021

stephan.yichao.zhao accepted D98376: [dfsan] Update atomics.ll test.

Thank you for simplifying the test cases.

Mar 10 2021, 4:23 PM · Restricted Project, Restricted Project
stephan.yichao.zhao accepted D98308: [dfsan] Update fast16labels.ll test.
Mar 10 2021, 12:03 PM · Restricted Project, Restricted Project
stephan.yichao.zhao requested review of D98359: [dfsan] Add origin ABI wrappers for thread/signal/fork.
Mar 10 2021, 9:06 AM · Restricted Project

Mar 9 2021

stephan.yichao.zhao added inline comments to D98308: [dfsan] Update fast16labels.ll test.
Mar 9 2021, 6:16 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D98308: [dfsan] Update fast16labels.ll test.
Mar 9 2021, 5:27 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98268: [dfsan] Tracking origins at phi nodes.

added a compiler-rt test

Mar 9 2021, 3:14 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98268: [dfsan] Tracking origins at phi nodes.

used range loops

Mar 9 2021, 2:27 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D98268: [dfsan] Tracking origins at phi nodes.
Mar 9 2021, 2:27 PM · Restricted Project, Restricted Project
stephan.yichao.zhao requested review of D98268: [dfsan] Tracking origins at phi nodes.
Mar 9 2021, 9:14 AM · Restricted Project, Restricted Project

Mar 8 2021

stephan.yichao.zhao accepted D98227: [dfsan] Update store.ll test.

Thank you for simplifying the tests.

Mar 8 2021, 7:51 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D98192: [dfsan] Tracking origins at memory transfer.
Mar 8 2021, 11:40 AM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98192: [dfsan] Tracking origins at memory transfer.

made origin_memmove.c use aligned addresses

Mar 8 2021, 11:39 AM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D98192: [dfsan] Tracking origins at memory transfer.

initialized variables
added missing stacks for fn_g

Mar 8 2021, 11:29 AM · Restricted Project, Restricted Project
stephan.yichao.zhao requested review of D98192: [dfsan] Tracking origins at memory transfer.
Mar 8 2021, 9:15 AM · Restricted Project, Restricted Project

Mar 5 2021

stephan.yichao.zhao accepted rG2fcd872d8a9c: [dfsan] Remove dfsan_get_origin from done_abilist.txt.
Mar 5 2021, 6:56 PM
stephan.yichao.zhao added a comment to rG2fcd872d8a9c: [dfsan] Remove dfsan_get_origin from done_abilist.txt.

This one is similar to dfsan_get_label (https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/dfsan/dfsan.cpp#L693-L717).
But it needs only dfso_ for a wrapper that returns origin tracking info, but does not need a dfsw_ because a __dfsw_ wrapper always returns shadow label.

Mar 5 2021, 6:55 PM
stephan.yichao.zhao accepted D98090: [dfsan] Remove hardcoded shadow width in struct.ll.
Mar 5 2021, 6:40 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added a comment to rG2fcd872d8a9c: [dfsan] Remove dfsan_get_origin from done_abilist.txt.

Does this break any test cases? Why do we need to remove this ABI wrapper?

Mar 5 2021, 6:16 PM
stephan.yichao.zhao added inline comments to D97962: [dfsan] Add utils to get and print origin paths and some test cases.
Mar 5 2021, 3:34 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97962: [dfsan] Add utils to get and print origin paths and some test cases.

addressed comments.

Mar 5 2021, 3:34 PM · Restricted Project

Mar 4 2021

stephan.yichao.zhao accepted D97988: [dfsan] Remove hardcoded shadow width in array.ll.
Mar 4 2021, 5:09 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97962: [dfsan] Add utils to get and print origin paths and some test cases.
Mar 4 2021, 4:18 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97962: [dfsan] Add utils to get and print origin paths and some test cases.

simplified the loop in dfsan_get_init_origin

Mar 4 2021, 4:18 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97962: [dfsan] Add utils to get and print origin paths and some test cases.

addressed comments

Mar 4 2021, 3:55 PM · Restricted Project
stephan.yichao.zhao added inline comments to D97962: [dfsan] Add utils to get and print origin paths and some test cases.
Mar 4 2021, 3:55 PM · Restricted Project
stephan.yichao.zhao added inline comments to D97962: [dfsan] Add utils to get and print origin paths and some test cases.
Mar 4 2021, 3:54 PM · Restricted Project
stephan.yichao.zhao added inline comments to D97789: [dfsan] Propagate origin tracking at store.
Mar 4 2021, 2:11 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97789: [dfsan] Propagate origin tracking at store.

update test cases

Mar 4 2021, 2:11 PM · Restricted Project
stephan.yichao.zhao accepted D97903: [dfsan] Increase coverage of vector and select tests.
Mar 4 2021, 11:49 AM · Restricted Project, Restricted Project
stephan.yichao.zhao requested review of D97962: [dfsan] Add utils to get and print origin paths and some test cases.
Mar 4 2021, 8:57 AM · Restricted Project

Mar 3 2021

stephan.yichao.zhao added inline comments to D97903: [dfsan] Increase coverage of vector and select tests.
Mar 3 2021, 7:44 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97789: [dfsan] Propagate origin tracking at store.
Mar 3 2021, 4:29 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97789: [dfsan] Propagate origin tracking at store.

update test cases

Mar 3 2021, 4:28 PM · Restricted Project
stephan.yichao.zhao accepted D97884: [dfsan] Remove hard-coded shadow width in more tests.
Mar 3 2021, 2:39 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97884: [dfsan] Remove hard-coded shadow width in more tests.
Mar 3 2021, 2:32 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97884: [dfsan] Remove hard-coded shadow width in more tests.
Mar 3 2021, 2:13 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D97789: [dfsan] Propagate origin tracking at store.

update

Mar 3 2021, 12:17 PM · Restricted Project
stephan.yichao.zhao added a comment to D97789: [dfsan] Propagate origin tracking at store.
In D97789#2600830, @morehouse wrote:

How many patches are left for origin tracking?

When can we start adding end-to-end tests in compiler-rt?

Mar 3 2021, 12:16 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97789: [dfsan] Propagate origin tracking at store.

rebase

Mar 3 2021, 9:44 AM · Restricted Project

Mar 2 2021

stephan.yichao.zhao updated the diff for D97570: [dfsan] Propagate origin tracking at load.

updated test cases

Mar 2 2021, 8:29 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97570: [dfsan] Propagate origin tracking at load.

updated test cases

Mar 2 2021, 1:56 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97789: [dfsan] Propagate origin tracking at store.

update tests cases

Mar 2 2021, 1:54 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97570: [dfsan] Propagate origin tracking at load.

updated test cases to use meta data

Mar 2 2021, 1:46 PM · Restricted Project
stephan.yichao.zhao requested review of D97789: [dfsan] Propagate origin tracking at store.
Mar 2 2021, 11:01 AM · Restricted Project

Mar 1 2021

stephan.yichao.zhao added inline comments to D97570: [dfsan] Propagate origin tracking at load.
Mar 1 2021, 5:06 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97570: [dfsan] Propagate origin tracking at load.

update

Mar 1 2021, 5:06 PM · Restricted Project
stephan.yichao.zhao accepted D97723: [dfsan] Remove hardcoded shadow width in abilist_aggregate.ll.
Mar 1 2021, 2:57 PM · Restricted Project, Restricted Project
stephan.yichao.zhao accepted D97714: [dfsan] Fix clang-tidy warnings.

Thank you!

Mar 1 2021, 2:46 PM · Restricted Project, Restricted Project

Feb 26 2021

stephan.yichao.zhao requested review of D97593: [msan] Use non-transparent-huge-page at SetShadow.
Feb 26 2021, 3:36 PM · Restricted Project
stephan.yichao.zhao requested review of D97570: [dfsan] Propagate origin tracking at load.
Feb 26 2021, 12:08 PM · Restricted Project
stephan.yichao.zhao updated the diff for D97483: [dfsan] Propagate origins for callsites.

addressed comments; fixed lint

Feb 26 2021, 10:16 AM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97483: [dfsan] Propagate origins for callsites.
Feb 26 2021, 10:16 AM · Restricted Project, Restricted Project

Feb 25 2021

stephan.yichao.zhao updated the diff for D97310: [dfsan] Conservative solution to atomic load/store.

added comments to RMW and ChmpXchg.

Feb 25 2021, 2:40 PM · Restricted Project, Restricted Project
stephan.yichao.zhao requested review of D97483: [dfsan] Propagate origins for callsites.
Feb 25 2021, 9:12 AM · Restricted Project, Restricted Project

Feb 24 2021

stephan.yichao.zhao added a comment to D96842: [dfsan] Do not specialize vector<bool> for DFSan.
In D96842#2569364, @ldionne wrote:

... If so, I'll send a review to fix this. I'm a bit surprised ubsan doesn't catch that, but I guess ubsan isn't a silver bullet.

Feb 24 2021, 4:25 PM · Restricted Project
stephan.yichao.zhao accepted D97409: [dfsan] Record dfsan metadata in globals.
Feb 24 2021, 3:51 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97409: [dfsan] Record dfsan metadata in globals.
Feb 24 2021, 3:28 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D97310: [dfsan] Conservative solution to atomic load/store.

added TODO

Feb 24 2021, 3:21 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated subscribers of D97310: [dfsan] Conservative solution to atomic load/store.
Feb 24 2021, 2:28 PM · Restricted Project, Restricted Project
stephan.yichao.zhao updated the diff for D97310: [dfsan] Conservative solution to atomic load/store.

update

Feb 24 2021, 2:28 PM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D97409: [dfsan] Record dfsan metadata in globals.
Feb 24 2021, 2:00 PM · Restricted Project, Restricted Project