Page MenuHomePhabricator

[NFC] Add x86_amx and some missed half, bfloat keywords to llvm plugin syntaxes
ClosedPublic

Authored by pengfei on Feb 24 2021, 11:18 PM.

Diff Detail

Event Timeline

pengfei requested review of this revision.Feb 24 2021, 11:18 PM
pengfei created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 11:18 PM
craig.topper added inline comments.Feb 25 2021, 11:58 AM
llvm/utils/llvm.grm
195

This is also missing half and bfloat. Do you mind fixing that too?

pengfei updated this revision to Diff 326567.Feb 25 2021, 5:50 PM
pengfei marked an inline comment as done.

Address Craig's comment. Adding missed half and bfloat too.

pengfei retitled this revision from [X86] Add x86_amx keyword to llvm plugin syntaxes. NFC to [NFC] Add x86_amx and some missed half, bfloat keywords to llvm plugin syntaxes.Feb 25 2021, 5:50 PM

It seems half is already support in the vim plugin. So may remove half from the commit message.

It seems half is already support in the vim plugin. So may remove half from the commit message.

It's still missing in llvm.grm.

LuoYuanke accepted this revision.Mar 2 2021, 3:46 AM

LGTM.

This revision is now accepted and ready to land.Mar 2 2021, 3:46 AM