This is an archive of the discontinued LLVM Phabricator instance.

Differential D97423

Fix a test case that checks should check whether or not it is passed into lld
ClosedPublic

Authored by Conanap on Feb 24 2021, 3:59 PM.

Details

Reviewers
yaxunl
nemanjai
saghir
Group Reviewers
Restricted Project
Commits
rG3b7104a2f203: Fix a test case that should check whether or not it is passed into lld
Summary

This test case was causing a PowerPC buildbot to fail as it happened to be named lld-multistage, which matches with the original regex and therefore fails the check-not. This should better represent the desired check.

Original differential: https://reviews.llvm.org/D96835

Diff Detail

Event Timeline

Conanap created this revision.Feb 24 2021, 3:59 PM
Herald added a subscriber: steven.zhang. · View Herald TranscriptFeb 24 2021, 3:59 PM
Conanap requested review of this revision.Feb 24 2021, 3:59 PM
Conanap mentioned this in D96835: [HIP] Support device sanitizer.
yaxunl added inline comments.Feb 24 2021, 4:16 PM
clang/test/Driver/hip-sanitize-options.hip
29

this may fail on windows since lld becomes lld.exe

yaxunl added inline comments.Feb 24 2021, 4:39 PM
clang/test/Driver/hip-sanitize-options.hip
29

may be change to

{{"[^"]*lld[^"]*".* "-plugin-opt=.* ".*hip.bc"}}

similar as below

Harbormaster completed remote builds in B90703: Diff 326227.Feb 24 2021, 7:24 PM
Conanap updated this revision to Diff 326311.Feb 25 2021, 12:29 AM
Conanap marked 2 inline comments as done.

Added .exe check for windows

clang/test/Driver/hip-sanitize-options.hip
29

Should be fixed now

Harbormaster completed remote builds in B90766: Diff 326311.Feb 25 2021, 1:17 AM
yaxunl accepted this revision.Feb 25 2021, 5:42 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Feb 25 2021, 5:42 AM
This revision was landed with ongoing or failed builds.Feb 25 2021, 7:32 AM
Closed by commit rG3b7104a2f203: Fix a test case that should check whether or not it is passed into lld (authored by Conanap). · Explain Why
This revision was automatically updated to reflect the committed changes.
Conanap added a commit: rG3b7104a2f203: Fix a test case that should check whether or not it is passed into lld.

Revision Contents

PathSize
clang/
test/
Driver/
6 lines

Diff 326387

clang/test/Driver/hip-sanitize-options.hip

Show All 20 Lines
// RUN: %s 2>&1 | FileCheck -check-prefixes=RDC %s // RUN: %s 2>&1 | FileCheck -check-prefixes=RDC %s
// RUN: %clang -### -target x86_64-unknown-linux-gnu --offload-arch=gfx900 \ // RUN: %clang -### -target x86_64-unknown-linux-gnu --offload-arch=gfx900 \
// RUN: -fsanitize=address -fgpu-sanitize \ // RUN: -fsanitize=address -fgpu-sanitize \
// RUN: -nogpuinc --rocm-path=%S/Inputs/rocm-invalid \ // RUN: -nogpuinc --rocm-path=%S/Inputs/rocm-invalid \
// RUN: %s 2>&1 | FileCheck -check-prefixes=FAIL %s // RUN: %s 2>&1 | FileCheck -check-prefixes=FAIL %s
// CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}} // CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}}
// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}} // CHECK-NOT: {{"[^"]*lld(\.exe){0,1}".* ".*hip.bc"}}
yaxunlUnsubmitted
Done
ReplyInline Actions

this may fail on windows since lld becomes lld.exe

yaxunl: this may fail on windows since lld becomes lld.exe
yaxunlUnsubmitted
Done
ReplyInline Actions

may be change to

{{"[^"]*lld[^"]*".* "-plugin-opt=.* ".*hip.bc"}}

similar as below

yaxunl: may be change to ``` {{"[^"]*lld[^"]*".* "-plugin-opt=.* ".*hip.bc"}} ``` similar as below
ConanapAuthorUnsubmitted
Done
ReplyInline Actions

Should be fixed now

Conanap: Should be fixed now
// CHECK: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}} // CHECK: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
// NORDC: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]" // NORDC: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]"
// NORDC: {{"[^"]*lld[^"]*".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}} // NORDC: {{"[^"]*lld(\.exe){0,1}".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
// NORDC: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}} // NORDC: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
// RDC: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}} // RDC: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
// RDC: {{"[^"]*clang[^"]*".* "-emit-llvm-bc".* "-fcuda-is-device".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]" // RDC: {{"[^"]*clang[^"]*".* "-emit-llvm-bc".* "-fcuda-is-device".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]"
// RDC: {{"[^"]*lld[^"]*".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}} // RDC: {{"[^"]*lld(\.exe){0,1}".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
// FAIL: AMDGPU address sanitizer runtime library (asanrtl) is not found. Please install ROCm device library which supports address sanitizer // FAIL: AMDGPU address sanitizer runtime library (asanrtl) is not found. Please install ROCm device library which supports address sanitizer