Page MenuHomePhabricator

[clang][cli] Remove marshalling from Opt{In,Out}FFlag
ClosedPublic

Authored by jansvoboda11 on Feb 24 2021, 2:30 AM.

Details

Summary

We can now express all marshalling semantics in Opt{In,Out}FFlag via BoolFOption.

This patch moves remaining Opt{In,Out}FFlag instances using marshalling to BoolFOption and removes marshalling capabilities from Opt{In,Out}FFlag entirely.

This simplifies the decisions developers have to make when creating new boolean options:

  • For simple cc1 flag pairs, use Bool{,F,G}Option.
  • For cc1 flag pairs that require complex marshalling logic, use Opt{In,Out}FFlag and implement marshalling manually.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Feb 24 2021, 2:30 AM
jansvoboda11 requested review of this revision.Feb 24 2021, 2:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 2:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Feb 24 2021, 7:41 AM