This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP] -fopenmp enables OpenMP support (fix for http://llvm.org/PR23492)
ClosedPublic

Authored by ABataev on May 13 2015, 12:12 AM.

Details

Summary

-fopenmp turns on OpenMP support and links libiomp5 as OpenMP library. Also there is -fopenmp={libiomp5|libgomp} option that allows to override effect of -fopenmp and link libgomp library (if -fopenmp=libgomp is specified).

Diff Detail

Event Timeline

ABataev updated this revision to Diff 25664.May 13 2015, 12:12 AM
ABataev retitled this revision from to [OPENMP] -fopenmp enables OpenMP support (fix for http://llvm.org/PR23492).
ABataev updated this object.
ABataev edited the test plan for this revision. (Show Details)
ABataev added reviewers: chandlerc, rsmith.
ABataev added subscribers: fraggamuffin, Unknown Object (MLST), ejstotzer.
rsmith added inline comments.May 17 2015, 10:09 PM
lib/Driver/Tools.cpp
3797–3798

Is there a reason to forward both of these to the frontend? It seems more inline with the design goal of giving the frontend a minimal and explicit interface to either rewrite -fopenmp to -fopenmp=libiomp5 in the driver or to not expose the underlying library to the frontend at all (it doesn't seem like the frontend needs to care).

ABataev updated this revision to Diff 25950.May 18 2015, 3:09 AM

Replace frontend option -fopenmp=libiomp5 by -fopenmp per comment from Richard Smith

rsmith accepted this revision.May 18 2015, 1:44 PM
rsmith edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 18 2015, 1:44 PM
emaste added a subscriber: emaste.May 19 2015, 10:34 AM
This revision was automatically updated to reflect the committed changes.