This is an archive of the discontinued LLVM Phabricator instance.

Differential D97144

[clang-tidy] Simplify shrink to fit check
ClosedPublic

Authored by steveire on Feb 21 2021, 6:39 AM.

Details

Reviewers
aaron.ballman
njames93
Commits
rG296c6e85c19b: [clang-tidy] Simplify shrink to fit check

Diff Detail

Event Timeline

steveire created this revision.Feb 21 2021, 6:39 AM
Herald added a subscriber: xazax.hun. · View Herald TranscriptFeb 21 2021, 6:40 AM
steveire requested review of this revision.Feb 21 2021, 6:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2021, 6:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B90120: Diff 325291.Feb 21 2021, 7:12 AM
njames93 accepted this revision.Feb 21 2021, 1:29 PM
This revision is now accepted and ready to land.Feb 21 2021, 1:29 PM
Closed by commit rG296c6e85c19b: [clang-tidy] Simplify shrink to fit check (authored by • stephenkelly). · Explain WhyFeb 27 2021, 4:15 AM
This revision was automatically updated to reflect the committed changes.
• stephenkelly added a commit: rG296c6e85c19b: [clang-tidy] Simplify shrink to fit check.

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
modernize/
3 lines
35 lines

Diff 326890

clang-tools-extra/clang-tidy/modernize/ShrinkToFitCheck.h

Show All 24 Lines
public: public:
ShrinkToFitCheck(StringRef Name, ClangTidyContext *Context) ShrinkToFitCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context) {} : ClangTidyCheck(Name, Context) {}
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
return LangOpts.CPlusPlus11; return LangOpts.CPlusPlus11;
} }
void registerMatchers(ast_matchers::MatchFinder *Finder) override; void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override; void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
llvm::Optional<TraversalKind> getCheckTraversalKind() const override {
return TK_IgnoreUnlessSpelledInSource;
}
}; };
} // namespace modernize } // namespace modernize
} // namespace tidy } // namespace tidy
} // namespace clang } // namespace clang
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_SHRINKTOFITCHECK_H #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_SHRINKTOFITCHECK_H

clang-tools-extra/clang-tidy/modernize/ShrinkToFitCheck.cpp

Show All 15 Lines
namespace clang { namespace clang {
namespace tidy { namespace tidy {
namespace modernize { namespace modernize {
void ShrinkToFitCheck::registerMatchers(MatchFinder *Finder) { void ShrinkToFitCheck::registerMatchers(MatchFinder *Finder) {
// Swap as a function need not to be considered, because rvalue can not // Swap as a function need not to be considered, because rvalue can not
// be bound to a non-const reference. // be bound to a non-const reference.
const auto ShrinkableAsMember = const auto ShrinkableExpr = mapAnyOf(memberExpr, declRefExpr);
memberExpr(member(valueDecl().bind("ContainerDecl"))); const auto Shrinkable =
const auto ShrinkableAsDecl = ShrinkableExpr.with(hasDeclaration(valueDecl().bind("ContainerDecl")));
declRefExpr(hasDeclaration(valueDecl().bind("ContainerDecl"))); const auto BoundShrinkable = ShrinkableExpr.with(
const auto CopyCtorCall = cxxConstructExpr(hasArgument( hasDeclaration(valueDecl(equalsBoundNode("ContainerDecl"))));
0, anyOf(ShrinkableAsMember, ShrinkableAsDecl,
unaryOperator(has(ignoringParenImpCasts(ShrinkableAsMember))),
unaryOperator(has(ignoringParenImpCasts(ShrinkableAsDecl))))));
const auto SwapParam =
expr(anyOf(memberExpr(member(equalsBoundNode("ContainerDecl"))),
declRefExpr(hasDeclaration(equalsBoundNode("ContainerDecl"))),
unaryOperator(has(ignoringParenImpCasts(
memberExpr(member(equalsBoundNode("ContainerDecl")))))),
unaryOperator(has(ignoringParenImpCasts(declRefExpr(
hasDeclaration(equalsBoundNode("ContainerDecl"))))))));
Finder->addMatcher( Finder->addMatcher(
cxxMemberCallExpr( cxxMemberCallExpr(
on(hasType(hasCanonicalType(hasDeclaration(namedDecl(
hasAnyName("std::basic_string", "std::deque", "std::vector")))))),
callee(cxxMethodDecl(hasName("swap"))), callee(cxxMethodDecl(hasName("swap"))),
has(ignoringParenImpCasts( hasArgument(
memberExpr(traverse(TK_AsIs, hasDescendant(CopyCtorCall))))), 0, anyOf(Shrinkable, unaryOperator(hasUnaryOperand(Shrinkable)))),
hasArgument(0, SwapParam.bind("ContainerToShrink")), on(cxxConstructExpr(hasArgument(
unless(isInTemplateInstantiation())) 0,
expr(anyOf(BoundShrinkable,
unaryOperator(hasUnaryOperand(BoundShrinkable))),
hasType(hasCanonicalType(hasDeclaration(namedDecl(hasAnyName(
"std::basic_string", "std::deque", "std::vector"))))))
.bind("ContainerToShrink")))))
.bind("CopyAndSwapTrick"), .bind("CopyAndSwapTrick"),
this); this);
} }
void ShrinkToFitCheck::check(const MatchFinder::MatchResult &Result) { void ShrinkToFitCheck::check(const MatchFinder::MatchResult &Result) {
const auto *MemberCall = const auto *MemberCall =
Result.Nodes.getNodeAs<CXXMemberCallExpr>("CopyAndSwapTrick"); Result.Nodes.getNodeAs<CXXMemberCallExpr>("CopyAndSwapTrick");
const auto *Container = Result.Nodes.getNodeAs<Expr>("ContainerToShrink"); const auto *Container = Result.Nodes.getNodeAs<Expr>("ContainerToShrink");
Show All 31 Lines