This is an archive of the discontinued LLVM Phabricator instance.

Differential D97089

[libcxx] [test] Call create_directory_symlink when linking directories
ClosedPublic

Authored by mstorsjo on Feb 19 2021, 2:23 PM.

Details

Reviewers
curdeius
ldionne
Group Reviewers
Restricted Project
Commits
rG3d6ca4b8dcee: [libcxx] [test] Call create_directory_symlink when linking directories
Summary

This makes the symlinks work properly on windows.

A similar round of cleanup was done in c41bda7f5fc26e4602a029646991d6a5c59cb365, but these tests were added after that.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 19 2021, 2:23 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptFeb 19 2021, 2:23 PM
mstorsjo requested review of this revision.Feb 19 2021, 2:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2021, 2:23 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B89981: Diff 325088.Feb 19 2021, 2:23 PM
ldionne accepted this revision.Feb 19 2021, 2:51 PM
This revision is now accepted and ready to land.Feb 19 2021, 2:51 PM
mstorsjo updated this revision to Diff 325197.Feb 20 2021, 5:57 AM
mstorsjo removed rG LLVM Github Monorepo as the repository for this revision.
mstorsjo set the repository for this revision to rG LLVM Github Monorepo.

Rebased, retry CI.

Harbormaster completed remote builds in B90053: Diff 325197.Feb 20 2021, 11:06 AM
Closed by commit rG3d6ca4b8dcee: [libcxx] [test] Call create_directory_symlink when linking directories (authored by mstorsjo). · Explain WhyFeb 20 2021, 2:26 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG3d6ca4b8dcee: [libcxx] [test] Call create_directory_symlink when linking directories.

Revision Contents

PathSize
libcxx/
test/
std/
input.output/
filesystems/
fs.op.funcs/
fs.op.create_directory/
2 lines
2 lines

Diff 325088

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp

Show First 20 Lines • Show All 116 Lines • ▼ Show 20 LinesTEST_CASE(dest_part_is_file)
TEST_CHECK(is_regular_file(file)); TEST_CHECK(is_regular_file(file));
TEST_CHECK(!exists(dir)); TEST_CHECK(!exists(dir));
} }
TEST_CASE(dest_is_symlink_to_dir) TEST_CASE(dest_is_symlink_to_dir)
{ {
scoped_test_env env; scoped_test_env env;
const path dir = env.create_dir("dir"); const path dir = env.create_dir("dir");
const path sym = env.create_symlink(dir, "sym_name"); const path sym = env.create_directory_symlink(dir, "sym_name");
std::error_code ec = GetTestEC(); std::error_code ec = GetTestEC();
TEST_CHECK(create_directory(sym, ec) == false); TEST_CHECK(create_directory(sym, ec) == false);
#ifndef _WIN32 #ifndef _WIN32
TEST_CHECK(!ec); TEST_CHECK(!ec);
#endif #endif
} }
TEST_CASE(dest_is_symlink_to_file) TEST_CASE(dest_is_symlink_to_file)
Show All 10 Lines

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory_with_attributes.pass.cpp

Show First 20 Lines • Show All 146 Lines • ▼ Show 20 Lines const path sym = env.create_symlink("dne_sym", "dne_sym_name");
TEST_CHECK(create_directory(sym, attr_dir, ec) == false); TEST_CHECK(create_directory(sym, attr_dir, ec) == false);
TEST_CHECK(ec); TEST_CHECK(ec);
} }
} }
TEST_CASE(dest_is_symlink_to_dir) { TEST_CASE(dest_is_symlink_to_dir) {
scoped_test_env env; scoped_test_env env;
const path dir = env.create_dir("dir"); const path dir = env.create_dir("dir");
const path sym = env.create_symlink(dir, "sym_name"); const path sym = env.create_directory_symlink(dir, "sym_name");
const path attr_dir = env.create_dir("attr_dir"); const path attr_dir = env.create_dir("attr_dir");
{ {
std::error_code ec = GetTestEC(); std::error_code ec = GetTestEC();
TEST_CHECK(create_directory(sym, attr_dir, ec) == false); TEST_CHECK(create_directory(sym, attr_dir, ec) == false);
TEST_CHECK(!ec); TEST_CHECK(!ec);
} }
} }
#endif #endif
Show All 14 Lines