This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Enable filesystem by default for mingw targets
ClosedPublic

Authored by mstorsjo on Feb 19 2021, 11:53 AM.

Details

Summary

This feature can be built successfully for windows now, and should be fairly complete. However, the helper functions for __int128_t aren't available in MSVC configurations, so don't enable it by default there yet. (See https://reviews.llvm.org/D91139 for discussion on how to proceed with things in MSVC environments.)

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 19 2021, 11:53 AM
mstorsjo requested review of this revision.Feb 19 2021, 11:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2021, 11:53 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
curdeius accepted this revision.Feb 19 2021, 12:12 PM
curdeius added a subscriber: curdeius.

LGTM. Would it be good time soon too add some documentation about testing on Windows, now that other patches has landed?

LGTM. Would it be good time soon too add some documentation about testing on Windows, now that other patches has landed?

Yep, I'll pick up working on that now, plus refreshing the patches for the tests, and a few other things I've promised to post later, i.e. now.

ldionne accepted this revision.Feb 19 2021, 12:14 PM
This revision is now accepted and ready to land.Feb 19 2021, 12:14 PM
This revision was automatically updated to reflect the committed changes.