Page MenuHomePhabricator
Differential D96812

[OpenMP][NFC] Eliminate sign comparison warning via explicit casts
ClosedPublic
Actions

Authored by jdoerfert on Feb 16 2021, 1:10 PM.

Details

Reviewers
tianshilei1992
bollu
Commits
rGad94fce8458e: [OpenMP][NFC] Eliminate sign comparison warning via explicit casts

Diff Detail

Event Timeline

jdoerfert created this revision.Feb 16 2021, 1:10 PM
Herald added a reviewer: bollu. · View Herald TranscriptFeb 16 2021, 1:10 PM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
jdoerfert requested review of this revision.Feb 16 2021, 1:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2021, 1:10 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
tianshilei1992 added inline comments.Feb 16 2021, 1:13 PM
openmp/libomptarget/plugins/cuda/src/rtl.cpp
232

I'd use C++ cast, aka static_cast<int>(...).

jdoerfert updated this revision to Diff 324094.Feb 16 2021, 1:19 PM

cleanup

tianshilei1992 accepted this revision.Feb 16 2021, 1:22 PM

LG

This revision is now accepted and ready to land.Feb 16 2021, 1:22 PM
This revision was landed with ongoing or failed builds.Feb 16 2021, 1:37 PM
Closed by commit rGad94fce8458e: [OpenMP][NFC] Eliminate sign comparison warning via explicit casts (authored by jdoerfert). · Explain Why
This revision was automatically updated to reflect the committed changes.
jdoerfert added a commit: rGad94fce8458e: [OpenMP][NFC] Eliminate sign comparison warning via explicit casts.
Harbormaster completed remote builds in B89432: Diff 324086.Feb 16 2021, 1:55 PM
Harbormaster completed remote builds in B89438: Diff 324094.Feb 16 2021, 2:25 PM

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
plugins/
cuda/
src/
4 lines

Diff 324099

View Options

openmp/libomptarget/plugins/cuda/src/rtl.cpp

Loading...