This is an archive of the discontinued LLVM Phabricator instance.

Differential D96789

[OpenCL] Move printf declaration to opencl-c-base.h
ClosedPublic

Authored by svenvh on Feb 16 2021, 7:10 AM.

Details

Reviewers
Anastasia
Commits
rG5a4a01460f1a: [OpenCL] Move printf declaration to opencl-c-base.h
Summary

Supporting printf with -fdeclare-opencl-builtins would require
special handling (for e.g. varargs and format attributes) for just
this one function. Instead, move the printf declaration to the
shared base header.

Diff Detail

Event Timeline

svenvh created this revision.Feb 16 2021, 7:10 AM
Herald added a subscriber: yaxunl. · View Herald TranscriptFeb 16 2021, 7:10 AM
svenvh requested review of this revision.Feb 16 2021, 7:10 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptFeb 16 2021, 7:10 AM
Harbormaster completed remote builds in B89387: Diff 324005.Feb 16 2021, 8:19 AM
Anastasia accepted this revision.Feb 17 2021, 10:09 AM

LGTM!

This revision is now accepted and ready to land.Feb 17 2021, 10:09 AM
This revision was landed with ongoing or failed builds.Feb 18 2021, 3:27 AM
Closed by commit rG5a4a01460f1a: [OpenCL] Move printf declaration to opencl-c-base.h (authored by svenvh). · Explain Why
This revision was automatically updated to reflect the committed changes.
svenvh added a commit: rG5a4a01460f1a: [OpenCL] Move printf declaration to opencl-c-base.h.

Revision Contents

PathSize
clang/
lib/
Headers/
6 lines
6 lines

Diff 324005

clang/lib/Headers/opencl-c-base.h

Show First 20 Lines • Show All 454 Lines • ▼ Show 20 Linestypedef struct {
unsigned int workDimension; unsigned int workDimension;
size_t globalWorkOffset[MAX_WORK_DIM]; size_t globalWorkOffset[MAX_WORK_DIM];
size_t globalWorkSize[MAX_WORK_DIM]; size_t globalWorkSize[MAX_WORK_DIM];
size_t localWorkSize[MAX_WORK_DIM]; size_t localWorkSize[MAX_WORK_DIM];
} ndrange_t; } ndrange_t;
#endif // defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_2_0) #endif // defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_2_0)
#if defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_1_2)
// OpenCL v1.2 s6.12.13, v2.0 s6.13.13 - printf
int printf(__constant const char* st, ...) __attribute__((format(printf, 1, 2)));
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: unknown type name '__constant' [clang-diagnostic-error]
not useful
clang-tidy: error: format argument not a string type [clang-diagnostic-error]
not useful
clang-format: please reformat the code

-int printf(__constant const char* st, ...) __attribute__((format(printf, 1, 2)));
+int printf(__constant const char *st, ...)
+    __attribute__((format(printf, 1, 2)));
Lint: Pre-merge checks: clang-tidy: error: unknown type name '__constant' [clang-diagnostic-error] [[https://github.
#endif
#ifdef cl_intel_device_side_avc_motion_estimation #ifdef cl_intel_device_side_avc_motion_estimation
#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : begin #pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : begin
#define CLK_AVC_ME_MAJOR_16x16_INTEL 0x0 #define CLK_AVC_ME_MAJOR_16x16_INTEL 0x0
#define CLK_AVC_ME_MAJOR_16x8_INTEL 0x1 #define CLK_AVC_ME_MAJOR_16x8_INTEL 0x1
#define CLK_AVC_ME_MAJOR_8x16_INTEL 0x2 #define CLK_AVC_ME_MAJOR_8x16_INTEL 0x2
#define CLK_AVC_ME_MAJOR_8x8_INTEL 0x3 #define CLK_AVC_ME_MAJOR_8x8_INTEL 0x3
▲ Show 20 Lines • Show All 134 Lines • Show Last 20 Lines

clang/lib/Headers/opencl-c.h

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 14,170 Lines • ▼ Show 20 Lines
half8 __ovld __cnfn shuffle2(half16 x, half16 y, ushort8 mask); half8 __ovld __cnfn shuffle2(half16 x, half16 y, ushort8 mask);
half16 __ovld __cnfn shuffle2(half2 x, half2 y, ushort16 mask); half16 __ovld __cnfn shuffle2(half2 x, half2 y, ushort16 mask);
half16 __ovld __cnfn shuffle2(half4 x, half4 y, ushort16 mask); half16 __ovld __cnfn shuffle2(half4 x, half4 y, ushort16 mask);
half16 __ovld __cnfn shuffle2(half8 x, half8 y, ushort16 mask); half16 __ovld __cnfn shuffle2(half8 x, half8 y, ushort16 mask);
half16 __ovld __cnfn shuffle2(half16 x, half16 y, ushort16 mask); half16 __ovld __cnfn shuffle2(half16 x, half16 y, ushort16 mask);
#endif //cl_khr_fp16 #endif //cl_khr_fp16
#if defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_1_2)
// OpenCL v1.2 s6.12.13, v2.0 s6.13.13 - printf
int printf(__constant const char* st, ...) __attribute__((format(printf, 1, 2)));
#endif
// OpenCL v1.1 s6.11.3, v1.2 s6.12.14, v2.0 s6.13.14 - Image Read and Write Functions // OpenCL v1.1 s6.11.3, v1.2 s6.12.14, v2.0 s6.13.14 - Image Read and Write Functions
#ifdef cl_khr_gl_msaa_sharing #ifdef cl_khr_gl_msaa_sharing
#pragma OPENCL EXTENSION cl_khr_gl_msaa_sharing : enable #pragma OPENCL EXTENSION cl_khr_gl_msaa_sharing : enable
#endif //cl_khr_gl_msaa_sharing #endif //cl_khr_gl_msaa_sharing
/** /**
* Use the coordinate (coord.xy) to do an element lookup in * Use the coordinate (coord.xy) to do an element lookup in
▲ Show 20 Lines • Show All 2,970 Lines • Show Last 20 Lines