[lldb] [Process/FreeBSD] Ensure that errors are always handled

[mgorny]

Summary

Ensure that the llvm::Error instances are always considered handled
by replacing LLDB_LOG with LLDB_LOG_ERROR.

[labath]

This is precisely the reason we have the LLDB_LOG_ERROR macro :)

[mgorny]

In D96558#2563105, @labath wrote:

This is precisely the reason we have the LLDB_LOG_ERROR macro :)

Updated.

lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp

if (info.pl_flags & PL_FLAG_BORN) {
       // established during this period are propagated to new threads,
       // explicitly copy the DR value at the time the new thread is reported.
       //
       // See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250954
 
       llvm::Error error = t.CopyWatchpointsFrom(
           static_cast<NativeThreadFreeBSD &>(*GetCurrentThread()));
       if (error) {
+        auto error_msg = llvm::toString(std::move(error));
         LLDB_LOG(log, "failed to copy watchpoints to new thread {0}: {1}",
-                 info.pl_lwpid, llvm::toString(std::move(error)));
+                 info.pl_lwpid, error_msg);
         SetState(StateType::eStateInvalid);
         return;
       }
     } else /*if (info.pl_flags & PL_FLAG_EXITED)*/ {
       LLDB_LOG(log, "thread exited, tid = {0}", info.pl_lwpid);
       RemoveThread(info.pl_lwpid);
     }