Page MenuHomePhabricator

[lldb] [Process/FreeBSD] Ensure that errors are always handled
ClosedPublic

Authored by mgorny on Feb 11 2021, 3:54 PM.

Details

Summary

Ensure that the llvm::Error instances are always considered handled
by replacing LLDB_LOG with LLDB_LOG_ERROR.

Diff Detail

Event Timeline

mgorny requested review of this revision.Feb 11 2021, 3:54 PM
mgorny created this revision.

This is precisely the reason we have the LLDB_LOG_ERROR macro :)

mgorny updated this revision to Diff 323774.Feb 15 2021, 8:40 AM
mgorny retitled this revision from [lldb] [Process/FreeBSDRemote] Ensure that errors are always handled to [lldb] [Process/FreeBSD] Ensure that errors are always handled.
mgorny edited the summary of this revision. (Show Details)

This is precisely the reason we have the LLDB_LOG_ERROR macro :)

Updated.

labath accepted this revision.Feb 16 2021, 10:01 AM
This revision is now accepted and ready to land.Feb 16 2021, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2021, 1:22 PM