This is an archive of the discontinued LLVM Phabricator instance.

[DeveloperPolicy] Specify LLVM's license more clearly.
ClosedPublic

Authored by kristof.beyls on Feb 11 2021, 2:58 AM.

Details

Summary

Before, the first mention of LLVM's license on the developer policy page stated
that LLVM's license is Apache 2. This patch makes that more accurate by
mentioning the LLVM exception this first time the LLVM license is discussed on
that page, i.e. Apache-2.0 with LLVM-exception.

Technically, the correct SPDX identifier for LLVM's license is 'Apache-2.0 WITH
LLVM-exception', but I thought that writing the 'WITH' in lower case made the
paragraph easier to read without reducing clarity.

Diff Detail

Event Timeline

kristof.beyls requested review of this revision.Feb 11 2021, 2:58 AM
kristof.beyls created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 2:58 AM

If you would extend the paragraph, you could say:
"For reference the SPDX identifier is ..."

If you would extend the paragraph, you could say:
"For reference the SPDX identifier is ..."

Yes, it could be helpful to also explicitly call out the SPDX identifier. However, there is also value in keeping that introductory paragraph as short as possible.
On balance, I think it's slightly better to not call out the SPDX identifier in that introductory paragraph.
Maybe there's value in explicitly calling out the SPDX identifiers in one of the later paragraphs?

If you would extend the paragraph, you could say:
"For reference the SPDX identifier is ..."

Yes, it could be helpful to also explicitly call out the SPDX identifier. However, there is also value in keeping that introductory paragraph as short as possible.
On balance, I think it's slightly better to not call out the SPDX identifier in that introductory paragraph.
Maybe there's value in explicitly calling out the SPDX identifiers in one of the later paragraphs?

Agreed. In fact, I could neither find a WITH nor a SPDX in the whole file.

There is also no LLVM-exception with a dash.

lattner accepted this revision.Feb 11 2021, 9:38 AM

Looks great, thank you!

This revision is now accepted and ready to land.Feb 11 2021, 9:38 AM
This revision was landed with ongoing or failed builds.Feb 12 2021, 1:17 AM
This revision was automatically updated to reflect the committed changes.