Paths

Table of Contentst

Differential D96333

[mlir] Add stacksave, stackrestore to llvm dialect
ClosedPublic
Actions

Authored by shabalin on Feb 9 2021, 5:14 AM.

Details

Reviewers

Commits

rGfa581f943887: [mlir] Add stacksave, stackrestore to llvm dialect

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

shabalin created this revision.Feb 9 2021, 5:14 AM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptFeb 9 2021, 5:14 AM

shabalin requested review of this revision.Feb 9 2021, 5:14 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 5:14 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

ftynse accepted this revision.Feb 9 2021, 5:20 AM

ftynse added inline comments.

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
1284	Nit: could we rather use `LLVM_[Zero\|One]ResultIntrOp` instead of magic trailing parameters?
mlir/test/Target/llvmir-intrinsics.mlir
383	Looks like misrebase, I fixed this yesterday

This revision is now accepted and ready to land.Feb 9 2021, 5:20 AM

Harbormaster completed remote builds in B88446: Diff 322351.Feb 9 2021, 5:46 AM

Address the feedback.

shabalin marked 2 inline comments as done.Feb 9 2021, 6:09 AM

This revision was landed with ongoing or failed builds.Feb 9 2021, 6:13 AM

Closed by commit rGfa581f943887: [mlir] Add stacksave, stackrestore to llvm dialect (authored by shabalin, committed by ftynse). · Explain Why

This revision was automatically updated to reflect the committed changes.

ftynse added a commit: rGfa581f943887: [mlir] Add stacksave, stackrestore to llvm dialect.

Harbormaster completed remote builds in B88455: Diff 322367.Feb 9 2021, 6:48 AM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

LLVMIR/

13 lines

test/

Target/

llvmir-intrinsics.mlir

14 lines

Diff 322370

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Loading...

mlir/test/Target/llvmir-intrinsics.mlir

Loading...