Page MenuHomePhabricator

[mlir] Add stacksave, stackrestore to llvm dialect
ClosedPublic

Authored by shabalin on Feb 9 2021, 5:14 AM.

Diff Detail

Event Timeline

shabalin created this revision.Feb 9 2021, 5:14 AM
shabalin requested review of this revision.Feb 9 2021, 5:14 AM
ftynse accepted this revision.Feb 9 2021, 5:20 AM
ftynse added inline comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
1284

Nit: could we rather use LLVM_[Zero|One]ResultIntrOp instead of magic trailing parameters?

mlir/test/Target/llvmir-intrinsics.mlir
383

Looks like misrebase, I fixed this yesterday

This revision is now accepted and ready to land.Feb 9 2021, 5:20 AM
shabalin updated this revision to Diff 322367.Feb 9 2021, 6:07 AM

Address the feedback.

shabalin marked 2 inline comments as done.Feb 9 2021, 6:09 AM
This revision was landed with ongoing or failed builds.Feb 9 2021, 6:13 AM
This revision was automatically updated to reflect the committed changes.