[flang][msvc] Reapply "Explicitly reference "this" inside closure"

[ChinouneMehdi]

Summary

Reapply D88052: [flang][msvc] Explicitly reference "this" inside closure. NFC.

[Meinersbur]

LGTM

[ChinouneMehdi]

In D96066#2543112, @Meinersbur wrote:

LGTM

Could you push it as I don't have commit access.

[Meinersbur]

Thank you for the patch.

[ChinouneMehdi]

Thanks.

flang/lib/Semantics/symbol.cpp

return std::visit(
         common::visitors{
             [](const UseErrorDetails &) { return true; },
             [&](const ObjectEntityDetails &) { return has<EntityDetails>(); },
             [&](const ProcEntityDetails &) { return has<EntityDetails>(); },
             [&](const SubprogramDetails &) {
               return has<SubprogramNameDetails>() || has<EntityDetails>();
             },
             [&](const DerivedTypeDetails &) {
-              const auto *derived{detailsIf<DerivedTypeDetails>()};
+              const auto *derived{this->detailsIf<DerivedTypeDetails>()};
               return derived && derived->isForwardReferenced();
             },
             [&](const UseDetails &x) {
-              const auto *use{detailsIf<UseDetails>()};
+              const auto *use{this->detailsIf<UseDetails>()};
               return use && use->symbol() == x.symbol();
             },
             [](const auto &) { return false; },
         },
         details);
   }
 }