Page MenuHomePhabricator

[Darwin] Switch to new logging api for sanitizers
ClosedPublic

Authored by aralisza on Feb 3 2021, 1:55 PM.

Details

Summary

Switch to new logging api added in macOS 10.12 that is more memory safe and enables us to label the log messages in the future. Falls back to old API if ran on older OS versions.

rdar://25181524

Diff Detail

Event Timeline

aralisza requested review of this revision.Feb 3 2021, 1:55 PM
aralisza created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2021, 1:55 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aralisza retitled this revision from test to [Darwin] Switch to new logging api.Feb 3 2021, 1:58 PM
aralisza retitled this revision from [Darwin] Switch to new logging api to [Darwin] Switch to new logging api for sanitizers.Feb 3 2021, 3:43 PM
aralisza edited the summary of this revision. (Show Details)Feb 3 2021, 3:56 PM
aralisza added a reviewer: delcypher.
aralisza updated this revision to Diff 321254.Feb 3 2021, 4:04 PM

rebase from main

aralisza edited the summary of this revision. (Show Details)Feb 3 2021, 4:12 PM
aralisza added reviewers: kubamracek, yln.
aralisza edited the summary of this revision. (Show Details)
aralisza edited the summary of this revision. (Show Details)
yln accepted this revision.Feb 3 2021, 4:37 PM

LGTM assuming we did some manual QA/testing. (Adding a test is probably too hard to be worth it.)

This revision is now accepted and ready to land.Feb 3 2021, 4:37 PM
Harbormaster completed remote builds in B87803: Diff 321257.
In D95977#2540677, @yln wrote:

LGTM assuming we did some manual QA/testing. (Adding a test is probably too hard to be worth it.)

@yln We do have a test that tests the syslog functionality (test/asan/TestCases/Darwin/duplicate_os_log_reports.cpp). Unfortunately it's disabled right now because it run very well on the bots :(

delcypher accepted this revision.Feb 4 2021, 7:51 PM

LGTM. Local testing suggests this is working as intended.

This revision was automatically updated to reflect the committed changes.