[Darwin] Switch to new logging api for sanitizers

[aralisza]

Summary

Switch to new logging api added in macOS 10.12 that is more memory safe and enables us to label the log messages in the future. Falls back to old API if ran on older OS versions.

rdar://25181524

[aralisza]

rebase from main

[aralisza]

update to 10.12 per docs https://developer.apple.com/documentation/os/os_log_error

[yln]

LGTM assuming we did some manual QA/testing. (Adding a test is probably too hard to be worth it.)

[delcypher]

In D95977#2540677, @yln wrote:

LGTM assuming we did some manual QA/testing. (Adding a test is probably too hard to be worth it.)

@yln We do have a test that tests the syslog functionality (test/asan/TestCases/Darwin/duplicate_os_log_reports.cpp). Unfortunately it's disabled right now because it run very well on the bots :(

[delcypher]

LGTM. Local testing suggests this is working as intended.

compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp

 #include <errno.h>
 #include <fcntl.h>
 #include <libkern/OSAtomic.h>
 #include <mach-o/dyld.h>
 #include <mach/mach.h>
 #include <mach/mach_time.h>
 #include <mach/vm_statistics.h>
 #include <malloc/malloc.h>
+#include <os/log.h>
 #include <pthread.h>
 #include <sched.h>
 #include <signal.h>
 #include <spawn.h>
 #include <stdlib.h>
 #include <sys/ioctl.h>
 #include <sys/mman.h>
 #include <sys/resource.h>

 
 #if !SANITIZER_GO
 static BlockingMutex syslog_lock(LINKER_INITIALIZED);
 #endif
 
 void WriteOneLineToSyslog(const char *s) {
 #if !SANITIZER_GO
   syslog_lock.CheckLocked();
+  if (GetMacosAlignedVersion() >= MacosVersion(10, 12)) {
+    os_log_error(OS_LOG_DEFAULT, "%{public}s", s);
+  } else {
     asl_log(nullptr, nullptr, ASL_LEVEL_ERR, "%s", s);
+  }
 #endif
 }
 
 void LogMessageOnPrintf(const char *str) {
   // Log all printf output to CrashLog.
   if (common_flags()->abort_on_error)
     CRAppendCrashLogMessage(str);
 }