This is an archive of the discontinued LLVM Phabricator instance.

Differential D96295

[Darwin] enable duplicate_os_log_reports lit test
AcceptedPublic

Authored by aralisza on Feb 8 2021, 2:34 PM.

Details

Reviewers
delcypher
yln
kubamracek
Summary

This test was previously disabled due to flakiness in CI. Switching to new logging api should have fixed it. https://reviews.llvm.org/D95977

rdar://62141527

Diff Detail

Event Timeline

aralisza requested review of this revision.Feb 8 2021, 2:34 PM
aralisza created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 2:34 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aralisza retitled this revision from [Darwin] enable duplicate_os_log_reports test to [Darwin] enable duplicate_os_log_reports lit test.Feb 8 2021, 2:36 PM
aralisza edited the summary of this revision. (Show Details)
aralisza added reviewers: delcypher, yln, kubamracek.
aralisza edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B88359: Diff 322220.Feb 8 2021, 3:12 PM
delcypher added a comment.Apr 7 2021, 11:23 PM

@aralisza Sorry I missed this patch. LGTM.

delcypher accepted this revision.Apr 7 2021, 11:23 PM
This revision is now accepted and ready to land.Apr 7 2021, 11:23 PM

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Darwin/
2 lines

Diff 322220

compiler-rt/test/asan/TestCases/Darwin/duplicate_os_log_reports.cpp

// UNSUPPORTED: ios // UNSUPPORTED: ios
// Don't re-enable until rdar://problem/62141527 is fixed.
// REQUIRES: rdar_62141527
// REQUIRES: shell // REQUIRES: shell
// REQUIRES: darwin_log_cmd // REQUIRES: darwin_log_cmd
// RUN: %clangxx_asan -fsanitize-recover=address %s -o %t // RUN: %clangxx_asan -fsanitize-recover=address %s -o %t
// RUN: { %env_asan_opts=halt_on_error=0,log_to_syslog=1 %run %t > %t.process_output.txt 2>&1 & } \ // RUN: { %env_asan_opts=halt_on_error=0,log_to_syslog=1 %run %t > %t.process_output.txt 2>&1 & } \
// RUN: ; export TEST_PID=$! ; wait ${TEST_PID} // RUN: ; export TEST_PID=$! ; wait ${TEST_PID}
// Check process output. // Check process output.
// RUN: FileCheck %s --check-prefixes CHECK,CHECK-PROC -input-file=%t.process_output.txt // RUN: FileCheck %s --check-prefixes CHECK,CHECK-PROC -input-file=%t.process_output.txt
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines