Page MenuHomePhabricator

Remove unused CHECK of dllexport declaration
AcceptedPublic

Authored by bd1976llvm on Feb 3 2021, 5:59 AM.

Details

Summary

I don't believe that dllexport declarations make sense. This is the only case of a dllexport declaration in LLVM testing. Dllimport/export was introduced here: https://reviews.llvm.org/D1110, looking at the tests added and the commentary it doesn't seem that dllexport declarations were an imagined use case.

These CHECKs were unused in the original version of this test: https://github.com/llvm/llvm-project/commit/6cb074493420dcc1922e2a1d066806dae3051172.

Diff Detail

Event Timeline

bd1976llvm requested review of this revision.Feb 3 2021, 5:59 AM
bd1976llvm created this revision.
rnk accepted this revision.Feb 3 2021, 10:53 AM
rnk added inline comments.
clang/test/CodeGenCXX/runtime-dllstorage.cpp
149

Looks like CHECK-STATIC-EXPORT-IA is also an unused prefix, unless I'm mistaken.

This revision is now accepted and ready to land.Feb 3 2021, 10:53 AM
bd1976llvm edited the summary of this revision. (Show Details)Feb 8 2021, 8:39 AM
bd1976llvm edited the summary of this revision. (Show Details)Feb 8 2021, 8:57 AM