This is an archive of the discontinued LLVM Phabricator instance.

Differential D95879

[clang][index] Mark file as C++ in parse-all-comments test
ClosedPublic

Authored by jansvoboda11 on Feb 2 2021, 9:32 AM.

Details

Reviewers
dexonsmith
Bigcheese
Commits
rGc1b482e726a9: [clang][index] Mark file as C++ in parse-all-comments test
Summary

CompilerInvocation::CreateFromArgs doesn't always report command line parsing failures through the return value. Sometimes, errors are only reported via diagnostics.

Some clients like c-index-test only check the return value and don't check the state of DiagnosticsEngine.

If we were to start returning the correct return value from CreateFromArgs, this index test starts to fail, because it specifies -std=c++11 for a C input, which is invalid.

This patch fixes that issue by adding forgotten -x c++ argument.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Feb 2 2021, 9:32 AM
Herald added a subscriber: arphaman. · View Herald TranscriptFeb 2 2021, 9:32 AM
jansvoboda11 requested review of this revision.Feb 2 2021, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2021, 9:32 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B87544: Diff 320821.Feb 2 2021, 10:21 AM
dexonsmith accepted this revision.Feb 2 2021, 10:37 AM

LGTM

This revision is now accepted and ready to land.Feb 2 2021, 10:37 AM
This revision was landed with ongoing or failed builds.Feb 8 2021, 12:43 AM
Closed by commit rGc1b482e726a9: [clang][index] Mark file as C++ in parse-all-comments test (authored by jansvoboda11). · Explain Why
This revision was automatically updated to reflect the committed changes.
jansvoboda11 added a commit: rGc1b482e726a9: [clang][index] Mark file as C++ in parse-all-comments test.

Revision Contents

PathSize
clang/
test/
Index/
2 lines

Diff 322043

clang/test/Index/parse-all-comments.c

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines
#endif #endif
// RUN: rm -rf %t // RUN: rm -rf %t
// RUN: mkdir %t // RUN: mkdir %t
// RUN: c-index-test -write-pch %t/out.pch -fparse-all-comments -x c++ -std=c++11 %s // RUN: c-index-test -write-pch %t/out.pch -fparse-all-comments -x c++ -std=c++11 %s
// RUN: c-index-test -test-load-source all -comments-xml-schema=%S/../../bindings/xml/comment-xml-schema.rng %s -std=c++11 -fparse-all-comments > %t/out.c-index-direct // RUN: c-index-test -test-load-source all -comments-xml-schema=%S/../../bindings/xml/comment-xml-schema.rng -x c++ -std=c++11 %s -fparse-all-comments > %t/out.c-index-direct
// RUN: c-index-test -test-load-tu %t/out.pch all > %t/out.c-index-pch // RUN: c-index-test -test-load-tu %t/out.pch all > %t/out.c-index-pch
// RUN: FileCheck %s -check-prefix=WRONG < %t/out.c-index-direct // RUN: FileCheck %s -check-prefix=WRONG < %t/out.c-index-direct
// RUN: FileCheck %s -check-prefix=WRONG < %t/out.c-index-pch // RUN: FileCheck %s -check-prefix=WRONG < %t/out.c-index-pch
// Ensure that XML is not invalid // Ensure that XML is not invalid
// WRONG-NOT: CommentXMLInvalid // WRONG-NOT: CommentXMLInvalid
Show All 29 Lines