This is an archive of the discontinued LLVM Phabricator instance.

Differential D95639

[compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o
ClosedPublic

Authored by erik.pilkington on Jan 28 2021, 2:08 PM.

Details

Reviewers
ilinpv
arphaman
Commits
rG5f3c4923e4e4: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o
Summary

This fixes an apparent oversight in D91156, where the symbol was defined without the leading underscore, then the visibility was later declared with it. rdar://73364185

Diff Detail

Event Timeline

erik.pilkington created this revision.Jan 28 2021, 2:08 PM
Herald added subscribers: danielkiss, ributzka, jkorous and 2 others. · View Herald TranscriptJan 28 2021, 2:08 PM
erik.pilkington requested review of this revision.Jan 28 2021, 2:08 PM
ilinpv accepted this revision.Jan 28 2021, 2:58 PM

Yes, I missed it, thanks for fix!

This revision is now accepted and ready to land.Jan 28 2021, 2:58 PM
Closed by commit rG5f3c4923e4e4: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o (authored by erik.pilkington). · Explain WhyFeb 1 2021, 8:29 AM
This revision was automatically updated to reflect the committed changes.
erik.pilkington added a commit: rG5f3c4923e4e4: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2021, 8:29 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
5 lines

Diff 320482

compiler-rt/lib/builtins/assembly.h

Show First 20 Lines • Show All 198 Lines • ▼ Show 20 Lines
#define GLUE4_(a, b, c, d) a##b##c##d #define GLUE4_(a, b, c, d) a##b##c##d
#define GLUE4(a, b, c, d) GLUE4_(a, b, c, d) #define GLUE4(a, b, c, d) GLUE4_(a, b, c, d)
#define SYMBOL_NAME(name) GLUE(__USER_LABEL_PREFIX__, name) #define SYMBOL_NAME(name) GLUE(__USER_LABEL_PREFIX__, name)
#ifdef VISIBILITY_HIDDEN #ifdef VISIBILITY_HIDDEN
#define DECLARE_SYMBOL_VISIBILITY(name) \ #define DECLARE_SYMBOL_VISIBILITY(name) \
HIDDEN(SYMBOL_NAME(name)) SEPARATOR HIDDEN(SYMBOL_NAME(name)) SEPARATOR
#define DECLARE_SYMBOL_VISIBILITY_UNMANGLED(name) \
HIDDEN(name) SEPARATOR
#else #else
#define DECLARE_SYMBOL_VISIBILITY(name) #define DECLARE_SYMBOL_VISIBILITY(name)
#define DECLARE_SYMBOL_VISIBILITY_UNMANGLED(name)
#endif #endif
#define DEFINE_COMPILERRT_FUNCTION(name) \ #define DEFINE_COMPILERRT_FUNCTION(name) \
DEFINE_CODE_STATE \ DEFINE_CODE_STATE \
FILE_LEVEL_DIRECTIVE SEPARATOR \ FILE_LEVEL_DIRECTIVE SEPARATOR \
.globl SYMBOL_NAME(name) SEPARATOR \ .globl SYMBOL_NAME(name) SEPARATOR \
SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR \ SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR \
DECLARE_SYMBOL_VISIBILITY(name) \ DECLARE_SYMBOL_VISIBILITY(name) \
Show All 26 Lines#define DEFINE_COMPILERRT_PRIVATE_FUNCTION_UNMANGLED(name) \
DECLARE_FUNC_ENCODING \ DECLARE_FUNC_ENCODING \
name: name:
#define DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(name) \ #define DEFINE_COMPILERRT_OUTLINE_FUNCTION_UNMANGLED(name) \
DEFINE_CODE_STATE \ DEFINE_CODE_STATE \
FUNC_ALIGN \ FUNC_ALIGN \
.globl name SEPARATOR \ .globl name SEPARATOR \
SYMBOL_IS_FUNC(name) SEPARATOR \ SYMBOL_IS_FUNC(name) SEPARATOR \
DECLARE_SYMBOL_VISIBILITY(name) SEPARATOR \ DECLARE_SYMBOL_VISIBILITY_UNMANGLED(name) SEPARATOR \
CFI_START SEPARATOR \ CFI_START SEPARATOR \
DECLARE_FUNC_ENCODING \ DECLARE_FUNC_ENCODING \
name: SEPARATOR BTI_C name: SEPARATOR BTI_C
#define DEFINE_COMPILERRT_FUNCTION_ALIAS(name, target) \ #define DEFINE_COMPILERRT_FUNCTION_ALIAS(name, target) \
.globl SYMBOL_NAME(name) SEPARATOR \ .globl SYMBOL_NAME(name) SEPARATOR \
SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR \ SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR \
DECLARE_SYMBOL_VISIBILITY(SYMBOL_NAME(name)) SEPARATOR \ DECLARE_SYMBOL_VISIBILITY(SYMBOL_NAME(name)) SEPARATOR \
Show All 22 Lines