This is an archive of the discontinued LLVM Phabricator instance.

Differential D95612

[mlir] Remove mlir_c_runner_utils_static.
ClosedPublic

Authored by csigg on Jan 28 2021, 6:29 AM.

Download Raw Diff

Details

Reviewers

ftynse

Commits

rG27924b126329: [mlir] Remove mlir_c_runner_utils_static.

Summary

The library is not actually static when BUILD_SHARED_LIBS is on, and tests need to explicitly load it already. Also, the shared objects it was linked to did not use any symbols from it and it was therefore never linked to it.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

csigg created this revision.Jan 28 2021, 6:29 AM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 16 others. · View Herald TranscriptJan 28 2021, 6:29 AM

csigg requested review of this revision.Jan 28 2021, 6:29 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2021, 6:29 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B87017: Diff 319850.Jan 28 2021, 6:57 AM

csigg added a reviewer: ftynse.Jan 28 2021, 7:29 AM

ftynse accepted this revision.Jan 28 2021, 8:47 AM

This revision is now accepted and ready to land.Jan 28 2021, 8:47 AM

Closed by commit rG27924b126329: [mlir] Remove mlir_c_runner_utils_static. (authored by csigg). · Explain WhyJan 29 2021, 6:05 AM

This revision was automatically updated to reflect the committed changes.

csigg added a commit: rG27924b126329: [mlir] Remove mlir_c_runner_utils_static..

Revision Contents

Path

Size

mlir/

lib/

ExecutionEngine/

CMakeLists.txt

12 lines

Diff 320122

mlir/lib/ExecutionEngine/CMakeLists.txt

	Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
	add_mlir_library(mlir_c_runner_utils			add_mlir_library(mlir_c_runner_utils
	SHARED			SHARED
	CRunnerUtils.cpp			CRunnerUtils.cpp
	SparseUtils.cpp			SparseUtils.cpp

	EXCLUDE_FROM_LIBMLIR			EXCLUDE_FROM_LIBMLIR
	)			)
	set_property(TARGET mlir_c_runner_utils PROPERTY CXX_STANDARD 11)			set_property(TARGET mlir_c_runner_utils PROPERTY CXX_STANDARD 11)

	add_mlir_library(mlir_c_runner_utils_static
	CRunnerUtils.cpp
	SparseUtils.cpp

	EXCLUDE_FROM_LIBMLIR
	)
	set_property(TARGET mlir_c_runner_utils_static PROPERTY CXX_STANDARD 11)
	target_compile_definitions(mlir_c_runner_utils PRIVATE mlir_c_runner_utils_EXPORTS)			target_compile_definitions(mlir_c_runner_utils PRIVATE mlir_c_runner_utils_EXPORTS)

	add_mlir_library(mlir_runner_utils			add_mlir_library(mlir_runner_utils
	SHARED			SHARED
	RunnerUtils.cpp			RunnerUtils.cpp

	EXCLUDE_FROM_LIBMLIR			EXCLUDE_FROM_LIBMLIR

	LINK_LIBS PUBLIC
	mlir_c_runner_utils_static
	)			)
	target_compile_definitions(mlir_runner_utils PRIVATE mlir_runner_utils_EXPORTS)			target_compile_definitions(mlir_runner_utils PRIVATE mlir_runner_utils_EXPORTS)

	add_mlir_library(mlir_async_runtime			add_mlir_library(mlir_async_runtime
	SHARED			SHARED
	AsyncRuntime.cpp			AsyncRuntime.cpp

	EXCLUDE_FROM_LIBMLIR			EXCLUDE_FROM_LIBMLIR

	LINK_LIBS PUBLIC			LINK_LIBS PUBLIC
	mlir_c_runner_utils_static
	${LLVM_PTHREAD_LIB}			${LLVM_PTHREAD_LIB}
	)			)
	set_property(TARGET mlir_async_runtime PROPERTY CXX_VISIBILITY_PRESET hidden)			set_property(TARGET mlir_async_runtime PROPERTY CXX_VISIBILITY_PRESET hidden)
	target_compile_definitions(mlir_async_runtime PRIVATE mlir_async_runtime_EXPORTS)			target_compile_definitions(mlir_async_runtime PRIVATE mlir_async_runtime_EXPORTS)