This is an archive of the discontinued LLVM Phabricator instance.

Differential D9554

[Msan] Fix the report-demangling.cc test to pass on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on May 7 2015, 5:25 AM.

Details

Reviewers
kcc
samsonov
eugenis
Commits
rCRT236833: [Msan] Fix the report-demangling.cc test to pass on FreeBSD
rL236833: [Msan] Fix the report-demangling.cc test to pass on FreeBSD
Summary

The good old () vs (void) issue.

Diff Detail

Event Timeline

kutuzov.viktor.84 updated this revision to Diff 25166.May 7 2015, 5:25 AM
kutuzov.viktor.84 retitled this revision from to [Msan] Fix the report-demangling.cc test to pass on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov, eugenis.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
eugenis accepted this revision.May 7 2015, 9:40 AM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 7 2015, 9:40 AM
Closed by commit rL236833: [Msan] Fix the report-demangling.cc test to pass on FreeBSD (authored by vkutuzov). · Explain WhyMay 8 2015, 5:14 AM
This revision was automatically updated to reflect the committed changes.
emaste added a comment.May 19 2015, 8:27 AM

For reference this is now tracked upstream: https://sourceforge.net/p/elftoolchain/tickets/491/
(Actually 3 levels upstream: FreeBSD - libcxxrt - ELF tool chain)
Other issues encountered by *san tests have been addressed (e.g. extra 'E's in demangled output), but all will take some time to make it into a FreeBSD release.

Revision Contents

PathSize
test/
msan/
2 lines

Diff 25166

test/msan/report-demangling.cc

Show All 9 Linesint f() {
int *volatile p = &x; int *volatile p = &x;
return *p; return *p;
} }
int main(int argc, char **argv) { int main(int argc, char **argv) {
return f(); return f();
// CHECK: WARNING: MemorySanitizer: use-of-uninitialized-value // CHECK: WARNING: MemorySanitizer: use-of-uninitialized-value
// CHECK: Uninitialized value was created by an allocation of 'x' in the stack frame of function '_Z1fv' // CHECK: Uninitialized value was created by an allocation of 'x' in the stack frame of function '_Z1fv'
// CHECK: #0 {{.*}} in f() {{.*}}report-demangling.cc:[[@LINE-10]] // CHECK: #0 {{.*}} in f{{.*}} {{.*}}report-demangling.cc:[[@LINE-10]]
} }