This is an archive of the discontinued LLVM Phabricator instance.

Differential D95499

[NFC] Disallow unused prefixes under clang/test/CodeGenCXX
ClosedPublic

Authored by mtrofin on Jan 26 2021, 8:06 PM.

Details

Reviewers
rnk
Commits
rGcfcc1110d773: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX
Summary

The only test that needed change had 'QUAL' as an unused prefix. The
rest of the changes are to simplify the prefix lists.

Diff Detail

Event Timeline

mtrofin requested review of this revision.Jan 26 2021, 8:06 PM
mtrofin created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2021, 8:06 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B86794: Diff 319453.Jan 26 2021, 8:49 PM
rnk accepted this revision.Jan 27 2021, 2:57 PM
rnk added a subscriber: akhuang.

lgtm

I believe @akhuang's recent change to this file made it so debug info names are unqualified in all modes.

This revision is now accepted and ready to land.Jan 27 2021, 2:57 PM
This revision was landed with ongoing or failed builds.Jan 28 2021, 9:47 AM
Closed by commit rGcfcc1110d773: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX (authored by mtrofin). · Explain Why
This revision was automatically updated to reflect the committed changes.
mtrofin added a commit: rGcfcc1110d773: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX.

Revision Contents

PathSize
clang/
test/
CodeGenCXX/
8 lines
9 lines

Diff 319905

clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp

// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ // RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \
// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -std=c++98 | \ // RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -std=c++98 | \
// RUN: grep -E 'DISubprogram|DICompositeType' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \ // RUN: grep -E 'DISubprogram|DICompositeType' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \
// RUN: FileCheck %s --check-prefix=CHECK --check-prefix=UNQUAL // RUN: FileCheck %s --check-prefixes=CHECK,UNQUAL
// RUN: %clang_cc1 -fblocks -debug-info-kind=line-tables-only -gcodeview -emit-llvm %s \ // RUN: %clang_cc1 -fblocks -debug-info-kind=line-tables-only -gcodeview -emit-llvm %s \
// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -std=c++98 | \ // RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -std=c++98 | \
// RUN: grep 'DISubprogram' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \ // RUN: grep 'DISubprogram' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \
// RUN: FileCheck %s --check-prefix=CHECK --check-prefix=QUAL // RUN: FileCheck %s
// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ // RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \
// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -std=c++11 | \ // RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -std=c++11 | \
// RUN: grep -E 'DISubprogram|DICompositeType' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \ // RUN: grep -E 'DISubprogram|DICompositeType' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \
// RUN: FileCheck %s --check-prefix=CHECK --check-prefix=UNQUAL // RUN: FileCheck %s --check-prefixes=CHECK,UNQUAL
// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ // RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \
// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null | \ // RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null | \
// RUN: grep -E 'DISubprogram|DICompositeType' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \ // RUN: grep -E 'DISubprogram|DICompositeType' | sed -e 's/.*name: "\([^"]*\)".*/"\1"/' | \
// RUN: FileCheck %s --check-prefix=CHECK --check-prefix=UNQUAL // RUN: FileCheck %s --check-prefixes=CHECK,UNQUAL
void freefunc() { } void freefunc() { }
// CHECK-DAG: "freefunc" // CHECK-DAG: "freefunc"
namespace N { namespace N {
int b() { return 0; } int b() { return 0; }
// CHECK-DAG: "b" // CHECK-DAG: "b"
namespace { void func() { } } namespace { void func() { } }
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

clang/test/CodeGenCXX/lit.local.cfg

  • This file was added.
# -*- Python -*- vim: set ft=python ts=4 sw=4 expandtab tw=79:
from lit.llvm.subst import ToolSubst
fc = ToolSubst('FileCheck', unresolved='fatal')
# Insert this first. Then, we'll first update the blank FileCheck command; then,
# the default substitution of FileCheck will replace it to its full path.
config.substitutions.insert(0, (fc.regex,
'FileCheck --allow-unused-prefixes=false'))