Page MenuHomePhabricator

[clang-format] Avoid considering include directive as a template closer.
ClosedPublic

Authored by curdeius on Jan 26 2021, 1:19 PM.

Details

Summary

This fixes a bug PR48891 introduced in D93839 where:

#include <stdint.h>
namespace rep {}

got formatted as

#include <stdint.h>
namespace rep {
}

Diff Detail

Event Timeline

curdeius requested review of this revision.Jan 26 2021, 1:19 PM
curdeius created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2021, 1:19 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
leonardchan accepted this revision.Jan 26 2021, 1:36 PM

LGTM. Confirmed on our end this fixes our issue. Thanks for addressing this!

This revision is now accepted and ready to land.Jan 26 2021, 1:36 PM
curdeius edited the summary of this revision. (Show Details)Jan 27 2021, 12:13 AM
This revision was landed with ongoing or failed builds.Jan 27 2021, 12:15 AM
This revision was automatically updated to reflect the committed changes.

@tstellar, could this be cherry-picked to 12.x branch? As noted above and discussed in D93839, this fixes PR48891 bug that introduced an unintended change in behaviour of clang-format.