This is an archive of the discontinued LLVM Phabricator instance.

Differential D95359

[lld-macho] Link against ObjCARCOpts instead of ObjCARC
ClosedPublic

Authored by int3 on Jan 25 2021, 6:46 AM.

Details

Reviewers
compnerd
Group Reviewers
Restricted Project
Commits
rG3dd5ea9dd8d9: [lld-macho] Link against ObjCARCOpts instead of ObjCARC
Summary

Not sure what the difference is, but using the latter appears to cause
issues in standalone builds. See llvm.org/PR48853.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 windows > LLVM.ExecutionEngine/JITLink/X86::ELF_ehframe_basic.s

Event Timeline

int3 created this revision.Jan 25 2021, 6:46 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJan 25 2021, 6:46 AM
int3 requested review of this revision.Jan 25 2021, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2021, 6:46 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B86559: Diff 318993.Jan 25 2021, 7:13 AM
compnerd accepted this revision.Jan 25 2021, 9:38 AM
compnerd added a subscriber: compnerd.

I'm really not sure what ObjCARC maps to. ObjCARCOpts is the correct component name.

This revision is now accepted and ready to land.Jan 25 2021, 9:38 AM
This revision was landed with ongoing or failed builds.Jan 25 2021, 4:02 PM
Closed by commit rG3dd5ea9dd8d9: [lld-macho] Link against ObjCARCOpts instead of ObjCARC (authored by int3). · Explain Why
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG3dd5ea9dd8d9: [lld-macho] Link against ObjCARCOpts instead of ObjCARC.

Revision Contents

PathSize
lld/
MachO/
2 lines

Diff 318993

lld/MachO/CMakeLists.txt

Show All 26 Linesadd_lld_library(lldMachO2
LINK_COMPONENTS LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
BinaryFormat BinaryFormat
BitReader BitReader
Core Core
DebugInfoDWARF DebugInfoDWARF
LTO LTO
MC MC
ObjCARC ObjCARCOpts
Object Object
Option Option
Passes Passes
Support Support
TextAPI TextAPI
LINK_LIBS LINK_LIBS
lldCommon lldCommon
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
DEPENDS DEPENDS
MachOOptionsTableGen MachOOptionsTableGen
${tablegen_deps} ${tablegen_deps}
) )